--- Log opened Tue Jun 01 00:00:02 2010 |
@preaction | if i'm fixing the asset, i should probably put them in a valid parent, no? | 00:44 |
+perlDreamer | yes | 00:46 |
+perlDreamer | /root/import? | 00:46 |
+perlDreamer | maybe tempspace | 00:46 |
@preaction | root/import for now | 00:47 |
+perlDreamer | it would be considered frivolous to move the extra code out of Calendar's viewWeek into a separate www method, wouldn't it? | 00:51 |
@preaction | actually it would break everything | 00:52 |
+perlDreamer | it would? | 00:52 |
@preaction | the client who ordered that feature extended it | 00:52 |
@preaction | since it is so fragile in there, we can't fix it | 00:52 |
+perlDreamer | what happens if this bug fix breaks it? | 00:54 |
+perlDreamer | now I'm worried | 00:54 |
@preaction | can't help that | 00:55 |
@scrottie | afk a minute... but this is still finding ways to not work. grr. it's mucked itself in a way that resetting the database doesn't fix. | 00:56 |
+perlDreamer | did you clear the cache? | 00:56 |
+perlDreamer | Asset->new caches database properties when it looks them up | 00:57 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 01:00 |
@scrottie | caches them? how do you clear the cache? and does it cache them in the database in a way that wgd doesn't clear out with 'reset'? | 01:04 |
+perlDreamer | the cache is set by the config | 01:05 |
+perlDreamer | it could be persistent in memory | 01:05 |
+perlDreamer | or in disk | 01:05 |
+perlDreamer | or in the db | 01:05 |
@scrottie | oh boy. | 01:05 |
@scrottie | yeah, that most certainly affects debugging. | 01:05 |
@preaction | rm -rf /tmp/WebGUICache; or mysql -e'truncate cache'; | 01:05 |
@preaction | wgd reset SHOULD clear the cache for you | 01:06 |
@preaction | http://gist.github.com/420328 <- anyone see anything missing here? I try to get as much info as possible | 01:10 |
@scrottie | I'm starting to suspect that the only reason that that test ever passed is because it malfunctioned. | 01:12 |
@preaction | quite possible | 01:12 |
@scrottie | oddly though, however it malfunctions to make it pass, it'll do it again now and again. | 01:12 |
@preaction | are you running just the one test? | 01:13 |
@scrottie | running t/Keyword.t | 01:13 |
Haarg | wgd clears the cache in webgui 7. it likely won't handle 8 properly | 01:13 |
@scrottie | with some t/Asset.t thrown in now and then and just prove | 01:13 |
@scrottie | interesting. is there a problem ticket open to that effect? | 01:14 |
+perlDreamer | preaction, line 73 seems odd | 01:14 |
@scrottie | manually clearing the cache for those two schemes makes that test fail... or doesn't help it succeed. | 01:14 |
+perlDreamer | $var = something ||= do {}; | 01:14 |
+perlDreamer | should ||= just be || | 01:14 |
+perlDreamer | also, this only checks entries that are in asset, but not in sub-tables | 01:15 |
+perlDreamer | it doesn't check for any of the other cases | 01:15 |
+perlDreamer | like, existing in assetData, but not any of the others | 01:15 |
@preaction | $var = $something || $something = do {}; <- afterwards, $var and $something will be set | 01:15 |
+perlDreamer | or in a class specific table, but not in others | 01:15 |
Haarg | perlDreamer, with ||= it stores the result in the hash so the next run won't need the do | 01:15 |
@preaction | only those in asset will affect getLineageIterator, no? | 01:16 |
+perlDreamer | yes, but getIsa will be affected by the rest | 01:16 |
@scrottie | /tmp/WebGUICache/* is the backing store Cache::FastMmap uses? | 01:17 |
Haarg | line 68: printf "%-68s", $message; | 01:17 |
@preaction | scrottie: if there's no "cache" : { "root_dir" : "..." } in your config, yes | 01:18 |
@preaction | that default is set in WebGUI::Session->cache() | 01:18 |
@scrottie | cool. thanks. | 01:19 |
Haarg | also, it probably makes more sense to insert values from a previous revision of the asset if one exists | 01:20 |
* perlDreamer goes shopping | 01:43 |
@scrottie | yeah, I'm going to pack it up pretty quick here too. also quite Barbie-esque, I'm going to cook dinner. | 01:55 |
@scrottie | going to push at least that one fix first. | 01:59 |
-!- KlausH [~KlausH@p5B0704DA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] | 02:01 |
@preaction | i'm finding some corrupt assets on tiffany's site from 2009 (no asset entry, assetData entry) | 02:06 |
@preaction | yay! | 02:06 |
@preaction | is database integrity even possible? should I just give up and add the 6 extra lines of boilerplate to my getLineageIterator calls? | 02:07 |
@preaction | Confused? You won't be after tomorrow's episode of WebGUI! | 02:10 |
-!- preaction [~doug@207.200.236.230] has quit [Quit: preaction] | 02:10 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 02:26 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 02:33 |
-!- mode/#webgui [+o preaction] by ChanServ | 02:34 |
@scrottie | ooh, bac, to back episodes | 02:34 |
CIA-59 | webgui: Scott Walters WebGUI8 * r483acbc / (2 files in 2 dirs): | 02:51 |
CIA-59 | webgui: Revert "Calls to set() and update() set attributes as well as "properties"." | 02:51 |
CIA-59 | webgui: This reverts commit 57fe0721ab6049e02c421cf2b1cb387f4eed42da. - http://bit.ly/9HUthc | 02:51 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 240 seconds] | 02:52 |
@scrottie | this makes no sense. tests continue to fail. this thing is mucking itself up in some way I can't comprehend and that has little to do with the code being run. | 03:00 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 03:55 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 03:59 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 04:01 |
-!- mode/#webgui [+o preaction] by ChanServ | 04:01 |
+perlDreamer | preaction, I vote for both | 05:09 |
+perlDreamer | put in the proper handling code for the iterator | 05:10 |
+perlDreamer | it's worth your time | 05:10 |
+perlDreamer | if it was try/catch, you'd like it better | 05:10 |
+perlDreamer | but the semantics are the same | 05:10 |
+perlDreamer | scrottie, it's time to rollback | 05:11 |
+perlDreamer | let's head back to 0ae488290646e4a35b5b75f4edd17870bc583196 | 05:11 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 05:58 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 06:07 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Client Quit] | 06:10 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 06:35 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 06:53 |
-!- CIA-59 [cia@208.69.182.149] has quit [Ping timeout: 260 seconds] | 07:25 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 07:31 |
-!- CIA-57 [cia@208.69.182.149] has joined #webgui | 07:48 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:19 |
-!- kaare is now known as Guest90053 | 08:20 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:34 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:34 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 14:22 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:16 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 15:39 |
-!- vayde [~vayde@65-103-5-102.mpls.qwest.net] has joined #webgui | 15:51 |
-!- Guest90053 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 15:57 |
-!- SDuensin [~Scott@mobile-166-137-143-037.mycingular.net] has joined #webgui | 16:13 |
SDuensin | Morning. | 16:20 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 16:22 |
Haarg | morning | 16:30 |
+bartjol | morning | 16:41 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 17:12 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 17:21 |
@khenn | does anyone know if assetIndex still gets out of sync with the assetData table? | 17:32 |
Haarg | what part of assetIndex do you mean? | 17:33 |
Haarg | the actual indexed content is probably the most likely to get out of date, but i don't know of any particular situation where that happens | 17:33 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 17:43 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 18:05 |
-!- mode/#webgui [+o preaction] by ChanServ | 18:05 |
@preaction | brainstorm: I want one more feature in 7.9, multiple auth methods active on the site for creating users. it shouldn't be too hard. possible problems? | 18:09 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:21 |
@frodwith | preaction: do all of the auth methods support creating users? (I'm wondering about ldap in particular) | 18:38 |
@preaction | LDAP will create a new WebGUI user and link it to an existing LDAP record | 18:39 |
@preaction | but the main thing is: this is the major thing preventing us moving forward with new auth methods like OAuth, Facebook Connect, OpenID | 18:39 |
@frodwith | ah | 18:39 |
@frodwith | pardon my ignorance, but what auth methods do we support right now? | 18:40 |
@preaction | WebGUI, LDAP. | 18:40 |
@frodwith | so we'd write authmethods for all the hip single-sign-on things and let people pick at creation time? | 18:41 |
@preaction | and login, yes | 18:41 |
@frodwith | how do you mean and login | 18:42 |
@preaction | not every login will require a password, and may not even require a username (the username being told to us by the external system) | 18:43 |
@frodwith | right... that doesn't seem to clear up my confusion though. I read what you said as "and let people pick at login time" | 18:44 |
@frodwith | which doesn't make sense to me | 18:44 |
@preaction | they may have to enter their information into the right box for their auth method | 18:45 |
@frodwith | hmm, a user has exactly one auth method, yes? | 18:46 |
@preaction | yes | 18:47 |
@frodwith | couldn't you just ignore the password box when it's not part of the login process? | 18:47 |
@frodwith | or hmm, there's not even a username necessarily. | 18:47 |
@frodwith | so they'd click a link, then, like "login with your facebook id" | 18:48 |
@frodwith | and it'd... do that | 18:48 |
@frodwith | or do we show them all the login methods on the one screen? | 18:48 |
@preaction | i'm thinking the ^L; macro shows just the main auth method with a link to "View other login methods" | 18:49 |
@preaction | then the main displayLogin page aggregates the activated auth methods | 18:50 |
@frodwith | that sounds reasonable. | 18:50 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 18:53 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 18:54 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 19:05 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 19:08 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 19:25 |
@scrottie | perlDreamer, that patch should have been reverted, and before your "time to rollback" comment. did I botch the revert/push? | 19:27 |
@scrottie | oh, he's not here. | 19:28 |
@scrottie | damn, damn, damn. | 19:28 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 19:33 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 19:35 |
-!- mode/#webgui [+v patspam] by ChanServ | 19:35 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 19:52 |
-!- mode/#webgui [+o tavisto] by ChanServ | 19:52 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 20:09 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 20:10 |
ckotil | are there any known issues with the logrotate.pl that ships with wre 0.9.1 ? | 20:22 |
@preaction | it would help if we knew what the issue you're having is | 20:23 |
ckotil | rotating is off, logs start going to .1 .2 .3 and the original logs and .0s get reset to 0 bytes | 20:25 |
ckotil | it wreaks havoc on my awstats | 20:25 |
ckotil | which i run outside of the wre | 20:25 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 20:26 |
@preaction | are you running logrotate twice? is awstats doing its own rotating? i believe you can also configure awstats to remove records as it parses | 20:26 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 20:27 |
ckotil | awstats isnt rotating or removing records | 20:30 |
ckotil | hrmm. i guess ill see if logrotate.pl changed between wre 0.9.1 and 0.9.3 | 20:30 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Ping timeout: 240 seconds] | 21:06 |
ckotil | no difference. after looking at the script for a bit it looks like my expectation of how log rotate scripts should work is differnet than how this logroate script works. | 21:07 |
ckotil | i except logs to always be written to /var/log/somelog , then when logs are rotated it should be moved to /var/log/some.log.1 | 21:08 |
ckotil | but new logs go to /var/log/somelog | 21:08 |
ckotil | then at next rotate somelog.1 goes to somelog.2 , etc... | 21:08 |
@scrottie | start grepping through /var/cron ...? | 21:08 |
@scrottie | see what else is in there? | 21:08 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 21:09 |
@preaction | are the WRE logs in /var/log or /data/wre/var/logs? | 21:09 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 21:09 |
-!- mode/#webgui [+v patspam] by ChanServ | 21:09 |
@khenn | Haarg: I'm working on a site with older data and I've got a lot of assetIndex stuff that does not match what is in the assetData table | 21:09 |
@khenn | just wondering if that is a product of older stuff or if it's still happening | 21:10 |
ckotil | /data/wre/var/logs and /data/domains/mysite/logs | 21:10 |
Haarg | i don't generally remember anything having changed with that, but i also don't know of any known cases that it had problems with | 21:10 |
ckotil | preaction: so logs in /data/wre/var/logs/ get rotated properly | 21:11 |
Haarg | likely a symptom of a general committing problem, which it's hard to say what state it would be in now | 21:11 |
ckotil | i think the apache logs are problematic bc apache still maintains an open file handle on the logs when the script is renaming/unlinking them | 21:11 |
ckotil | logrotated scripts issue a kill -SIGHUP or httpd reload to get around this | 21:12 |
@preaction | apache doesn't do that anymore, and hasn't since 2.0.x | 21:12 |
ckotil | ah | 21:13 |
ckotil | hrm, i wonder my apache logs are so f00bar'd then | 21:13 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 21:14 |
@khenn | yeah I'll keep my eye on it | 21:14 |
@khenn | I really want to see the assetIndex table use triggers to insert it's data | 21:14 |
@khenn | insert / update | 21:14 |
@preaction | database integrity is a myth | 21:15 |
@khenn | delete | 21:15 |
Haarg | there isn't really any way to do that with how we handle it though | 21:15 |
Haarg | since the index data has to be built by perl | 21:15 |
@khenn | I couldn't say right now | 21:15 |
@khenn | but it seems that most of that data is coming from assetData | 21:15 |
@khenn | keywords and size are not | 21:16 |
@khenn | but those could remain in the code | 21:16 |
Haarg | with foreign keys, transactions, and an sql abstraction layer, it's unlikely this type of problem would happen. | 21:16 |
Haarg | but then assetIndex should probably be pulled out eventually anyway | 21:17 |
Haarg | and use a real full text search system | 21:17 |
@khenn | I suppose | 21:17 |
@khenn | not sure what that will do to performance | 21:17 |
Haarg | would probably improve it significantly | 21:17 |
@khenn | asset index is nice because it's a view of all the stuff that *should* be showing up on the site | 21:18 |
@khenn | don't have to deal with revision dates, tags, status, etc | 21:18 |
@khenn | but I really can't trust it | 21:18 |
@khenn | to have accurate information | 21:18 |
ckotil | can you trust a newly built assetIndex? | 21:19 |
@preaction | temporarily | 21:19 |
@khenn | yeah | 21:20 |
@khenn | we re-index the site once a month | 21:20 |
@khenn | via cron | 21:20 |
@khenn | and it still gets out of date | 21:20 |
@khenn | (just remembered that) | 21:20 |
@khenn | I'm guessing there is still crap in webgui directly writing to assetData without using the API | 21:20 |
@khenn | and that's where it's getting hosed | 21:20 |
@preaction | have you nailed down which ones get out of date? when? who did it? | 21:20 |
ckotil | ive got a cront to do it daily. users were complaining about search results being innaccurate. this was back ~7.6 tho | 21:20 |
@khenn | no | 21:20 |
@preaction | stop guessing, start verifying | 21:20 |
@khenn | I don't know why / where / when | 21:20 |
@khenn | it's not important right now, more annoying | 21:21 |
@khenn | someday I'll track it down | 21:21 |
@khenn | busy with other stuff | 21:21 |
-!- preaction [~doug@207.200.236.230] has left #webgui [] | 21:23 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 21:23 |
-!- mode/#webgui [+o preaction] by ChanServ | 21:23 |
-!- preaction [~doug@207.200.236.230] has left #webgui [] | 21:23 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 21:24 |
-!- mode/#webgui [+o preaction] by ChanServ | 21:24 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 21:24 |
-!- Netsplit *.net <-> *.split quits: perlbot | 21:26 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 21:30 |
ckotil | preaction: i think performing a graceful restart of modproxy after logrotate makes it happy | 21:32 |
@preaction | none of our boxes require that, even those on WRE 0.8 series | 21:33 |
ckotil | the logs at least go to domain/sitename/logs/somelog and not domain/sitename/logs/somelog.# | 21:33 |
ckotil | maybe it's bc ive got 25 sites | 21:33 |
@preaction | we've got ones with more | 21:33 |
@preaction | those are on 0.9.3 though | 21:33 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has joined #webgui | 21:34 |
ckotil | logrotate.pl hasnt changed between 0.9.1 and 0.9.3 | 21:34 |
-!- carogray1 [~Caroline@h69-11-184-246.nwlnnh.dedicated.static.tds.net] has left #webgui [] | 21:34 |
@preaction | but 0.9.3 has apache 2.2.11 | 21:34 |
ckotil | i built it w/ 2.2.13 | 21:34 |
ckotil | i had to add php anyway, so i went for the lates. | 21:35 |
* ckotil ducks | 21:35 |
-!- Netsplit over, joins: perlbot | 21:36 |
ckotil | ok , it's rotating fine now w/out the restart. the graceful restart must have gotten it out of bad state or something | 21:37 |
ckotil | which is wierd bc i just restarted it last week for the upgrade to 7.8.20 stable | 21:37 |
ckotil | i bet its the script in /etc/logrotate.d/httpd . deleted. | 21:43 |
-!- preaction [~doug@207.200.236.230] has quit [Ping timeout: 258 seconds] | 21:47 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 21:51 |
-!- mode/#webgui [+o preaction] by ChanServ | 21:51 |
-!- SDuensin [~Scott@mobile-166-137-143-037.mycingular.net] has quit [Read error: Connection reset by peer] | 21:56 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has joined #webgui | 21:57 |
-!- preaction [~doug@207.200.236.230] has quit [Read error: Connection reset by peer] | 22:13 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 22:13 |
-!- mode/#webgui [+o preaction] by ChanServ | 22:13 |
CIA-57 | webgui: Paul Driver master * rc5bddbd / t/Asset/AssetPackage.t : testing clearPackageFlag - http://bit.ly/ceOUQi | 22:32 |
CIA-57 | webgui: Paul Driver master * r3a9c3e5 / (3 files in 3 dirs): checkbox in asset manager for clearPackageFlag - http://bit.ly/bYFARM | 22:32 |
CIA-57 | webgui: Paul Driver master * re88fe85 / lib/WebGUI/AssetPackage.pm : style nits in www_importPackage - http://bit.ly/b4yN1b | 22:33 |
CIA-57 | webgui: Paul Driver master * r426cc20 / docs/changelog/7.x.x.txt : changelog note for new checkbox - http://bit.ly/b9JEuP | 22:33 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has quit [Quit: Leaving] | 22:56 |
-!- vayde [~vayde@65-103-5-102.mpls.qwest.net] has quit [Remote host closed the connection] | 23:50 |
-!- preaction_ [~doug@207.200.236.230] has joined #webgui | 23:52 |
-!- mode/#webgui [+o preaction_] by ChanServ | 23:52 |
-!- preaction [~doug@207.200.236.230] has quit [Read error: Connection reset by peer] | 23:52 |
-!- preaction_ is now known as preaction | 23:52 |
--- Day changed Wed Jun 02 2010 |
@preaction | starting the tests for the release. commit if you got 'em | 00:26 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 00:35 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 00:59 |
@preaction | would our test suite run faster if we consolidated our scripts when possible? i know i split the Photo and Gallery tests, but if we join them again it should speed things up, no? | 01:12 |
@scrottie | I'd be surprised if joining them speed things up. | 01:13 |
Haarg | it would definitely speed things up | 01:14 |
@scrottie | do a time perl -c on the .t to get a figure for the startup time. | 01:14 |
Haarg | Test::Class is probably a better solution to joining tests though | 01:14 |
@frodwith | right, it would obviously speed things, the question is how much | 01:15 |
@frodwith | and my guess is "not a whole heck of a lot" | 01:15 |
Haarg | in my experience | 01:15 |
Haarg | a lot | 01:15 |
@preaction | 2.4 real. 1.1 user. for t/Asset/File/GalleryFile/Photo/00base.t | 01:15 |
@frodwith | what are we doing at test setup and teardown that takes so long? | 01:17 |
@preaction | ran it over the whole photo set gives about 1.2 user, 2.5 real | 01:17 |
@preaction | so over 314 test files we have 15 minutes of setup | 01:17 |
Haarg | frodwith, loading .pm files | 01:18 |
@frodwith | Haarg: are we preloading the whole webgui tree for every test or something silly like that? | 01:18 |
Haarg | not preloading | 01:18 |
Haarg | but most of the files get pulled in through use statements anyway | 01:18 |
Haarg | everything requires everything else | 01:19 |
@frodwith | shouldn't be that nasty though | 01:19 |
@frodwith | what's taking so long to load? | 01:19 |
@frodwith | in particular? | 01:19 |
@preaction | our dep tree includes a lot of stuff | 01:19 |
@frodwith | Hrmph. I smell a rat. | 01:20 |
@frodwith | but I'm too lazy to dig out a profiler and catch it. | 01:21 |
Haarg | i never bothered to figure out what parts were taking the longest | 01:21 |
Haarg | it's in general just that by loading ::Session you end up pulling in most of the source tree | 01:21 |
Haarg | or at least a good portion of it | 01:22 |
@frodwith | yeah, but it shouldn't take 2 seconds to load the source tree, should it? | 01:22 |
@frodwith | just doesn't seem right, somehow. | 01:22 |
Haarg | i was going to say how long it takes to load here, but i'll have to wait until my git-filter-branch finishes | 01:23 |
@preaction | i've been running Devel::LeakTrace::Fast for the last day or two, that could cause a slowdown | 01:24 |
Haarg | frodwith, on my machine: http://gist.github.com/421697 | 02:47 |
@preaction | Haarg: did you try using weaken on session refs before? | 02:47 |
Haarg | for some things | 02:48 |
Haarg | that's the webgui8 & psgi & upgrades code, but i doubt it is too far off from the other branches | 02:48 |
@preaction | i'm having tests fail because there's no $session->config and no $session->asset | 02:48 |
Haarg | psgi weakens session on all of the ::Session:: classes | 02:49 |
Haarg | what kind of weakening are you doing? | 02:49 |
@preaction | weaken( $self->{_session} ); | 02:50 |
@preaction | weakening the session in all these objects, because that's where Devel::Cycle wanted me to | 02:50 |
@preaction | figured it out. i also weakened $session->{_asset} | 02:51 |
Haarg | yeah, can't do that | 02:51 |
@preaction | and i had ->close() also destroy $session->{_config} | 02:51 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 260 seconds] | 02:57 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 03:06 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 03:10 |
CIA-57 | webgui: Doug Bell master * rf2e0fb5 / docs/create.sql : preparing for 7.9.6 release (+6 more commits...) - | 03:41 |
CIA-57 | webgui: Doug Bell master * r1f492b5 / lib/WebGUI/Asset/Wobject/Navigation.pm : fix navigation problem - http://bit.ly/aeWxWp | 04:18 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 04:58 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 04:58 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 04:59 |
-!- preaction changed the topic of #webgui to: [7.8.20-stable | 7.9.6-beta | WRE 0.9.3] Before you ask, check the wiki: http://wiki.webgui.org | Pastebin: http://webgui.pastebin.com | 05:13 |
-!- preaction [~doug@207.200.236.230] has quit [Quit: preaction] | 05:14 |
CIA-57 | webgui: Doug Bell master * rdcf8b74 / (4 files in 4 dirs): preparing for 7.9.7 dev - http://bit.ly/9Kb4sn | 05:14 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 05:55 |
-!- mode/#webgui [+o preaction] by ChanServ | 05:55 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 06:13 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 07:06 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 07:35 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 07:35 |
* scrottie waves to perlDreamer | 07:35 |
+perlDreamer | hey, scrottie | 07:35 |
+perlDreamer | what's up? | 07:35 |
@scrottie | oh, you know | 07:36 |
+perlDreamer | did you get any farther with WebGUI8/keywords today? | 07:37 |
@scrottie | I figured out one version of what needs to happen to get the t/Assets.t tests to pass with the set-both-attributes-and-properties change in but I need to read more to understand why some attributes are problematic and others are necessary | 07:38 |
@scrottie | and I've convinced myself that t/Keyword.t's results are meta-stable random. | 07:39 |
@scrottie | the state of the code is the minor factor in which tests pass. sometimes after killing the mmap cache file and clearing the database, two tests will fail. sometimes three. every now and then, four. | 07:40 |
@scrottie | flop the code over to the other version, the behavior won't change (with mmap cache clear and db reinit). flop it back, it changes. | 07:40 |
@scrottie | this is maddening. | 07:40 |
@scrottie | next step is to do a full -d:Trace of various behaviors and diff the outputs to see where execution varies. | 07:41 |
@scrottie | so, how's stuff there? | 07:41 |
+perlDreamer | I spent all day doing commencement stuff | 07:43 |
+perlDreamer | just trying to get caught up with the Wonderful World of WebGUI | 07:43 |
@scrottie | that's right. you said you were in for four days of family stuff. | 07:44 |
+perlDreamer | no, just 1, today | 07:44 |
+perlDreamer | oh, wait | 07:44 |
+perlDreamer | yeah, this is day four of four | 07:44 |
+perlDreamer | so tomorrow, back to the grind | 07:44 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 07:56 |
-!- mode/#webgui [+o preaction] by ChanServ | 07:56 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:08 |
-!- kaare is now known as Guest41943 | 08:09 |
@scrottie | well, hell. | 08:24 |
+perlDreamer | you found it? | 08:28 |
@scrottie | no, but I established that completely nuking the data (rm -rf /usr/local/var/mysql, etc) and re-initializing it makes the first of the failing tests pass, once. | 08:29 |
@scrottie | then it fails the next time, wgd reset or no. | 08:29 |
+perlDreamer | then there's something getting stored in the db | 08:30 |
+perlDreamer | which seems odd | 08:31 |
+perlDreamer | since before the keywords patch, the statefulness of the tests was much more predictable | 08:31 |
@scrottie | that doesn't seem to be the case. even without it, I get results based on its mood. | 08:31 |
@scrottie | at least on this install, on this machine. | 08:31 |
+perlDreamer | tomorrow, after doing the boards, I'll try to rollback a WebGUi8 branch before that commit | 08:33 |
+perlDreamer | and run prove twice in a row, and look for differenences in test outpu | 08:33 |
@scrottie | I reverted and pushed that some time before you suggested I do so, yesterday | 08:33 |
+perlDreamer | logically, that presumes that the revert was completely successful, too | 08:34 |
+perlDreamer | have you also tried a VM running the WRE? | 08:35 |
@scrottie | nope. | 08:35 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 08:35 |
+perlDreamer | for comparison, I'll do the same comparison on WebGUI8:HEAD | 08:37 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 08:59 |
@scrottie | I'm guessing that after the $keyword asset is scrapped, there shouldn't be 556 assets in trash-limbo. | 09:08 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 09:51 |
-!- mode/#webgui [+v bartjol] by ChanServ | 09:51 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Read error: Connection reset by peer] | 12:06 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:06 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:06 |
-!- carogray [~Caroline@72-59-0-31.pools.spcsdns.net] has joined #webgui | 12:56 |
-!- carogray [~Caroline@72-59-0-31.pools.spcsdns.net] has quit [Quit: Leaving.] | 14:40 |
-!- carogray [~Caroline@72-59-0-31.pools.spcsdns.net] has joined #webgui | 14:52 |
-!- carogray [~Caroline@72-59-0-31.pools.spcsdns.net] has quit [Read error: Connection reset by peer] | 15:18 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:23 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 15:40 |
-!- vayde [~vayde@71-34-33-161.mpls.qwest.net] has joined #webgui | 15:56 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 16:09 |
-!- Guest41943 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 16:16 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has joined #webgui | 16:28 |
SDuensin | Greetings. | 16:31 |
-!- KlausH [~KlausH@p5B0706C7.dip0.t-ipconnect.de] has joined #webgui | 16:39 |
CIA-57 | WebGUI: translation * r12508 /translations/German/German/Asset.pm: Updating German on translation server | 16:40 |
CIA-57 | WebGUI: translation * r12509 /translations/German/German/Asset_Gallery.pm: Updating German on translation server | 16:40 |
CIA-57 | WebGUI: translation * r12510 /translations/German/German/Asset_Photo.pm: Updating German on translation server | 16:40 |
CIA-57 | WebGUI: translation * r12511 /translations/German/German/Macro_PickLanguage.pm: Updating German on translation server | 16:40 |
CIA-57 | WebGUI: translation * r12512 /translations/German/German/Asset_SyndicatedContent.pm: Updating German on translation server | 16:40 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Ping timeout: 260 seconds] | 16:50 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 17:09 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 17:16 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Client Quit] | 17:17 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 17:18 |
CIA-57 | WebGUI: translation * r12513 /translations/Dutch/Dutch/ (8 files): Updating Dutch on translation server | 17:25 |
CIA-57 | WebGUI: translation * r12514 /translations/Dutch/Dutch/ (Asset_Collaboration.pm WebGUI.pm): Updating Dutch on translation server | 17:25 |
CIA-57 | WebGUI: translation * r12515 /translations/Dutch/Dutch/Asset_WikiMaster.pm: Updating Dutch on translation server | 17:25 |
-!- KlausH [~KlausH@p5B0706C7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] | 17:38 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 17:43 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 17:43 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 17:45 |
-!- mode/#webgui [+v patspam] by ChanServ | 17:45 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 17:48 |
-!- mode/#webgui [+o preaction] by ChanServ | 17:49 |
plainhao | can i get github push privs for helpdesk again? | 17:49 |
plainhao | i've posted a fix for bug 11512. | 17:50 |
+bartjol | I always prompt perlDreamer for that stuff :) | 17:57 |
+perlDreamer | frodwith: could you please consider plainhao's patch for bug #11512 in light of the work you may have started on the helpdesk? | 17:58 |
@frodwith | perlDreamer: I'm not familiar with this piece of the code, and all the js for helpdesk is being rewritten from scratch. | 18:02 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 18:13 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:14 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:14 |
+perlDreamer | well, okay | 18:18 |
+perlDreamer | plainhao, I can't grant you commit privileges | 18:18 |
+perlDreamer | given that it's going to be rewritten, do you still the patch applied? | 18:18 |
+perlDreamer | If so, I can do that later today | 18:18 |
* plainhao didn't know about the rewrite, so no, the patch probably isn't that critical. | 18:20 |
Haarg | fork -> commit -> send pull request | 18:20 |
+perlDreamer | that works, too | 18:20 |
plainhao | okey, will do what Haarg suggested. | 18:21 |
+bartjol | oh, another thing, Bernd wondered about the quietness of the forum and irc channel. Do we miss something in europe? Is webgui so clear nowadays that no questions have to be asked? | 18:23 |
+perlDreamer | It was memorial day | 18:23 |
+perlDreamer | plus I was on vacation for 1 day | 18:23 |
+bartjol | well, more in general | 18:23 |
+bartjol | it seems quiet lately | 18:24 |
+perlDreamer | I think we have few new users | 18:24 |
+perlDreamer | and the old ones already know the grotty spots | 18:24 |
+bartjol | mmm, then we prolly need more | 18:24 |
+bartjol | how's JT's world order coming along? | 18:25 |
+perlDreamer | I think that the recent spate of world leaders who have resigned would mean that his efforts to foment unrest are successful | 18:26 |
+bartjol | ah, so he just have to seize his opportunity and step forward as the new queen bee | 18:28 |
+perlDreamer | yes :) | 18:28 |
+perlDreamer | how is the sailing in Europe, bartjol? | 18:36 |
@khenn | hey perlDreamer | 18:36 |
+bartjol | well, a lot of fog the last time | 18:36 |
@khenn | looks like Hao just committed a bug fix to help desk which fixes pagination in the search | 18:36 |
+perlDreamer | hey, khenn! | 18:36 |
+bartjol | 50 meters sight, especially at the harbour that is quite scary | 18:37 |
@khenn | any chance you could look that over real quick and patch plainblack.com and webgui.org ? | 18:37 |
+perlDreamer | look over, yes | 18:37 |
+perlDreamer | real quick, no | 18:37 |
@khenn | heh | 18:37 |
* perlDreamer is elbow deep in calendar guts | 18:37 |
@khenn | gotcha | 18:37 |
@khenn | maybe preaction can do it | 18:37 |
@khenn | =) | 18:37 |
+perlDreamer | oh yeah, he always has tons of free time | 18:38 |
+perlDreamer | :P | 18:38 |
+bartjol | beer o clock, bye | 18:39 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:39 |
plainhao | i like the clocks in europe. | 18:39 |
@khenn | hey, there's hao! | 18:40 |
@khenn | how've you been? | 18:40 |
plainhao | ok | 18:41 |
plainhao | how's the gang? | 18:41 |
@khenn | hanging in there | 18:41 |
@khenn | I just wrote a custom method for a client to approve a version tag as a different user than is in the session: | 18:42 |
plainhao | nice | 18:42 |
@khenn | approveAsUser ( userId , options) | 18:42 |
@khenn | anyone want to see that in core? | 18:42 |
@khenn | otherwise I'll just leave it in my custom stuff | 18:42 |
plainhao | that sounds useful | 18:42 |
+perlDreamer | yes, I want to see that | 18:42 |
@khenn | ok | 18:42 |
+perlDreamer | it would help me with fixing one of your bugs | 18:42 |
@khenn | I'll add it to 7.9 now then | 18:42 |
+perlDreamer | I think | 18:42 |
+perlDreamer | just make sure it has tests | 18:42 |
@khenn | ok | 18:43 |
@khenn | I'll add it to 7.9 later | 18:43 |
@khenn | heh | 18:43 |
+perlDreamer | slacker! | 18:43 |
@khenn | it's gonna be hard to test | 18:43 |
+perlDreamer | why? | 18:43 |
@khenn | because ... | 18:43 |
@khenn | well let me look at the tests | 18:43 |
@khenn | maybe not as hard as I'm thinking | 18:43 |
+perlDreamer | I think you need to create a version tag | 18:43 |
@khenn | guess I just need to check that it was committed by the right person | 18:43 |
+perlDreamer | create a user | 18:43 |
+perlDreamer | call approveAsUser | 18:44 |
+perlDreamer | with new user | 18:44 |
@khenn | commitAsUser | 18:44 |
@khenn | not approve =) | 18:44 |
+perlDreamer | 08:42:16 AM) khenn: approveAsUser ( userId , options) | 18:44 |
@scrottie | hey, hey, hey. | 18:44 |
@khenn | whoops | 18:44 |
@khenn | sorry | 18:44 |
@khenn | it's commitAsUser | 18:44 |
+perlDreamer | okey-doke | 18:44 |
@khenn | hey scrottie | 18:44 |
@khenn | it creates a temporary session as the new user | 18:45 |
@khenn | casts the version tag into the session | 18:45 |
@khenn | then commits it | 18:45 |
@scrottie | perlDreamer, I attempted an SMTP delivery to you late last night. don't know if that went through. short version, tests pass but the fix is hackish and I need to read more to find a on-hackish way to do it. | 18:45 |
plainhao | is there a way to look up a versiontag by name? | 18:45 |
+perlDreamer | scrottie, I got it | 18:45 |
@scrottie | cool. | 18:45 |
+perlDreamer | plainhao, no, names are not unique | 18:45 |
@khenn | no just by tagId | 18:45 |
@khenn | you could write something that got all the version tags that have a certain name | 18:46 |
+perlDreamer | all day events suck | 18:47 |
@scrottie | I've been missing my Palm III lately. | 18:48 |
@khenn | looks like you are right perlDreamer | 18:48 |
@khenn | should be pretty easy | 18:48 |
@khenn | create version tag | 18:48 |
@khenn | create user | 18:48 |
@khenn | commit as user | 18:48 |
@khenn | check version tag to see who committed | 18:48 |
+perlDreamer | also, make sure the temporary session was cleaned up | 18:51 |
@khenn | right | 18:52 |
+perlDreamer | technically, you can skip that part, because WebGUI::Test will check for that | 18:53 |
@khenn | k | 18:53 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Ping timeout: 248 seconds] | 19:00 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 19:05 |
+perlDreamer | I think I've got the calendar bug fixed | 19:10 |
+perlDreamer | I'll confirm it after I come back from the gym | 19:11 |
+patspam | perlDreamer: you still there? | 19:18 |
@scrottie | if by "there" you mean "at the gym", I'm guessing yes ;) | 19:23 |
@scrottie | I'm thinking of doing a morning errand and clocking in slightly later. | 19:24 |
+perlDreamer | patspam, I'm back | 20:15 |
+patspam | perlDreamer: heh now I'm heading out (lunch), will hit you up later today | 20:23 |
+perlDreamer | sorry, dude :/ | 20:23 |
@preaction | perlDreamer: got a minute? | 20:23 |
+perlDreamer | catch you later then | 20:23 |
+perlDreamer | yup | 20:23 |
+perlDreamer | let me scrape off these Calendar bits | 20:23 |
+perlDreamer | what's up, preaction? | 20:23 |
@preaction | when i ran the test suite for the 7.9.6 release, there were a lot of | 20:23 |
@preaction | # Scratch : 5 (delta +1) | 20:23 |
@preaction | stuff | 20:23 |
@preaction | notably sessions | 20:23 |
@preaction | is that the leaking you refer to in the build instructions? | 20:24 |
+perlDreamer | yes | 20:24 |
@preaction | is that a problem with the tests or with the code? or is that what i have to determine? | 20:24 |
+perlDreamer | it's 85% likely to be in the core | 20:24 |
+perlDreamer | since it didn't do that two weeks ago | 20:24 |
@preaction | right | 20:24 |
@preaction | okay, i'll get cracking | 20:25 |
@preaction | i made two huge changes, so i'm pretty sure where to start looking | 20:26 |
+perlDreamer | it's a little nicer than leaking memory, but having those scratch sessions in the db just takes up space | 20:32 |
* SDuensin just tooted the WebGUI horn again. Local Linux group wants a new site. :-) | 20:34 |
+perlDreamer | Good job, SDuensin! | 20:34 |
SDuensin | #1 fan. Don't forget it. :-) | 20:34 |
+patspam | perlDreamer: oink | 21:37 |
+patspam | for when you backlog.. | 21:41 |
+patspam | in my ongoing "how to cause problems by using User Profiling fields to store internal data" saga | 21:41 |
+patspam | DateTime is similarly problematic | 21:41 |
+patspam | on a different site I had a profile field called consentDate (DateTime) that was used to record the date that a user completed the Terms & Conditions DataForm | 21:42 |
+patspam | if the user hadn't done it yet, clicking Save on the Edit Profile page would set their consentDate to the current date & time | 21:43 |
+patspam | my workaround is to create a new User Profile category called "internal stuff", move all the internal stuff that should never be displayed on the Edit Profile page (even to Admins) into the category, and then hack WebGUI::Operation::User so that it skips over that category when generating the Edit Profile page | 21:45 |
@preaction | um... so it seems that the leaking disappeared miraculously... is that good? | 21:46 |
@preaction | patspam: does it need to be in the userProfileData table? can you join your own table? | 21:46 |
+patspam | I think we need to either decide that User Profile fields should not be used for this purpose, or give people the ability to hide fields (or categories) entirely from the Edit Profile page | 21:46 |
+patspam | preaction: definitely! | 21:47 |
@preaction | problem: user cleanup | 21:47 |
@preaction | solution: on delete workflow activity! | 21:47 |
+patspam | heh | 21:48 |
+patspam | I wanted to use User Profiling because it basically did everything I needed | 21:48 |
@preaction | except this one thing? | 21:48 |
+patspam | yeah, this is a gotcha | 21:48 |
@preaction | you could override the WebGUI::Account::Profile module to do what you wanted | 21:48 |
+patspam | yeah, that's what I did (Op::User) | 21:49 |
+patspam | I think we should make it possible to flag fields as "internal" (perhaps only via code, not via the UI) | 21:49 |
+patspam | because the profiling machinery is very handy for simple cases where you want to hang a bit of extra data on a user account | 21:50 |
@preaction | well, Operation::User is the admin interface. if we had things my way, the Profile system would be how admins would edit users as well | 21:50 |
+patspam | yeah that would solve my problem.. I only get the problems because Admins see all fields, regardless of whether they are visible, editable etc.. | 21:50 |
@preaction | that way, the ONE way to edit users would be overridable by you, the programmer | 21:51 |
+patspam | yep, and I wouldn't need to override anything | 21:51 |
+patspam | just set it to invisible | 21:51 |
+patspam | I definitely want to keep on using the user profiling system for this sort of stuff.. it's the same reason I use wG overall - saves you from re-inventing the wheel every time | 21:52 |
@preaction | precisely | 21:52 |
+patspam | sometimes you want Admins to be able to see/edit profile fields that users can't though | 21:53 |
@preaction | most likely, the Profile module would work as the Operation::User module works now, but it would then be overridable | 21:54 |
+patspam | but Op::User doesn't let you hide fields at all | 21:55 |
@preaction | right. "hidden" fields would be "Admin Only" instead. | 21:56 |
+patspam | and we'd need "Not even Admins" to overcome the problem I'm experiencing | 21:57 |
@preaction | that's what overriding the module would do for you, you could add that feature without needing to run it past me | 21:57 |
@preaction | couldn't you change it to a ReadOnly fieldType? | 21:57 |
@preaction | or perhaps a Hidden fieldtype would be nice? | 21:58 |
-!- ekennedy1 [~ekennedy@173-141-249-176.pools.spcsdns.net] has joined #webgui | 21:58 |
+patspam | take DateTime.. I'm coupled to the fact that it's a datetime mysql field | 21:58 |
-!- ekennedy1 [~ekennedy@173-141-249-176.pools.spcsdns.net] has left #webgui [] | 21:58 |
@preaction | that's a problem? | 21:58 |
+patspam | well the Form type determines the field type, so I couldn't just switch to some generic Form::Hidden right? | 21:59 |
@preaction | ah | 22:00 |
+patspam | I'd need to create a new Form class that subclasses Form::DateTime and does everything the same except hides itself from view | 22:01 |
+patspam | I'd prefer that we embrace the idea of people using User Profiling fields for internal data in the wG API, and provide a way to flag fields that should be hidden completely from Edit Profile | 22:02 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 260 seconds] | 22:04 |
@preaction | patspam: what about the users table instead? | 22:12 |
+patspam | hang custom data there? | 22:13 |
@preaction | yeah | 22:14 |
+patspam | but then you'd need to write the code to modify the users table | 22:15 |
+patspam | you get that for free with User Profiling | 22:15 |
@preaction | why? just alter table | 22:15 |
+patspam | yeah that's what I mean | 22:15 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Ping timeout: 240 seconds] | 22:15 |
+patspam | s/code/sql/ | 22:15 |
@preaction | would be much more work to add a "Really Hide Field" flag to the profile fields | 22:16 |
+patspam | but it's a change you make once, to the core, and then everyone benefits | 22:16 |
+patspam | where everyone = possibly just me ;) | 22:17 |
@preaction | would a readonly flag work? | 22:18 |
+patspam | yeah I think so, all we need to do is stop Op::User from displaying the field to Admins | 22:18 |
@preaction | having a "visible" and "hide from admin" seems .. bad | 22:19 |
@preaction | but having readonly work for admins as well | 22:19 |
+patspam | oh, readonly | 22:19 |
+patspam | that would work too | 22:19 |
+patspam | possibly preferable | 22:19 |
+patspam | because then you can pseudo debug the extra user data | 22:19 |
+patspam | essentially what I did in the case of a Group field (turning it into a Guid field) | 22:20 |
+patspam | I like being able to see the groupId there when I'm diagnosing something | 22:20 |
+patspam | but I think that would be more work | 22:21 |
+patspam | because you'd have to make it work for all Form:: classes | 22:21 |
+patspam | whereas excluding the field altogether is independent of the class | 22:21 |
+perlDreamer | patspam, the problem only exists with "typed" fields that prepopulate | 22:22 |
@preaction | all fields can be turned readonly, it's part of the class | 22:22 |
@preaction | it just calls getValueAsHtml | 22:22 |
+patspam | oh, perfect :) | 22:22 |
+patspam | current options include: Visible, Editable & Required, all which implicitly refer to what the end user (as opposed to the Admin) can see/do | 22:24 |
+patspam | rather than calling this "Readonly", which would be confusing to distinguish from Editable | 22:25 |
+patspam | I think it should be called something that implies "not modified by users" | 22:25 |
+perlDreamer | users, including Admin | 22:26 |
+patspam | yeah | 22:26 |
+perlDreamer | which means that if there's a problem, an Admin couldn't fix the value | 22:26 |
+patspam | or more generally, not editable via the UI | 22:26 |
+patspam | yep, it's only ever supposed to be modified by code | 22:26 |
+patspam | we can't let Admins edit it, because of bug #11586 | 22:27 |
+patspam | s/bug/rfe/ | 22:27 |
bipolar | Can anyone help me get form emails working? I setup a form, set 'Email Data' to yes and I set the To field to the address I want. In the webgui settings, under the 'messaging' tab I have the ip address of my mail server in the SMTP server field. I'm not seeing a connection from webgui in my mail server logs. any idea what I could be doing wrong? | 22:29 |
+perlDreamer | bipolar, is spectre running? | 22:30 |
bipolar | yes | 22:30 |
+perlDreamer | are there errors in the WebGUI log file? | 22:30 |
+patspam | bipolar: the "wgd mail" command line tool is handy for diagnosing that | 22:30 |
@preaction | is the mailQueue empty? | 22:30 |
bipolar | I don't see anything in the log files. Let me get my enviro setup so I can run the wdg command... | 22:31 |
@preaction | what does perl spectre.pl --test say? | 22:32 |
-!- carogray [~Caroline@174-152-122-82.pools.spcsdns.net] has joined #webgui | 22:32 |
+perlDreamer | bipolar, in addition to wgd mail, it would be good to up the logging level to WARN or INFO until you get this problem resolved | 22:32 |
bipolar | hmm... where do I find the wgd command? | 22:33 |
+perlDreamer | it's an extra add-on, bipolar | 22:33 |
+perlDreamer | you can get a copy from the bazaar | 22:33 |
bipolar | oh... | 22:33 |
+perlDreamer | or, you can build a copy by hand from github | 22:34 |
+perlDreamer | it doesn't come with the WRE | 22:34 |
+perlDreamer | ... yet | 22:34 |
+patspam | :) | 22:34 |
+perlDreamer | bipolar: to summarize: check the mailQueue table for entries. If there are entries in there, and they stay in there longer than 10 minutes, it's a WebGUI/spectre issue. | 22:35 |
+perlDreamer | get a copy of wgd, because it makes maintaining and debugging WebGUI sites delightful | 22:35 |
bipolar | ok. I'll grab wgd | 22:36 |
+perlDreamer | also, run the built-in spectre debuggin commands spectre.pl --test for additional, easy diagnostics | 22:36 |
CIA-57 | wgdev: Graham Knop master * r1fcfab3 / lib/WGDev/Command/Reset.pm : use reasonable defaults if uploads directory doesn't exist - http://bit.ly/9HFrJ8 | 22:37 |
Haarg | i really need to put out a new version | 22:38 |
+perlDreamer | yeah! | 22:39 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:43 |
+perlDreamer | hm | 22:43 |
+patspam | how about calling the new User Profiling option "Admin Editable" | 22:44 |
bipolar | I take it I should install wgd's missing perl prerequisites from cpan, right? | 22:44 |
+perlDreamer | bipolar: yes | 22:44 |
bipolar | kk | 22:44 |
+perlDreamer | patspam: it would have to be default ON for all new, and existing profile fields, yes? | 22:44 |
+patspam | yep | 22:44 |
+perlDreamer | I think something that users have to turn on would be better | 22:44 |
+perlDreamer | rather than off | 22:44 |
+patspam | yeah, to preserve existing behaviour | 22:45 |
+perlDreamer | pop quiz for any dev in the channel: which assetLineage option for relatives doesn't use lineage at all? | 22:45 |
+patspam | bipolar: if you follow http://www.webgui.org/wiki/the-wre-and-your-shell-environment you can just run "wre cpan ." in the wgd directory and it will install all the dependencies for you | 22:45 |
bipolar | patspam: yeah, that would have been a little quicker :) | 22:46 |
+patspam | or you don't even need to run wgd via WRE's perl | 22:46 |
bipolar | this server is really nakid. very limited system perl. It just runs Webgui | 22:47 |
+patspam | (but that would involve installing all of WebGUI's dependencies into your other Perl) | 22:47 |
+patspam | oh ok, no WRE? | 22:47 |
bipolar | patspam: yeah. I used WRE. | 22:47 |
bipolar | it's a bare bones debian install with WRE and thats it. | 22:48 |
+patspam | oh, I see | 22:48 |
bipolar | ok. wgd is built | 22:48 |
+patspam | perlDreamer: self? | 22:50 |
+perlDreamer | hm, that's two | 22:50 |
+patspam | and siblings and children use parent | 22:51 |
bipolar | wgd doesn't seem to be autodetecting my webgui root directory. | 22:51 |
+patspam | set export WEBGUI_ROOT=/data/WebGUI (or whatever) | 22:51 |
Haarg | it should autodetect it if you are in it or a subdirectory | 22:52 |
+patspam | and similarly for WEBGUI_CONFIG | 22:52 |
Haarg | or if the WEBGUI_ROOT env var is set | 22:52 |
bipolar | Mail queue has 8 message(s). | 22:53 |
Haarg | i should probably just stick wgdev on cpan even though it is useless on its own | 22:53 |
Haarg | updated the version in the bazaar | 22:53 |
+patspam | yeah, would make it easier for people to install | 22:53 |
+patspam | always takes me 2 minutes to find it in the bazaar | 22:53 |
Haarg | alternatively | 22:54 |
Haarg | curl -O http://haarg.org/wgd && chmod +x wgd | 22:54 |
+patspam | fatpacker++ | 22:55 |
Haarg | yeah, works much better than what i had been doing prior | 22:55 |
Haarg | although it makes extracting pod annoying | 22:55 |
CIA-57 | wgdev: Graham Knop master * r588e676 / (4 files in 4 dirs): update changes file and version numbers - http://bit.ly/9NAAZK | 22:57 |
CIA-57 | wgdev: Graham Knop master * re02c487 / lib/WGDev/Asset.pm : silence potential warnings - http://bit.ly/9uxdqu | 22:57 |
CIA-57 | wgdev: Graham Knop master * r326a15b / bin/wgd : remove version from wgd script file - http://bit.ly/aMnXRi | 22:57 |
+perlDreamer | I don't think wgd would be any different from any other plugin that requires a base to operate | 22:58 |
bipolar | I think I got something.... | 22:58 |
bipolar | ERROR - spectre.conf - POE::Kernel::_dispatch_event[1056] - ADMIN: Couldn't fetch Spectre configuration data for www.example.com.conf : malformed JSON string, neither array, object, number, string or atom, at character offset 0 ["<!DOCTYPE html PUBLI..."] at ../lib/Spectre/Admin.pm line 158. | 22:59 |
bipolar | thats in webgui.log | 22:59 |
+patspam | you have a syntax error in your site config | 22:59 |
bipolar | grrr | 22:59 |
+patspam | err | 22:59 |
+patspam | no | 22:59 |
+perlDreamer | check spectre.conf | 22:59 |
+patspam | sorry | 22:59 |
+perlDreamer | for JSON syntax errors | 22:59 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 22:59 |
-!- mode/#webgui [+o tavisto] by ChanServ | 22:59 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has quit [Quit: Leaving] | 23:00 |
Haarg | it's not spectre with the priblem | 23:01 |
+patspam | http://www.webgui.org/rfe/request-for-enhancement/11607 ("Admin Editable" for User Profile fields) | 23:01 |
bipolar | perlDreamer: the spectre.conf file is an exact copy of the example file. I just checked with diff. I don't see anything in the file that it should be hung up on, but I'm not familure with the format. | 23:01 |
Haarg | the site is giving back html of some kind instead of json data | 23:01 |
Haarg | is the sitename set correctly in the config file? | 23:02 |
bipolar | ah.... I'm running on an ip address. | 23:02 |
bipolar | let me set it in the hosts file. | 23:02 |
Haarg | the first entry needs to be something that will resolve to the correct site | 23:02 |
bipolar | ok. the error message is gone | 23:04 |
+perlDreamer | bipolar, now you should restart spectre | 23:11 |
+perlDreamer | so that it gets the config data from WebGUI for your site | 23:11 |
+perlDreamer | or does it do that automatically....? | 23:11 |
@preaction | you must restart for any conf changes | 23:11 |
bipolar | perlDreamer: 'wreservice.pl --restart spectre' should do that, right? | 23:11 |
@preaction | and webgui probably | 23:11 |
@preaction | wreservice.pl --restart modperl spectre | 23:12 |
bipolar | wreservice.pl --restart all | 23:12 |
bipolar | :P | 23:12 |
@preaction | why shutdown mysql and modproxy if you don't have to? | 23:12 |
+perlDreamer | they need to be taught a lesson | 23:12 |
bipolar | they're not being used for anything else, might as well beat them too | 23:13 |
bipolar | ok. there are still 8 messages in the queue | 23:13 |
+perlDreamer | the spectre mail queue processor runs every 5 minutes or so | 23:13 |
+perlDreamer | give it a bit | 23:13 |
+perlDreamer | and watch webgui.log for more problems | 23:14 |
bipolar | *sigh* | 23:14 |
bipolar | WebGUI::Session::ErrorHandler::security[404] - Visitor (1) connecting from 127.0.1.2 attempted to Tried to make a Spectre workflow data load request, but we're only allowed to accept requests from 127.0.1.1/32,127.0.0.1/32. | 23:14 |
bipolar | back to the hosts file... | 23:14 |
+perlDreamer | :) | 23:14 |
Haarg | there is a setting in the site config file for that | 23:15 |
Haarg | spectreSubnets or something | 23:15 |
bipolar | too late! I already beat on the hosts file and am restarting ;P | 23:15 |
bipolar | nothing in the log file yet. | 23:18 |
+perlDreamer | it's like Heinz ketchup | 23:18 |
+perlDreamer | anticipation is making you wait | 23:18 |
bipolar | so I should bang on the side of the case until red stuff comes out the other side? | 23:18 |
bipolar | hmm... how would I do that for a VM? | 23:19 |
@khenn | does anyone know if you can call duplicate on an asset and then append the new asset you just created directly to another parent (similar to addChild)? | 23:20 |
+perlDreamer | setParent | 23:20 |
+perlDreamer | or, call addChild on the new parent with $oldAsset->get for the properties | 23:21 |
@scrottie | ugh | 23:21 |
bipolar | woot! there they are | 23:21 |
bipolar | the email just dumped | 23:21 |
+perlDreamer | there ya go, bipolar | 23:21 |
@khenn | thanks pd | 23:21 |
@khenn | I think that's what I've been looking for | 23:21 |
@khenn | I figured copy and paste would do it | 23:22 |
@khenn | but they do some weird sorcery that I got tired of tracing | 23:22 |
@scrottie | ... which is exactly what won't work in 8.0 as it is. and I guess I can't count on addRevision to sort things out to make it work. | 23:22 |
+perlDreamer | paste requires that the current asset be the new parent | 23:22 |
@scrottie | I was just getting around to looking at how to fix this cleanly. | 23:22 |
bipolar | thanks perlDreamer, Haarg, preaction, patspam | 23:23 |
+perlDreamer | bipolar, if you learned anything interesting, please consider adding a page to the wiki on webgui.org | 23:23 |
@scrottie | maybe get() just shouldn't return attributes that still have default values unless explicitly requested. | 23:23 |
+perlDreamer | get() has to return ALL attributes, except for session | 23:23 |
+perlDreamer | if you change how get() works, then you get to rewrite 65 assets, | 23:24 |
+perlDreamer | 20-30 macros | 23:24 |
@scrottie | no! I'll be good! no! | 23:24 |
+perlDreamer | a dozen Workflow Activities | 23:24 |
@scrottie | not that! | 23:24 |
+perlDreamer | and every piece of custom asset code in the world | 23:24 |
* scrottie bawls | 23:24 |
@khenn | create a new method? | 23:24 |
@khenn | getWithoutDefaults() | 23:24 |
+perlDreamer | no, it's WebGUI8-isms, khenn | 23:24 |
@khenn | I'm horrible at naming stuff | 23:24 |
+perlDreamer | get() has to keep doing the same thing it used to | 23:25 |
@khenn | yeah I don't know much about WG8 | 23:25 |
@khenn | yet | 23:25 |
+perlDreamer | you will | 23:25 |
@khenn | I'm sure I'll hate it =) | 23:25 |
+perlDreamer | actually, it would be good to start now | 23:25 |
@khenn | if only I had the time ... | 23:25 |
@scrottie | I think I need to figure out how this worked in 7.... but now I know that it's possible to get get() directly to set() and have it work. | 23:25 |
@scrottie | er, get() to update(), at least. | 23:25 |
@khenn | I'm having trouble finding time to add simple features to 7.x | 23:25 |
@khenn | let alone start messing around with 8 | 23:26 |
+perlDreamer | the longer you let us run unchecked, the harder it will be to get thing turned around later | 23:26 |
@khenn | gonna just have to trust that you guys aren't screwing things up too badly =) | 23:26 |
@khenn | it's preaction I worry about | 23:26 |
@khenn | =p | 23:26 |
+perlDreamer | preaction is the guy who goes around saying, "If you do that, it'll screw khenn over. We can't do that" | 23:27 |
-!- carogray [~Caroline@174-152-122-82.pools.spcsdns.net] has quit [Read error: Connection reset by peer] | 23:27 |
-!- carogray [~Caroline@174-152-122-82.pools.spcsdns.net] has joined #webgui | 23:27 |
@preaction | he has a point | 23:28 |
@khenn | and by "khenn" he actually means "our biggest clients" | 23:28 |
@khenn | =) | 23:28 |
@khenn | not me | 23:28 |
@khenn | I'm sure he could care less about screwing me over | 23:28 |
@preaction | well, i say "clients", but I mean "pb devs" | 23:28 |
+perlDreamer | oh no, he knows if we make headaches for you, you'll just dump it onto the support boards | 23:28 |
@preaction | it's the getEditForm, www_edit, and www_add stuff that is the biggest break from prior behavior, but i did it for custom dev really | 23:29 |
@khenn | doesn't matter to me really what you do | 23:29 |
@preaction | it will in about 12 months when you start migrating | 23:29 |
@khenn | I can't wait to have the opportunity to re-write a bunch of this spaghetti I work with on a daily basis | 23:29 |
@khenn | I'm slowly doing it now | 23:29 |
@khenn | whoever subclassed WebGUI::User was a genious | 23:30 |
@khenn | I wish I'd thought of that from the beginning | 23:30 |
@khenn | genius ? | 23:30 |
@khenn | I can't spell | 23:30 |
@khenn | meh, too bad I'm dealing with File assets | 23:31 |
+perlDreamer | we don't keep you around for you spelling khenn | 23:31 |
@khenn | otherwise it looks like I could use setParent to move these things | 23:31 |
@khenn | rather than creating new assets | 23:31 |
+perlDreamer | you can use setParent to move most assets | 23:31 |
@khenn | yeah | 23:31 |
+perlDreamer | but some assets won't let you put them anywhere | 23:31 |
@khenn | but the problem is that the assets are tied to users | 23:31 |
@khenn | so when I go to delete the old user | 23:31 |
@khenn | it will delete the storage location | 23:32 |
@khenn | even if it doesn't delete the asset | 23:32 |
@khenn | gotta duplicate first | 23:32 |
@khenn | so I get a new storage location | 23:32 |
@preaction | khenn: that was probably Stephen Opal | 23:32 |
@khenn | safer that way | 23:32 |
+perlDreamer | yeah | 23:32 |
+perlDreamer | as long as the asset remembers to duplicate the storage location... | 23:32 |
@khenn | it was me too | 23:32 |
@khenn | and it does | 23:32 |
@khenn | I checked | 23:32 |
@khenn | duplicate on WebGUI::File type assets create new storage locations | 23:33 |
@khenn | you think Opal subclassed WebGUI::User? | 23:33 |
@khenn | preaction: that would have been my last guess | 23:33 |
@khenn | I thought perlDreamer did it tbh | 23:33 |
@preaction | i know he wrote the WebGUI::Friends subclass to bypass some problems in there, probably had to do the WebGUI::User one too | 23:34 |
* perlDreamer would not subclass WebGUI::User | 23:35 |
+perlDreamer | because to be really useful, you'd have to find all usages of WebGUI::User throughout the core | 23:35 |
+perlDreamer | you should make stuff like that into a user profile field | 23:35 |
+perlDreamer | :P | 23:35 |
* perlDreamer is off to pick up the kids, back in 30 | 23:36 |
@khenn | actually it's great for their custom stuff | 23:37 |
@khenn | cause you can cast regular WebGUI::User objects into the subclassed one | 23:37 |
@scrottie | push @WebGUI::User::ISA, __PACKAGE__ | 23:37 |
@khenn | and then I can do all sorts of stuff that makes sense to be in their own user | 23:37 |
@khenn | scrottie: what does that do? | 23:38 |
@preaction | makes WebGUI::User a subclass of your current package | 23:38 |
@frodwith | makes WebGUI::User a subclass of the current package. | 23:38 |
@scrottie | (note: it is in your best interest to disregard all one-liners from me; one-liners from me are, without exception, code gags) | 23:38 |
ckotil | ANyone recall what changed between 7.6.35 - 7.8.20 that effects newlines in email messages? | 23:38 |
@khenn | oh | 23:38 |
* frodwith eyes preaction. | 23:38 |
@khenn | so it's the same as use base | 23:39 |
@frodwith | no, other way 'round | 23:39 |
@preaction | no | 23:39 |
@khenn | yeah | 23:39 |
@preaction | hey, WebGUI::User, you are now a subclass of me whether you want to be or not! | 23:39 |
@khenn | I don't want WebGUI::User to be a subclass of my object | 23:39 |
@scrottie | all your us are belong to base! | 23:39 |
@khenn | heh | 23:39 |
-!- patspam1 [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 23:53 |
--- Day changed Thu Jun 03 2010 |
patspam1 | haarg++ #http://marcus.nordaaker.com/2010/06/dbix-class-about-to-switch-to-git | 00:01 |
@khenn | haarg: was svn that annoying? | 00:04 |
@khenn | I'm sure it was since I've repressed my memories of it =) | 00:05 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 00:06 |
@scrottie | svn attempted to create a less cranky version of cvs and it's my opinion that they did the opposite. | 00:07 |
@scrottie | still, "sucks less than cvs" is good marketing. or was. | 00:07 |
Haarg | svn seems like the best you could do with the cvs-style model. still horrible though. | 00:11 |
Haarg | it was actually a project jt pointed out to me, since i had done the svn to git conversion for webgui | 00:12 |
+perlDreamer | ckotil, check the bug board :) | 00:13 |
-!- carogray1 [~Caroline@174-152-122-82.pools.spcsdns.net] has joined #webgui | 00:21 |
-!- carogray [~Caroline@174-152-122-82.pools.spcsdns.net] has quit [Read error: Connection reset by peer] | 00:22 |
-!- carogray1 [~Caroline@174-152-122-82.pools.spcsdns.net] has quit [Client Quit] | 00:24 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Read error: Connection reset by peer] | 00:51 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 00:51 |
CIA-57 | webgui: Colin Kuskie master * r951864f / (3 files in 3 dirs): Add more tests for Calendar edge cases, and remove 1 day from the all day event window in getEventsIn. Fixes bug #11596. - http://bit.ly/9z2LBs | 00:54 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r4b4101e / (3 files in 3 dirs): Add more tests for Calendar edge cases, and remove 1 day from the all day event window in getEventsIn. Fixes bug #11596. - http://bit.ly/cwSulR | 00:55 |
-!- vayde [~vayde@71-34-33-161.mpls.qwest.net] has quit [Remote host closed the connection] | 01:00 |
+perlDreamer | khenn, helpdesk patch applied to pb.com, and wg.org | 01:06 |
+perlDreamer | time for testing! | 01:06 |
@khenn | sweet | 01:06 |
@khenn | I'll test later | 01:06 |
@khenn | baseball time | 01:06 |
+perlDreamer | it works | 01:15 |
+perlDreamer | have fun at Matthew's baseball | 01:15 |
+perlDreamer | patspam++ http://blogs.perl.org/users/sawyer_x/2010/06/perl-on-shared-hosting-ftw.html | 01:49 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 01:56 |
+perlDreamer | scrottie, finally getting around to WebGUI 8 comparison testing | 01:57 |
@scrottie | perlDreamer, after blowing away the MySQL database and re-init'ing, the wierdness went away | 02:06 |
+perlDreamer | that's good news | 02:07 |
+perlDreamer | I'll just run the current HEAD as a baseline against the old | 02:07 |
@scrottie | cool. | 02:07 |
@scrottie | yeah, I need to do a comprehensive test run before/after but I'm trying to figure out why some of these fields can't be copied from the old object to the new... what the rhyme and reason is. | 02:08 |
@scrottie | I mean, for some of them, the problem it causes is clear, but I want to know the general pattern. | 02:08 |
@scrottie | I imagine a full test suite run is just going to turn up more attributes that have to be handled specially. | 02:11 |
+perlDreamer | perhaps | 02:13 |
@scrottie | er, maybe not "just", but "largely". | 02:13 |
-!- patspam1 [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 02:14 |
+perlDreamer | we may need to check for those problem attributes specifically | 02:14 |
+perlDreamer | for example, session was never an attribute before now | 02:15 |
+perlDreamer | now that it is, get should not return it | 02:15 |
+perlDreamer | because it never did before | 02:15 |
+perlDreamer | similarly with keywords, but the opposite | 02:15 |
+perlDreamer | get would work with keywords, but only as a convenience | 02:15 |
@scrottie | in the latest iteration, get() returns allPropertiesMode => 1 when not given an argument. when set() sees this, it skips some fields entirely and makes sure others are initialized. | 02:16 |
@scrottie | but what you suggest is interesting too. | 02:16 |
@scrottie | I guess I should make a list of things get() returned before vs now. | 02:17 |
+perlDreamer | we should just make a test :) | 02:17 |
@scrottie | stuff something in attributes/properties to handle how they get returned might make sense too if there aren't already clues. | 02:17 |
+perlDreamer | okay, on master/HEAD, things look like they're back to normal | 02:18 |
+perlDreamer | I'll write some explicit tests for everything I can think of | 02:18 |
+perlDreamer | and they'll be in t/Asset.t | 02:18 |
+perlDreamer | since that's the baseline Asset test suite | 02:18 |
+perlDreamer | in bash, how do you do extensively nested quoting? | 02:19 |
+perlDreamer | ~colink/wgd for-each --exec='~colink/wgd db -e "select * from Workflow where workflowId=\'pbworkflow000000000007\' " ' | 02:19 |
+perlDreamer | bash doesn't like that | 02:19 |
@scrottie | I don't. perl -e. | 02:19 |
@scrottie | or perl\n and type stuff. | 02:19 |
+perlDreamer | that won't work in this case | 02:20 |
@scrottie | system, glob, ... | 02:20 |
+perlDreamer | well, maybe | 02:20 |
@scrottie | qq{}, q{} | 02:20 |
@scrottie | kinda weak answer, I know. | 02:20 |
@scrottie | do you really want to run those tests? I can get to some of that in a bit here. I just felt the need to take a break and try to figure out everything that might get initialized to something more intersting than what would get copied in. | 02:21 |
+perlDreamer | now that addRev is working, I don't see a need to run an indepth comparison | 02:22 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 02:22 |
+perlDreamer | but if I write the tests for what get should/shouldn't return, it'll help you immediately, and document it for the future | 02:22 |
+perlDreamer | that's a good win in this case | 02:22 |
@scrottie | didn't know if you were proposing testing versions that inspect attribute's metadata and various other things. | 02:23 |
@scrottie | okay, *that* makes sense. | 02:23 |
@scrottie | I just don't want to create work, that's all ;) | 02:23 |
+perlDreamer | I have a VM to use for doing dev work for the 10 minutes it takes the tests to run | 02:24 |
+perlDreamer | so not a total loss :) | 02:24 |
-!- daviddelikat1 [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 02:28 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Ping timeout: 264 seconds] | 02:31 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 02:35 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r74b500e / t/Asset.t : Tests for properties that should be returned by get, and some that should not. Done by hash inspection. - | 02:37 |
+perlDreamer | that'll give you an idea, scrottie | 02:38 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 02:46 |
@scrottie | yeah. some of these things, get() needs to return but set() needs to ignore. | 02:50 |
+perlDreamer | this may help, it may not | 02:52 |
+perlDreamer | anything that is a basic Moose attribute should never be set | 02:52 |
@scrottie | ... | 02:53 |
+perlDreamer | so, if it's declared with "has", set should ignore it | 02:53 |
+perlDreamer | but if it's declared with "property", it should use it | 02:54 |
+perlDreamer | which is just going to be odd | 02:54 |
+perlDreamer | since the mutators will work | 02:54 |
+perlDreamer | but that can be fixed | 02:54 |
+perlDreamer | we can is => 'ro' them | 02:54 |
@scrottie | a number of them are already ro. | 02:55 |
@scrottie | getWritableAttributes has to check metadata for that. and does that. | 02:55 |
@scrottie | in my branch. | 02:56 |
@scrottie | this takes me back to the start here. at one point, I asked in the channel if there was any reason why set() shouldn't accept attributes as well as properties. the consensus was that there was no reason. | 02:56 |
@scrottie | turns out, there is a reason -- stuff returned from get() (nil argument list) passed back to set() clobbers initialized data with junk. | 02:57 |
+perlDreamer | no, we can't is => 'ro' them | 02:57 |
+perlDreamer | since there's no way to update the object itself otherwise | 02:57 |
+perlDreamer | just the database | 02:57 |
@scrottie | er, in my branch, getWritableAttributes checks for ro; I haven't added ro to anything. | 02:57 |
+perlDreamer | me either, not yet | 02:57 |
@scrottie | making more things ro would fix things from my point of view but could easily break other things. | 02:58 |
@scrottie | man MacBookPros get warm in the summer in AZ. | 02:58 |
+perlDreamer | yes | 02:58 |
@scrottie | this thing is going to need its own dedicated fan. | 02:58 |
@scrottie | I don't remember... it might only have been the keywords field that benefits from set() writing attributes as well as properties. you were suggesting wrapping keyword in the Asset::Snippet subclass; I was fussing about wraping methods at multiple points on the inheritance tree. | 02:59 |
@scrottie | maybe that is the best approach. but I might do penance for that sin by merging mixin stuff into the class that has stuff that the mixin depends upon and flatten inheritance back into 2D. | 03:00 |
+perlDreamer | I was suggesting making Keyword.pm a Role that wraps get, set, and update | 03:01 |
@scrottie | oh, right. | 03:01 |
@scrottie | Object is generally the root class of objects, not a mixin that some things get and not others. you don't have objects that aren't Object. that's silly. | 03:02 |
@scrottie | what else besides Assets have get/set/update? | 03:02 |
@scrottie | oh, Assets are a role that Assets get. | 03:03 |
* scrottie sighs | 03:03 |
+perlDreamer | :) | 03:04 |
@scrottie | I feel like I'm reading C here. One thing #includes another and that #includes another. | 03:04 |
@scrottie | All the Asset*.pm classes get sucked right into Asset then all of this role stuff gets sucked in too. | 03:05 |
+perlDreamer | I've lobbied for those to be made roles as well, but it was not well received | 03:05 |
@scrottie | I'd really like to construct a inheritance hierachy out of this. | 03:05 |
+perlDreamer | It's pretty simple until you get to Asset.pm | 03:06 |
@scrottie | you're essentially monkey patching the heck out of something. you have core functionality -- such as object construction -- living off in monkey patches. | 03:06 |
+perlDreamer | do you mean the newByLineage method, or something else? | 03:06 |
@scrottie | don't remember. | 03:07 |
+perlDreamer | but yes, it's weird having AssetClipboard pushing stuff into the Asset namespace | 03:07 |
+perlDreamer | that's what a Role is supposed to do | 03:07 |
+perlDreamer | but there aren't any other objects that would benefit from it | 03:07 |
@scrottie | roles really only make sense when you already have an existing inheritance hierachy and then, tangetical to that, you want to mix and match other functionality. | 03:07 |
@scrottie | right now, there is no inheritance hierachy. | 03:08 |
@scrottie | no one has sat down and said "this is a more specific case of this, and this is a more specific case of that, and all of them share this logic so it goes up there". | 03:08 |
+perlDreamer | making generalizations like that are often counter productive | 03:08 |
+perlDreamer | because I have done that, but not on a wide scale | 03:08 |
@scrottie | hrm. | 03:09 |
+perlDreamer | for example, marking an asset to always be hidden used to be copied and pasted everywhere | 03:10 |
@scrottie | well, I'm trying to explore the idea of reworking this stuff into a hierachy or class tree to the degree possible before roles are added. | 03:10 |
+perlDreamer | I'll hold off on implementing any large scale roles then | 03:11 |
+perlDreamer | or, at the very least, I'll give you a heads up so we can talk about them | 03:11 |
@scrottie | yeah. talk would be good. | 03:11 |
@scrottie | I don't know what I'm getting into. | 03:11 |
+perlDreamer | what you want may not be feasible due to backwards compatibility | 03:12 |
@scrottie | yeah. | 03:12 |
+perlDreamer | but there's no way to know until you try | 03:12 |
+perlDreamer | to me, from Definition on down to Asset.pm, the hierarchy is pretty clear and straight forward | 03:12 |
+perlDreamer | but from Asset on down, it's circular | 03:13 |
+perlDreamer | An Asset isa WebGUI::Definition::Asset, which is a specialization of WebGUI::Definition | 03:14 |
+perlDreamer | attributes of the Asset get Definition/Role/Asset, which is a specialization of Role/Object | 03:14 |
+perlDreamer | and then there's the meta class methods | 03:14 |
@scrottie | ack 'with ' | grep -e ':with' | wc -l # 53 | 03:18 |
+perlDreamer | for starters, ack 'with' Asset* will help you ignore the FormBuilder stuff | 03:21 |
+perlDreamer | and the Definition stuff, neither of which you can really help | 03:21 |
+perlDreamer | RssFeed is the Role for adding Rss Feeds to an Asset | 03:21 |
+perlDreamer | Comments adds JSON enabled comments to an Asset | 03:21 |
+perlDreamer | AlwaysHidden is the role that guarantee that all instances of this asset are always hidden | 03:22 |
@scrottie | nice. | 03:22 |
+perlDreamer | and SetStoragePermission guarantees that file system privileges track asset privileges | 03:22 |
+perlDreamer | there are 53 because they're used in various sets by different Assets, as each is needed | 03:22 |
+perlDreamer | Wobject and Sku should both be Roles | 03:23 |
+perlDreamer | and technically, Wobject should be several roles because not all Wobjects needs everything the Wobject package provides | 03:23 |
+perlDreamer | Subscribable allows users to subscribe to an asset and to be notified via email of changes | 03:24 |
+perlDreamer | Did I miss any? | 03:24 |
@scrottie | mix and matching behavior altering code into various subclasses of a class (Assets) seems aligned with the ideas of roles. that I approve of. | 03:24 |
@scrottie | mixing and matching | 03:24 |
@scrottie | and that certainly beats cut and paste. | 03:24 |
+perlDreamer | yup | 03:24 |
+perlDreamer | aside from the monkey patching of Asset*.pm, what else do you see that bothers you? | 03:25 |
@scrottie | nothing at the moment! | 03:25 |
@scrottie | er, wait. | 03:26 |
+perlDreamer | yeah, that's enough, isn't it? :) | 03:26 |
@scrottie | I can always open another can of worms. | 03:26 |
+perlDreamer | please do | 03:26 |
@scrottie | I'd like to see data persistance done *well*. | 03:26 |
+perlDreamer | that's a WebGUI 9 project | 03:26 |
@scrottie | yeah. | 03:26 |
+perlDreamer | we'd like to see it, too | 03:26 |
+perlDreamer | but there's just no way for it to happen this quickly | 03:26 |
@scrottie | and I don't think a DSL for querying the database is the answer either. | 03:26 |
@scrottie | that's a small, incremental cleanup, at best. | 03:26 |
@scrottie | yeah. | 03:26 |
+perlDreamer | DSL? | 03:27 |
+perlDreamer | you mean WebGUI::SQL? | 03:27 |
@scrottie | DBIx::Class. | 03:27 |
@scrottie | KiokuDB has some neat ideas but it doesn't map to a normalized database schema. it's just an opaque data store. | 03:30 |
* perlDreamer has to go make dinner, but I'll backlog | 03:31 |
@scrottie | think I'm done ranting. and I'm going to head out before long here myself. thanks for the tests and for talking through this stuff with me. | 03:31 |
@scrottie | and sorry for boarding on insults there. | 03:32 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 04:08 |
@scrottie | bordering. | 04:29 |
+perlDreamer | WebGUI people are very thick skinned | 04:51 |
+perlDreamer | it comes from years of Perl people dissing us for not using Moose, DBIx::Class, and MOTD | 04:51 |
@scrottie | hah | 04:51 |
@scrottie | I'm happy to return cannon fire to whoever these people are. | 04:51 |
@scrottie | did you make YAPC last year? | 04:52 |
@scrottie | I think I already asked you that... | 04:52 |
+perlDreamer | no, I've never been to a YAPC | 04:52 |
@scrottie | I did an Acme::RightSideOutObject lightning talk. it fixes all of your inside-out object code for you and makes your inside out objects look/work right side out again. | 04:53 |
@scrottie | previous two YAPCs had talk after talk on inside out objects. then *poof*, people stopped talking about that and started talking about Moose. subtext was, if you use the module de jour, you're going to get stuck having to take all of that out if you want to follow the next trend. | 04:55 |
+perlDreamer | exactly | 04:55 |
+perlDreamer | although, I think Moose is around to stay | 04:55 |
+perlDreamer | but that's just a WAG | 04:55 |
* perlDreamer is off for further domestic tasks! | 04:55 |
@scrottie | alrigh. tomorrow... | 04:56 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 05:04 |
-!- Netsplit *.net <-> *.split quits: mducharme | 05:25 |
-!- Netsplit over, joins: mducharme | 05:28 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 05:36 |
-!- mode/#webgui [+o preaction] by ChanServ | 05:36 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r7b27498 / lib/WebGUI/AssetClipboard.pm : Change ->get to direct object accessors. - http://bit.ly/9TYbz0 | 06:00 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * re3de7cd / t/AssetHelper/Cut.t : Update object accessors, fix a problem with pasting. - http://bit.ly/cbXXV2 | 06:00 |
@frodwith | Damn you people. I'm going to have to start paying attention to this channel if you keep up this interesting conversation stuff. | 06:17 |
+perlDreamer | ha! | 06:17 |
+perlDreamer | frodwith, when do you journey south, next? | 06:18 |
@scrottie | oh, heh, I did the same thing and ran a smattering of tests. nice, perlDreamer. | 06:18 |
@frodwith | Whenever I feel the need, perlDreamer. I'm not out of nifty books to read yet, but me and the wife have been kind of cabin-fevery lately. You want to meet up soonish? | 06:19 |
+perlDreamer | the kids are out of school in two weeks, which would make getting together more difficult | 06:19 |
+perlDreamer | not impossible, but more difficult | 06:19 |
@frodwith | whenever's good for you is probably good for me. I'm pretty commitment-less outside of sunday mornings. | 06:20 |
* perlDreamer will check the schedule | 06:22 |
+perlDreamer | tomorrow | 06:22 |
+perlDreamer | time for this old man to go to sleep, so that the servers can wake me up in a few hours | 06:22 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 06:22 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rdcb9bac / t/Definition/Asset.t : One plan per test, please! - http://bit.ly/94r9Dg | 06:24 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r2976539 / t/Macro/UsersOnline.t : Content check via truthiness. - http://bit.ly/cl3gPj | 06:27 |
@scrottie | alright, tomorrow I'm going to see about subclass get/set/update in ::Snippet to accept keyword. that should be quick, fun, sane and easy. | 06:29 |
@scrottie | after beating a long path around the outside =P | 06:29 |
@scrottie | thanks for your help and g'nite. | 06:29 |
@scrottie | I'll also try to propose solutions and roll up patches rather than blathering on so much... once I'm a little more sure of what I'm doing ;) | 06:30 |
-!- daviddelikat1 [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 06:48 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 07:36 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 07:39 |
-!- mode/#webgui [+o preaction] by ChanServ | 07:39 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 07:44 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 08:00 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:15 |
-!- kaare is now known as Guest6050 | 08:15 |
-!- frodwith [~pdriver@helios.tapodi.net] has quit [Ping timeout: 258 seconds] | 09:05 |
-!- frodwith [~pdriver@helios.tapodi.net] has joined #webgui | 09:07 |
-!- mode/#webgui [+o frodwith] by ChanServ | 09:07 |
-!- frodwith [~pdriver@helios.tapodi.net] has quit [Ping timeout: 252 seconds] | 09:47 |
-!- frodwith [~pdriver@helios.tapodi.net] has joined #webgui | 09:50 |
-!- mode/#webgui [+o frodwith] by ChanServ | 09:50 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:37 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:37 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has quit [Read error: Connection reset by peer] | 12:38 |
-!- carogray [~Caroline@108.117.236.72] has joined #webgui | 12:59 |
carogray | hello. Good morning, good day! | 13:48 |
carogray | Just wondering...is there a way to get the title of an asset to appear in 'tool tip' in the navigation asset? | 13:49 |
carogray | so the links in ...huh, maybe I wll just try it. | 13:49 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 14:08 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Read error: Connection reset by peer] | 14:09 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 14:15 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:15 |
-!- carogray [~Caroline@108.117.236.72] has quit [Read error: Connection reset by peer] | 15:20 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 15:21 |
-!- mode/#webgui [+o tavisto] by ChanServ | 15:21 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 15:25 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has joined #webgui | 15:39 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 15:41 |
-!- steveo_aa [~sno@adsl-76-232-154-192.dsl.sfldmi.sbcglobal.net] has joined #webgui | 15:43 |
-!- mode/#webgui [+v steveo_aa] by ChanServ | 15:43 |
-!- steveo_aa [~sno@adsl-76-232-154-192.dsl.sfldmi.sbcglobal.net] has left #webgui [] | 15:43 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 15:45 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 15:47 |
+bartjol | carogray: did you succeed? | 15:51 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 16:06 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has joined #webgui | 16:07 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 16:23 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 16:40 |
-!- mode/#webgui [+o bopbop] by ChanServ | 16:41 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 17:37 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 17:37 |
* perlDreamer has to drop the kids off at school, back in 20 | 17:44 |
@tavisto | at the pool | 17:45 |
+bartjol | the pool? | 18:03 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 18:09 |
-!- mode/#webgui [+v patspam] by ChanServ | 18:09 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:36 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has quit [Quit: napping] | 18:43 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 18:48 |
+perlDreamer | Does everybody get to go to the pool except for me? | 18:52 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 19:05 |
-!- mode/#webgui [+o bopbop] by ChanServ | 19:05 |
-!- ekennedy [~ekennedy@173-141-249-176.pools.spcsdns.net] has joined #webgui | 19:24 |
@khenn | is there a general template variable for isAdmin ? | 19:52 |
+perlDreamer | check the session template variables | 19:53 |
+perlDreamer | khenn:session.var.adminOn | 19:55 |
+perlDreamer | oh, wait | 19:55 |
+perlDreamer | isAdmin? | 19:55 |
+perlDreamer | no | 19:55 |
@khenn | ok just admin on | 19:55 |
+perlDreamer | yeah | 19:55 |
-!- ekennedy [~ekennedy@173-141-249-176.pools.spcsdns.net] has left #webgui [] | 20:10 |
-!- steveo_aa [~sno@adsl-76-232-154-192.dsl.sfldmi.sbcglobal.net] has joined #webgui | 20:11 |
-!- mode/#webgui [+v steveo_aa] by ChanServ | 20:11 |
-!- steveo_aa [~sno@adsl-76-232-154-192.dsl.sfldmi.sbcglobal.net] has left #webgui [] | 20:11 |
-!- eleger81 [~44b82b04@gateway/web/freenode/x-yypmgfjvftcmodxv] has joined #webgui | 20:51 |
CIA-57 | webgui: Colin Kuskie master * r5a904a8 / (4 files in 4 dirs): Do not delete cron tasks with errors, just notify spectre of the problem. Fixes bug #11604. - http://bit.ly/9jwuTr | 20:57 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r723e376 / (4 files in 4 dirs): Do not delete cron tasks with errors, just notify spectre of the problem. Fixes bug #11604. - http://bit.ly/cIud3l | 20:58 |
-!- eleger81 [~44b82b04@gateway/web/freenode/x-yypmgfjvftcmodxv] has left #webgui [] | 21:01 |
@scrottie | good morning. | 21:03 |
+perlDreamer | yo, scrottie | 21:05 |
+perlDreamer | all: http://www.webgui.org/download/advisories/loss-of-scheduler-tasks | 21:13 |
+perlDreamer | all: http://www.webgui.org/download/advisories/loss-of-scheduler-tasks | 21:13 |
+perlDreamer | whoops | 21:14 |
-!- knowmad [~william@97.66.185.250] has joined #webgui | 21:14 |
+perlDreamer | hey, knowmad | 21:14 |
knowmad | hey pd | 21:14 |
knowmad | it's been a looong time; too long | 21:14 |
+perlDreamer | hopefully you've been very busy :) | 21:14 |
knowmad | but we've been busy creating award-winning WebGUI sites! | 21:15 |
knowmad | our Mallard Creek design won 2 Hermes Creative awards | 21:15 |
+perlDreamer | awesome! Congratulations. | 21:15 |
knowmad | http://www.webgui.org/sightings/business/gallery/mallard-creek-polymers | 21:15 |
knowmad | we've also been contracted by a local university to implement a new site in wG | 21:16 |
+perlDreamer | you should tell Tavis so he can put a note in that about the award | 21:16 |
knowmad | and i'm talking to them about doing workflows which would be cool | 21:16 |
+perlDreamer | knowmad, are you subscribed to the advisories? | 21:17 |
knowmad | good idea | 21:17 |
-!- carogray1 [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 21:17 |
-!- Netsplit *.net <-> *.split quits: carogray | 21:17 |
knowmad | i think so, why? | 21:17 |
+perlDreamer | http://www.webgui.org/download/advisories/loss-of-scheduler-tasks | 21:17 |
ckotil | ah, the patch their? the email didnt have a link to it | 21:17 |
ckotil | err. there. | 21:17 |
+perlDreamer | it was an attachment to the original post on the CS | 21:18 |
knowmad | ouch! will that impact upgrades from 7.7 or just those who upgraded to the versions that were affected? | 21:18 |
+perlDreamer | it's in 7.8.18 and 7.9.3 and higher | 21:19 |
knowmad | but if i wait until the fix is released before upgrading past those versions, i'll be OK? | 21:19 |
knowmad | we're a bit behind on our upgrades... | 21:19 |
+perlDreamer | yes, you'll be fine if you wait until 7.9.7, or 7.8.21 | 21:20 |
knowmad | cool | 21:20 |
knowmad | hey, besides needing to check-in and say hello, i also have a question | 21:20 |
+perlDreamer | ask away :) | 21:20 |
knowmad | at one time I thought that the data form was storing edits to entries; eg., i add an entry then view it and edit it and it stores a new copy | 21:21 |
knowmad | i just tried this out on the demo site and it appears to not be available anymore | 21:21 |
knowmad | or at least not via the GUI | 21:21 |
knowmad | i haven't gone digging into the db yet | 21:21 |
+perlDreamer | I haven't looked at the DataForm in a while, but as far as I know that should still work | 21:21 |
knowmad | ok, i'll double-check the code; thanks | 21:22 |
knowmad | nope, doesn't appear to store changes any longer -- http://demo.webgui.org/demo1275588337_449/home/form | 21:28 |
ckotil | does the restore cron script overwrite existing default crons? | 21:28 |
+perlDreamer | no | 21:30 |
+perlDreamer | if the cron is missing, it adds it | 21:30 |
+perlDreamer | otherwise, it leaves it alone | 21:30 |
ckotil | cool | 21:30 |
ckotil | thanks | 21:30 |
* perlDreamer takes a brief lunch break | 22:04 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:31 |
-!- SDuensin [~Scott@mobile-166-137-142-237.mycingular.net] has quit [Ping timeout: 240 seconds] | 22:36 |
-!- SDuensin [~Scott@mobile-166-137-140-080.mycingular.net] has joined #webgui | 22:46 |
-!- SDuensin [~Scott@mobile-166-137-140-080.mycingular.net] has quit [Ping timeout: 258 seconds] | 22:56 |
-!- khenn [~frank@71.150.248.232] has quit [Quit: khenn] | 23:02 |
-!- khenn [~frank@71.150.248.232] has joined #webgui | 23:10 |
-!- mode/#webgui [+o khenn] by ChanServ | 23:10 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has quit [Quit: napping] | 23:33 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 23:40 |
-!- mode/#webgui [+o bopbop] by ChanServ | 23:40 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 23:51 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 23:54 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has quit [Quit: bye] | 23:59 |
--- Day changed Fri Jun 04 2010 |
Haarg | knowmad, as far as i know, edits were never saved in dataform entries. i believe the sql form did though. | 00:11 |
knowmad | Hey Haarg. Thanks for the feedback. I must be thinking of that... | 00:12 |
-!- carogray1 [~Caroline@host2.209.113.248.conversent.net] has quit [Read error: Connection reset by peer] | 00:13 |
-!- scrottie [~scrottie0@dsl01-ppp-5119.fastq.com] has quit [Quit: switchin'... and not to Mac] | 00:33 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 00:33 |
-!- mode/#webgui [+o scrottie] by ChanServ | 00:33 |
@scrottie | mmmm'kay. | 00:33 |
knowmad | do i have to upgrade from 7.7.22 to 7.7.33 in order to go to 7.8.20? | 00:38 |
Haarg | yes | 00:39 |
knowmad | this is not clearly indicated from any of the docs I'm reading | 00:39 |
knowmad | is this an assumed upgrade path to go to last stable branch of current major.minor release? | 00:39 |
@preaction | yes | 00:40 |
Haarg | that's a good assumption that has been stuck to since 7.4 at least. | 00:40 |
Haarg | it should also be explicitly mentioned in the gotchas file | 00:41 |
knowmad | Haarg: the only mention in gotchas is upgrading to 7.7.20 | 00:41 |
Haarg | hmm | 00:42 |
knowmad | yeah, you can see why I tried to go straight from 7.7.22 to 7.8.20 (yeah, i should know better but it's been awhile since i've done my upgrades) | 00:46 |
+perlDreamer | knowmad, wait a week before upgrading to 7.8.21 | 00:51 |
+perlDreamer | until next Tuesday, when the fix for the cron bug comes out | 00:51 |
+perlDreamer | otherwise, you're just making more work for yourself | 00:51 |
+perlDreamer | with patching and all | 00:51 |
knowmad | yeah, thanks for reminder; i will do that for production; i'm just testing the pathway | 00:51 |
Haarg | 7.8.21 gotcha also needs fixing | 00:52 |
+perlDreamer | thanks, Haarg! | 00:52 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 00:52 |
-!- mode/#webgui [+v patspam] by ChanServ | 00:52 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r638ab2a / docs/gotcha.txt : Fix the gotcha for .21, and document the stop version for 7.7.33 to 7.8.13 - http://bit.ly/cF4vU0 | 00:54 |
+perlDreamer | knowmad, also see this wiki page: http://www.webgui.org/wiki/stop-versions | 00:54 |
knowmad | ahh, so that is documented! | 00:54 |
Haarg | i definitely want to get something for stop versions in WebGUI::Upgrade, but there are a number of things to take care of before that | 00:55 |
knowmad | i'm working on going through the 7.x changelogs to document the major changes between releases | 00:55 |
knowmad | is there anything in the wiki along those lines that i've overlooked? no need to duplicate others work | 00:55 |
knowmad | Haarg: ++ | 00:55 |
Haarg | i should be done with the current thing i've been working on and can get back to WebGUI stuff | 00:55 |
+perlDreamer | knowmad, I don't know of any page like that | 00:56 |
+perlDreamer | but if you start it, I'll contribute to it | 00:56 |
knowmad | ok, i'm up to v7.2 at this point | 00:56 |
+perlDreamer | 7.2? | 00:56 |
+perlDreamer | 7.2.0? | 00:57 |
knowmad | it's actually pretty interesting; there's been a LOT of work | 00:57 |
knowmad | since 7.0 | 00:57 |
+perlDreamer | yes, yes there has | 00:57 |
knowmad | i'll post a wiki entry when i'm finished | 00:57 |
-!- carogray [~Caroline@173-125-0-199.pools.spcsdns.net] has joined #webgui | 01:16 |
@preaction | does anyone remember a RawHeadTags macro? | 01:23 |
+perlDreamer | macro? | 01:26 |
+perlDreamer | no | 01:26 |
@preaction | lost to time, good. | 01:26 |
+perlDreamer | found it | 01:30 |
+perlDreamer | back in 6.8 | 01:30 |
+perlDreamer | RawHeadTags was a way to push arbitrary data into the head tags | 01:33 |
+perlDreamer | I'm guessing that in the 6.9 series, when the session changes happened, that it went away, since Templates were given head tag blocks | 01:34 |
+perlDreamer | Haarg++ for importing all the SVN and CVS history into git | 01:34 |
Haarg | i just finished another svn to git conversion actually | 01:35 |
Haarg | for DBIx::Class | 01:35 |
+perlDreamer | I heard :) | 01:35 |
+perlDreamer | patspam spread the news | 01:35 |
+patspam | yeah you were getting some good kudos for it in the Perl blogosphere | 01:36 |
+perlDreamer | Haarg isn't the only one getting kudos, patspam ;) | 01:40 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r9a1c5c9 / t/Shop/PayDriver.t : Cart cleanup from leaky PayDriver test. - http://bit.ly/anmb7C | 01:41 |
+perlDreamer | Haarg, any reason that cleanup guard in WebGUI::Test shouldn't use newPending instead of new? | 01:52 |
Haarg | not that i can think of | 01:52 |
-!- knowmad [~william@97.66.185.250] has left #webgui [] | 01:54 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r4fb7933 / lib/WebGUI/Shop/CartItem.pm : Exception handling for getSku. - http://bit.ly/9mYYL5 | 02:11 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r0d2ac6a / t/lib/WebGUI/Test.pm : Get pending assets for cleanup. - http://bit.ly/bWeCCK | 02:13 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r3ccf71a / (t/Shop/PayDriver/Ogone.t t/Shop/ShipDriver/FlatRate.t): Better test cleanups. Hopefully, this fixes the RemoveOldCarts activity. - http://bit.ly/aopsy8 | 02:13 |
+perlDreamer | preaction, i think the session scratch variables are leaking randomly | 02:13 |
+perlDreamer | so it's wrong to assume that the session work done this week caused it | 02:13 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 02:32 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Remote host closed the connection] | 02:37 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 02:39 |
-!- carogray [~Caroline@173-125-0-199.pools.spcsdns.net] has quit [Quit: Leaving.] | 02:39 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 02:40 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r95b6b66 / lib/WebGUI/Asset/File/Image.pm : fix a problem with the generated HTML id. - http://bit.ly/bYiCA8 | 02:58 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r15faef5 / t/Asset/File/Image.t : Fix caching a subroutine ref. Small test cleanups. - http://bit.ly/aX4jtz | 02:58 |
-!- daviddelikat1 [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 03:05 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Ping timeout: 276 seconds] | 03:09 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r2ad02b3 / t/lib/WebGUI/Test.pm : Codify in 1 place how to skip autocommit workflows, and notification. - http://bit.ly/byRn1W | 03:11 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rcd97f2e / t/Asset/Wobject/StoryArchive.t : Remove use_ok, SKIP, plan, END block. - http://bit.ly/9oSWcU | 03:11 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 03:46 |
* perlDreamer starts some dinner for the family, back in a while | 03:47 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 03:49 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 03:51 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 04:10 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 258 seconds] | 04:11 |
@khenn | It feels so good to get a long standing project wrapped up | 04:30 |
@khenn | that smothering feeling is finally gone | 04:30 |
+perlDreamer | which project is that, khenn? | 04:39 |
@khenn | merging duplicate users for SA | 04:39 |
@khenn | been on the docket for 4 months now | 04:40 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 04:47 |
-!- mode/#webgui [+o preaction] by ChanServ | 04:47 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 265 seconds] | 04:49 |
@khenn | perlDreamer are you here? | 04:50 |
+perlDreamer | yes sir | 04:50 |
+perlDreamer | neck deep in Survey guts | 04:50 |
@khenn | I don't see any code in VersionTag.t that tests whether stuff is actually committed | 04:50 |
+perlDreamer | that's possible | 04:50 |
+perlDreamer | Committing code isn't done by VersionTag.t | 04:50 |
@khenn | VersionTag->commit ... | 04:51 |
+perlDreamer | that commits a tag | 04:51 |
+perlDreamer | and then the tag calls each asset and commits it | 04:51 |
+perlDreamer | so if you trust Asset->commit | 04:51 |
@khenn | I see | 04:51 |
+perlDreamer | then all you need to do is check that it was called | 04:51 |
+perlDreamer | it wouldn't hurt to have code in there to do that | 04:51 |
+perlDreamer | if you were so inclined | 04:51 |
@khenn | I'm not even sure where I'd start with that one | 04:52 |
@khenn | I'll just test that stuff after the fact looks right | 04:52 |
+perlDreamer | you'd check asset state before and after commit | 04:52 |
+perlDreamer | in the db | 04:52 |
+perlDreamer | since the asset itself is ignorant of the change | 04:52 |
@khenn | right | 04:54 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 04:56 |
@khenn | perlDreamer, who is the default user in the Test session? | 05:00 |
+perlDreamer | visitor | 05:02 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 05:05 |
+perlDreamer | scrottie, I fixed a bunch of leaking tests, and we now have a few more passing tests | 05:05 |
scrottie | cool. | 05:05 |
scrottie | I'm moving code around. I'd like to get some comments on this, in a few here, if you're up for it. | 05:06 |
+perlDreamer | sure | 05:06 |
* perlDreamer needs to learn some perl debugger basics | 05:10 |
scrottie | generally, I figure out what line I want to start at, and do perl -d whatever.pl, then c <linenumber of where I want to start> | 05:11 |
scrottie | <return> re-does the last command of 's' or 'n' and most of the time you can hit one or the other of those two and then just hit return again and again for a while | 05:11 |
scrottie | 's' steps into functions calls and 'n' runs any function calls but doesn't return you to the prompt or print the line it's about to execute until it returns | 05:12 |
scrottie | so 'n' lets you skip over stuff you're confident of and 's' chews through everything | 05:12 |
+perlDreamer | s must really mean "single step" | 05:12 |
scrottie | skip over = skip over viewing the full execution trace... the code still runs | 05:12 |
scrottie | yeah | 05:12 |
scrottie | and then at key points, do: x 2 $datastructure | 05:13 |
scrottie | that dumps $datastructure with a depth of 2. anything much higher on OO code is pointlessly spammy. and you can always do x 2 $datastructure->{thingie} or x 2 $datastructure->method or whatever. | 05:13 |
scrottie | and beyond that it, it runs perl at the prompt, kinda REPL style. | 05:13 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 05:13 |
-!- mode/#webgui [+v patspam] by ChanServ | 05:14 |
+perlDreamer | that sounds better than diag "this", warn "that" and my $break = <>; | 05:14 |
scrottie | yes and no. I'll thrown warns and dies in for in case I'm 'n'exting over too much stuff and I want to be alerted anyway. | 05:15 |
scrottie | it's mix and match. if you know what's calling what pretty well and what code is running, warn/die is often plenty adequate. | 05:16 |
scrottie | the debugger also does breakpoints, stack traces, watching variables and other fun stuff but usually I don't any of that... ahem, other than stack traces. | 05:18 |
+perlDreamer | is there a command which says, finish the script with no more debugging? | 05:19 |
scrottie | 'c'ontinue | 05:20 |
scrottie | without args. | 05:20 |
scrottie | the optional arg is the breakpoint which can be a line number or perl expression to evaluate. | 05:20 |
-!- fokat [~lem@200.84.244.194] has joined #webgui | 05:20 |
+perlDreamer | this is very, very bad | 05:21 |
scrottie | ? | 05:21 |
+perlDreamer | It's the Survey | 05:22 |
+perlDreamer | __ patspam __, might want to listen in | 05:22 |
+perlDreamer | in the Survey test, it creates a survey | 05:22 |
+perlDreamer | but it doesn't commit it | 05:22 |
+perlDreamer | later on, a new revision is added to the survey, and it does get committed | 05:22 |
+perlDreamer | but, if you run it in WebGUI8, that doesn't happen | 05:22 |
+perlDreamer | which means that something screwy is different about the version control code in both versions | 05:23 |
+patspam | I planted that bug just to highlight a flaw in wg8 | 05:23 |
+perlDreamer | I THOUGHT SO! | 05:23 |
+patspam | heh no actually kaleb did, I just juiced it up | 05:24 |
+perlDreamer | and you made it an awesome bug | 05:24 |
+patspam | ugh you you I really hate Survey so much | 05:24 |
+patspam | want to rewrite the whole thing from scratch | 05:24 |
+patspam | again | 05:24 |
+perlDreamer | that would be a valid WebGUI8 project | 05:24 |
+patspam | yeah, maybe if sdh lands a couple of big projects we'll be able to afford to do it | 05:25 |
+patspam | it's core to what we do and actually does a lot of cool stuff, but it really sucks in a lot of ways too | 05:25 |
+perlDreamer | it could use a little more polish | 05:28 |
+perlDreamer | it's functional now | 05:28 |
+perlDreamer | but it could be truly awesome | 05:28 |
+perlDreamer | I got the dual sliders working, though | 05:28 |
+perlDreamer | so it's not all bad | 05:28 |
+patspam | perlDreamer++ # thanks for that :) | 05:32 |
scrottie | sounds like a WhiteCastle reference. | 05:36 |
+perlDreamer | scrottie: did you ever do a coverage run on wg8? | 05:38 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rb5d1757 / t/Asset/Wobject/Survey.t : change some ->gets to direct accessors. - http://bit.ly/97MxY8 | 05:38 |
scrottie | noep! | 05:39 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 05:43 |
scrottie | I've been at least partially debriefed on three other projects here, all WebGUI 7 (of course). | 05:43 |
scrottie | I'm not sure how or if WebGUI 8 is going to figure in. | 05:44 |
CIA-57 | webgui: khenn master * r053292a / (3 files in 3 dirs): Added new API method commitAsUser allowing developers to commit version tags as other users - http://bit.ly/cVs3MR | 05:45 |
@khenn | perlDreamer - I just pushed my new version tag method that allows you to commit as someone outside the current session | 05:46 |
@khenn | with tests | 05:46 |
@khenn | not sure if you are able to use that or not | 05:46 |
@khenn | but it's there | 05:46 |
@khenn | alright, off to bed | 05:46 |
scrottie | sleep well, khenn | 05:46 |
* perlDreamer will check it out soon | 05:46 |
+perlDreamer | scrottie, there's no "step out", is there? | 05:49 |
scrottie | honestly, I'm not sure. I don't know how things work. | 05:49 |
scrottie | obviously, too many projects at the same time is bad... nothing gets done after a certain point than just having meetings to talk about all of the things that haven't been done. | 05:50 |
scrottie | I think 0.4 projects per programmer is ideal =) | 05:51 |
scrottie | ie, having slightly more than two people involved in each thing but no more. but of course, nothing is ideal in the real world. | 05:52 |
scrottie | http://github.com/scrottie/webgui/tree/coregetsetupdate | 05:52 |
scrottie | ... waiting for firefox to load its tabs | 05:52 |
+perlDreamer | heading into "put kids to bed time" | 05:53 |
* perlDreamer will be in and out, with more out than in for the next 40 minutes | 05:53 |
scrottie | ugh. browser.tabs.closeButtons is busted in recent versions of Firefox. each tab will have a close button whether you like it or not. | 05:54 |
scrottie | http://github.com/scrottie/webgui/commit/bf88cb409e534a62e71d2bdd17c5a88326e3e8d2 | 05:55 |
+perlDreamer | scrottie, why would you do that in Snippet? | 05:56 |
+perlDreamer | vs some other class? | 05:56 |
scrottie | http://github.com/scrottie/webgui/commit/58d68a6f9e70386cbdb15a53e463a5684f938f53 | 05:57 |
* scrottie checks his notes to find out why | 05:57 |
scrottie | "<perlDreamer> unless we make Kewyords a Role, that overrides get and update" | 05:57 |
scrottie | "<perlDreamer> overrides/wraps" | 05:57 |
scrottie | (typing, not pasting... typos mine) | 05:57 |
scrottie | hrm. so Keywords modifies Assets, not extends it. | 05:58 |
scrottie | I got that wrong too. | 05:58 |
+perlDreamer | right, WebGUI::Keywords -> WebGUI::Role::Asset::Keywords | 05:58 |
scrottie | well, all I can say is this makes all three of those failing t/Keywords.t tests pass. | 05:58 |
scrottie | ahem. well, the plot thickens. stay with me here. | 05:58 |
* perlDreamer promises to back log if away | 05:59 |
scrottie | http://github.com/scrottie/webgui/commit/f6b7561b149081e2c073d0b17337cf20f00bdd73 ... er, I guess you already saw the meat of it. | 05:59 |
scrottie | that's cool, re: afking. | 05:59 |
scrottie | if there's only one version of get/set/update, and they always honor 'keywords', KISS/"Do the simplest possible"/"Don't write it, you aren't going to need it" say to make that one version do what's needed. | 06:00 |
scrottie | so, in that case, my inclination would be to put it directly into the get/set methods that, in this branch, live in Asset.pm. | 06:00 |
scrottie | thoughts? | 06:01 |
+perlDreamer | It's hard to type when your fingers are in someone else's mouth | 06:07 |
scrottie | hahaha | 06:09 |
scrottie | take your time =) family is important. | 06:09 |
+perlDreamer | first thought: ping Haarg: backlog, comment | 06:09 |
scrottie | worse case, there's usually (but not always) tomorrow | 06:09 |
+perlDreamer | second thought, we want get, set, and update to be generic methods available to all objects | 06:09 |
+perlDreamer | so I'm 99% sure they need to stay in the Definition/Role/Object | 06:10 |
+perlDreamer | why would you want to move them out? | 06:10 |
-!- khenn [~frank@71.150.248.232] has quit [Ping timeout: 258 seconds] | 06:10 |
+perlDreamer | ditto with getProperties, and getFormProperties | 06:10 |
scrottie | because nothing else is actually using them. they're an important part of that object's API, and they're hidden away through a chain of useses/injections/etc three times removed. | 06:11 |
+perlDreamer | not using them __yet__ | 06:11 |
scrottie | well, I'm telling you why I wanted to do that, not why I was right to want to do that. | 06:11 |
+perlDreamer | ah, sorry for the pre-emptive argumentation then :) | 06:11 |
scrottie | np. | 06:11 |
scrottie | I was concerned about the unnecessary complexity (and future programmers pulling hair) of then turning around and wrapping ('around') something that already comes from "far away" | 06:12 |
scrottie | but if it isn't unnecessary complexity, that's different. | 06:12 |
+perlDreamer | eventually, we want to have every class using this | 06:13 |
+perlDreamer | if I get some spare time, I may convert User.pm over to it, for fun | 06:14 |
scrottie | heh | 06:14 |
scrottie | "every class" means little to me. Assets are my entire universe right now =) | 06:14 |
* scrottie thinks, or attempts a reasonable impression of doing so | 06:15 |
+perlDreamer | WebGUI/*.pm | 06:15 |
+perlDreamer | Except maybe CRUD | 06:15 |
scrottie | yeah. | 06:15 |
+perlDreamer | not sure what to do with CRUD, but most of what it does could be done by Definition | 06:15 |
+perlDreamer | in any case, back to the Keywords stuff | 06:17 |
+perlDreamer | I think the arounds need to be moved somewhere | 06:18 |
scrottie | I'd rather not see Asset/Keywords.pm just doing an 'around' on code in Asset. this *might* be the best way but if it is, I'd have to convince myself of that. | 06:18 |
+perlDreamer | maybe right into Asset.pm itself | 06:18 |
scrottie | yeah. then I'm a little fuzzy on Moose. my Moose is not top notch. | 06:18 |
+perlDreamer | although, if it was in its own Role, you could build an Asset without keywords | 06:18 |
+perlDreamer | it would break lots of things | 06:19 |
+perlDreamer | but maybe you just want a very small WebGUI | 06:19 |
scrottie | KISS. | 06:19 |
+perlDreamer | no wiki, no Story manager | 06:19 |
+perlDreamer | hard to tell | 06:19 |
scrottie | "Don't build it; you won't need it" | 06:19 |
+perlDreamer | that would be up to the implementors | 06:19 |
scrottie | (you might, but if you try to plan for various scenarios, you'll *usually* miss the scenario you need to plan for and plan for a lot you don't, so it's best to just keep things simple and be in a good position to adapt later) | 06:19 |
+perlDreamer | have a look at WebGUI/Role/Asset/RssFeed.pm for an example of how to build an Asset Role | 06:20 |
scrottie | okay. I'm not against the idea of mixing and matching code into assets... but if there's currently only one user of a role without immediate, real promise of others, it doesn't deserve to be a role. that's needless complexity. the next new guy will spend a week chasing his tail. that's time better spent other ways. | 06:21 |
scrottie | fwiw, I've worked on some real train wreck of codebases. they always come about completely innocently. I'm more than a little scarred by that. | 06:24 |
+perlDreamer | well, we can always keep it in out back pocket | 06:24 |
scrottie | sure. | 06:25 |
scrottie | apologies for the unrequested philosophy. | 06:25 |
+perlDreamer | preaction gets to make final calls on all code architecture decisions, so we should develop something | 06:25 |
+perlDreamer | not a problem | 06:25 |
scrottie | yeah. | 06:25 |
+perlDreamer | we're pretty outspoken and thick skinned | 06:25 |
+perlDreamer | except for my tests | 06:25 |
+perlDreamer | which are perfect | 06:25 |
+perlDreamer | you can quote me on that | 06:25 |
scrottie | okay, thoughts on this... around on set and get in Asset to handle keywords? | 06:25 |
scrottie | haha | 06:25 |
scrottie | better than perfect... legendary. | 06:26 |
+perlDreamer | I think it should be prototyped, and we show that it works, and then run it past preaction for final confirmation | 06:26 |
scrottie | can do. | 06:26 |
scrottie | if I'm not sure of something, I'll just push it to branch in my github clone and ask for input. | 06:27 |
+perlDreamer | frodwith, I want to find some way for your presentation to go before mine | 06:27 |
scrottie | or rather, just keep doing that. | 06:27 |
+perlDreamer | scrottie, sounds good | 06:27 |
Haarg | scrottie, i certainly understand why you want to keep things simple | 06:27 |
Haarg | but 'definition' as it is used in webgui 7 is already a nasty mess | 06:27 |
scrottie | Haarg, removing "unnecessary complexity" and showing it to people is fantastic way to solicit an explanation of why it isn't "unnecessary", in the cases where it isn't. | 06:28 |
scrottie | Haarg, I've learned about all sorts of back compat problems and design objectives I otherwise wouldn't have =) | 06:29 |
scrottie | I've made those t/Keywords.t tests pass with five different designs now, by my count. | 06:30 |
* perlDreamer makes a note to add more Keywords tests >:) | 06:31 |
scrottie | haha | 06:32 |
scrottie | that's a really good idea. | 06:32 |
Haarg | what are the actual parts of the keywords stuff that had been failing? | 06:32 |
+perlDreamer | $asset->addChild({....., keywords => 'keywords'}) | 06:32 |
scrottie | # Failed test 'getMatchingAssets, by keyword, assetIds in order by creationDate, descending' | 06:32 |
scrottie | # Failed test '... retrieving assets in more than one state' | 06:33 |
scrottie | # Failed test 'check getTopKeywords returns correctly' | 06:33 |
+perlDreamer | I'm pretty sure those are indirect symptos | 06:33 |
+perlDreamer | symptoms | 06:33 |
+perlDreamer | we should have tests that expose them directly | 06:33 |
scrottie | perlDreamer, here's one hackish thing I did: http://search.cpan.org/~swalters/Test-Float-0.3/float.pl | 06:33 |
scrottie | if you give me tests and say "make these pass", I might, just maybe, run that on them >=) | 06:34 |
scrottie | (in other words, you might get technically successful but even more hare brained fixes than what I've offered so far) | 06:36 |
* perlDreamer will do my best to provide boundaries | 06:37 |
scrottie | ((more directly, better tests will foster better solutions)) | 06:37 |
+perlDreamer | "No, scrottie, you can't code that in LISP, even if it is 5 bytes smaller" | 06:37 |
scrottie | heh | 06:37 |
+perlDreamer | "Yes, scrottie, a 64-node parallel server would run the tests faster" | 06:38 |
scrottie | yeah, I really should have installed WebGUI on the cluster. | 06:39 |
+perlDreamer | the tests don't parallelize very well | 06:39 |
scrottie | hrm. | 06:39 |
+perlDreamer | since they inject objects into the database which interfere with other tests | 06:39 |
scrottie | I don't suppose MySQL supports nested transactions. | 06:39 |
Haarg | nope | 06:40 |
Haarg | so what are the actual solutions you found to fix the keywords issue? | 06:41 |
+perlDreamer | http://github.com/scrottie/webgui/commit/bf88cb409e534a62e71d2bdd17c5a88326e3e8d2 | 06:41 |
+perlDreamer | wrapping get, and set | 06:41 |
Haarg | wouldn't adjusting set and get to just work off attributes instead of properties accomplish the same thing? | 06:42 |
scrottie | Haarg, an exception in set() for setting 'keywords', ... | 06:42 |
scrottie | Haarg, that was about #3 there. that caused all sorts of chaos. | 06:42 |
scrottie | get() returns everything... set() so far silently ignored attributes. making it honor setting them, all sorts of data got clobbered and other tests all over the place blew up. | 06:43 |
scrottie | that required heuristics to detect default data; try #4 was having get() return a flag indicating that the %attribute data came from there so blacklist a series of attributes. | 06:43 |
scrottie | I spent a day hunting down the various attributes that were blowing things up and then another trying to find the rhyme or reason to it. | 06:44 |
scrottie | that might have had some potential but I think it just boils down to it being too different from WebGUI7. | 06:44 |
Haarg | i have a feeling you may not like it, but my first thought is to add an attribute trait to mark if something is 'writable' or not | 06:45 |
scrottie | not feelings on it, but some things need to be written sometimes and need to not be written other times, for tests to pass. title comes to mind. | 06:45 |
scrottie | the default title is bad; explicitly specified titles are good. | 06:46 |
+perlDreamer | huh? | 06:46 |
scrottie | the *best* was when lineage got set from default data. it was ''. when it came time to junk the asset in question, lineage '' was junked -- EVERYTHING. everything wound up trash-limbo. | 06:46 |
scrottie | it was awesome. | 06:46 |
Haarg | in this case, all i mean by writable is 'have set pass it off to the mutator' | 06:46 |
scrottie | perlDreamer: copying the default title from get() back to set() is bad... a better title gets initialized/specified. it's complicated. | 06:47 |
scrottie | Haarg, that's exactly what was happening. | 06:47 |
Haarg | yes, but you don't want set to pass lineage off to the mutator | 06:48 |
scrottie | and some things are ro. I made a method for looking at metadata to pick out the attributes that were actually writable. | 06:48 |
scrottie | Haarg: that's the catch. a lot of things that set() needs to honor, get() returns and has to return; and passing of everything from get() straight to set() is a requirement. | 06:48 |
Haarg | what i was thinking was, have get return all attributes | 06:49 |
Haarg | and have set only set the ones that have been specified as writable | 06:49 |
scrottie | Haarg: check out http://github.com/scrottie/webgui/tree/keywords | 06:49 |
scrottie | Haarg: way ahead of ya. | 06:50 |
scrottie | the cleanest was passing a flag to indicate that the data came from get() and that set() should take special precautions. | 06:50 |
scrottie | in-band metadata. | 06:51 |
scrottie | honestly, I don't remember why that got abandoned now. something came up that no good solution could be found for. | 06:51 |
scrottie | Haarg: that sort of generalization felt good. | 06:52 |
Haarg | i guess i'm not quite seeing why you need a flag passed around when it should be information based only on the attribute itself. | 06:52 |
scrottie | because the user won't pass in destructive data such as comes from get(). | 06:53 |
scrottie | lineage => '' was just one case. | 06:53 |
scrottie | there were a bunch of them. | 06:54 |
Haarg | that's the part i'm not understanding | 06:54 |
scrottie | the data in the newly initialized attribute was just plain better than a lot of what gets copied in. but of what gets copied in from get(), a lot of those same things are settable by the user -- and when set by the user, they aren't evil. they're good. | 06:54 |
scrottie | yeah, and I'm a bit fuzzy on that now. that was a day or two ago. | 06:54 |
Haarg | there are cases like lineage, but those should just not be 'settable' | 06:55 |
scrottie | well, 'title' had the same problem, if memory serves. | 06:55 |
scrottie | a bunch of failing tests => a bunch of kludgey fixes. | 06:55 |
Haarg | something like title though | 06:56 |
Haarg | weee | 06:56 |
Haarg | well | 06:56 |
Haarg | i don't know. perhaps i just need to try it out | 06:56 |
Haarg | can you point me to some of the failing tests you saw after changing things? | 06:56 |
Haarg | i know the keywords test is what we need to fix | 06:57 |
scrottie | that was bjorking stuff in Asset.t I think... hang on | 06:58 |
scrottie | with more than a few tabs open, Firefox gets powerful slow | 06:58 |
Haarg | oh how i hate you UNIVERSAL::(can|isa) | 06:59 |
scrottie | http://github.com/scrottie/webgui/blob/keywords/t/Asset.t ... look for the comments with XXX in them | 07:00 |
scrottie | I think I'd have to read backscroll in IRC for a long way to figure out why that was abandoned. | 07:02 |
-!- scrottie0 [~scrottie0@dsl01-ppp-5119.fastq.com] has joined #webgui | 07:03 |
-!- scrottie0 [~scrottie0@dsl01-ppp-5119.fastq.com] has quit [Client Quit] | 07:03 |
scrottie | hrm, wonder where my history is. | 07:03 |
scrottie | somewhere on the Mac. | 07:04 |
scrottie | nowhere on the Mac. | 07:06 |
-!- scrottie0 [~scrottie0@dsl01-ppp-5119.fastq.com] has joined #webgui | 07:08 |
-!- scrottie0 [~scrottie0@dsl01-ppp-5119.fastq.com] has quit [Client Quit] | 07:08 |
scrottie | I think what happened is in conversation, I was told that that would break a lot of legacy apps. | 07:09 |
scrottie | show preaction the code and ask him about it. it might have been him who warned about the implications for all of the hosted WebGUI sites. | 07:26 |
+perlDreamer | it was me | 07:26 |
-!- khenn [~frank@adsl-71-150-248-232.dsl.mdsnwi.sbcglobal.net] has joined #webgui | 07:27 |
-!- mode/#webgui [+o khenn] by ChanServ | 07:27 |
Haarg | yeah. i'm well aware of the backwards compatibility issues. we're already stretching that a bit far. | 07:27 |
+perlDreamer | here are what I see the boundary conditions to be | 07:28 |
+perlDreamer | you have to be able to do $asset->get(), and get the keywords, but not the session | 07:29 |
+perlDreamer | you have to be able to do $asset->keywords(), and get them | 07:29 |
+perlDreamer | $asset->keywords('new keywords'), and set them | 07:29 |
+perlDreamer | $asset->update({keywords => 'new words'}) and set them AND write them to the db | 07:29 |
+perlDreamer | you have to be able to $asset->addChild, ->addRevision({keywords => 'some words',}) and have them assigned to the object, and stuck in the db | 07:30 |
+perlDreamer | that's how it works in 7 | 07:30 |
+perlDreamer | and that's what I (or someone) needs to write tests for | 07:32 |
+perlDreamer | but more likely tomorrow | 07:32 |
+perlDreamer | it's going on 12 hours, and I'm tired | 07:32 |
+perlDreamer | 'night, all | 07:32 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 07:33 |
scrottie | I think *those* tests exist | 07:33 |
scrottie | one of them, he already wrote and pusehd. | 07:33 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 07:34 |
scrottie | around get and around set don't actually wrap get/set in WebGUI/Asset.pm. grr. | 07:34 |
scrottie | I guess they run before the roles get applied...? | 07:35 |
Haarg | that doesn't seem right | 07:35 |
-!- fokat [~lem@200.84.244.194] has quit [Ping timeout: 240 seconds] | 07:42 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 07:49 |
-!- mode/#webgui [+o preaction] by ChanServ | 07:49 |
scrottie | argh. just for giggles, I threw the 'around' stuff for get/set into a role and pulled that into WebGUI::Asset after the use WebGUI::Definition::Asset; line. | 07:50 |
scrottie | still no. | 07:50 |
scrottie | they have warnings at the top of the methods. if they run, I'd see it, even if they don't fix the tests and function correctly. | 07:50 |
scrottie | must be doing something wrong | 07:51 |
CIA-57 | webgui: Scott Walters WebGUI8 * r7933e12 / lib/WebGUI/Definition/Role/Object.pm : get() shouldn't return session; fixes the Asset.t "get, specific properties - no session" test - http://bit.ly/b6F9sK | 08:16 |
scrottie | low hanging fruit. for a change. | 08:16 |
Haarg | scrottie, something like this is what i had in mind: http://gist.github.com/425004 | 08:41 |
Haarg | the name of that trait is shitty and there are other problems, but it shows the basic idea | 08:42 |
scrottie | I thought about doing something like that but lacked the Moose-fu. | 08:43 |
scrottie | grab me and perlDreamer tomorrow and run it by him. | 08:44 |
scrottie | I'm kinda wishing right now that all of these attributes/properties were just first class, non "meta" object, AWT-style. | 08:45 |
scrottie | or else that keywords just graduated to being a property. | 08:46 |
scrottie | but you're right... the line between properties and attributes doesn't exactly follow what's settable and what isn't, so that abstraction breaks down. | 08:46 |
scrottie | btw, http://github.com/scrottie/webgui/commit/4b117ec0192adc6fd50b8e40e994304d65924a19 | 08:49 |
scrottie | ... I think I have to punt on this one and move on to other stuff. | 08:51 |
scrottie | with 'WebGUI::Role::Asset::Keywords'; in Asset.pm didn't make it into that commit. oops. | 08:51 |
Haarg | where in Asset.pm? | 08:52 |
scrottie | after the use WebGUI::Definition::Asset; line | 08:53 |
Haarg | what branch are you basing that off? i'm not noticing anything incorrect about that right now, but i just tried roughly the same thing and it seems to work fine for me. | 08:55 |
Haarg | http://gist.github.com/425025 | 08:57 |
Haarg | and the warning shows up | 08:58 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:13 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:13 |
scrottie | strange. | 10:24 |
scrottie | wow, I'm still awake. why is that? | 10:24 |
scrottie | based off of b5d17576b0f041f8a204257762a5f6a6a56e941c | 10:24 |
+bartjol | scrottie: I don't know, because it's 9:30 in the morning? | 10:34 |
scrottie | hrm. because I was wrong about codepaths. thought the constructor would initialize the attribute. based on other things that worked, I thought that was happening. I'll have to look at this fresh. | 10:39 |
+bartjol | :) | 10:42 |
+bartjol | more coffee | 10:42 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 13:20 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 13:20 |
-!- mode/#webgui [+v Radix_] by ChanServ | 13:20 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 13:22 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 13:43 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 13:50 |
-!- mode/#webgui [+v Radix_] by ChanServ | 13:50 |
CIA-57 | webgui: martin master * r73c762d / (3 files in 3 dirs): Fixed bug where Template form plugin would not show anything for getValueAsHtml. - http://bit.ly/dz9WiK | 14:29 |
CIA-57 | webgui: Martin Kamerbeek webgui-7.8 * r8df4cdb / (3 files in 3 dirs): | 14:38 |
CIA-57 | webgui: Fixed bug where Template form plugin would not show anything for getValueAsHtml. | 14:38 |
CIA-57 | webgui: Conflicts: | 14:38 |
CIA-57 | webgui: docs/changelog/7.x.x.txt - http://bit.ly/byDKXt | 14:38 |
CIA-57 | webgui: Martin Kamerbeek webgui-7.8 * r61031af / docs/changelog/7.x.x.txt : Accidentally merged additional line from master changelog. - http://bit.ly/9G4HUp | 14:42 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 14:50 |
-!- Guest6050 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 15:09 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:31 |
-!- daviddelikat1 [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 15:42 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 16:14 |
-!- mode/#webgui [+o bopbop] by ChanServ | 16:14 |
-!- SDuensin [~Scott@mobile-166-137-143-214.mycingular.net] has joined #webgui | 16:14 |
SDuensin | Captain Obvious says, "IT'S FRIDAY!" | 16:16 |
+bartjol | CEO: captain extremely obvious, that's management for you | 16:53 |
@khenn | The help desk pagination issues are now fixed | 17:10 |
@khenn | (and the crowd goes wild!) | 17:10 |
@khenn | =) | 17:10 |
+bartjol | well done frank | 17:16 |
* bartjol gives Frank a tap on his shoulder | 17:17 |
-!- fokat [~lem@200.84.244.194] has joined #webgui | 17:21 |
@frodwith | perlDreamer: what's your presentation? | 17:28 |
-!- eleger81 [~44b82b04@gateway/web/freenode/x-flmqxppygtoxxsuc] has joined #webgui | 17:33 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 17:37 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 17:38 |
-!- eleger81 [~44b82b04@gateway/web/freenode/x-flmqxppygtoxxsuc] has left #webgui [] | 17:47 |
@frodwith | perlDreamer: what's your presentation on? | 17:51 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 17:52 |
+perlDreamer | I'll be talking about WebGUI8, and assets | 17:52 |
+perlDreamer | having the Moose talk first would help | 17:52 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 17:54 |
@bopbop | frodwith: you can ask jamie to flip yours and perldreamer's presentations around | 17:56 |
-!- qwebirc46744 [~520aba07@gateway/web/freenode/x-xggwkgceuanocnbs] has joined #webgui | 17:58 |
qwebirc46744 | a quick question to those that are around, does webgui provide ldap intergration? | 17:58 |
@khenn | yes | 17:58 |
@khenn | it works both over regular ports and SSL | 17:59 |
qwebirc46744 | is there a module/plugin/addon for document management for webgui? | 18:00 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:04 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:04 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has quit [Ping timeout: 265 seconds] | 18:05 |
-!- qwebirc46744 [~520aba07@gateway/web/freenode/x-xggwkgceuanocnbs] has quit [Quit: Page closed] | 18:08 |
@khenn | not sure what you mean qwebirc46744 | 18:08 |
@khenn | are you asking for documentation on how to configure WebGUI for LDAP? | 18:09 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 18:10 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 18:10 |
-!- mode/#webgui [+v Radix_] by ChanServ | 18:10 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 18:14 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 18:14 |
-!- mode/#webgui [+v Radix_] by ChanServ | 18:14 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Remote host closed the connection] | 18:23 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 18:30 |
-!- mode/#webgui [+v Radix_] by ChanServ | 18:30 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 18:33 |
-!- mode/#webgui [+v patspam] by ChanServ | 18:33 |
+patspam | mornin' folks! | 19:00 |
+perlDreamer | morning, patspam! | 19:00 |
+perlDreamer | did you get some good coffee this morning? | 19:00 |
+patspam | not in this town ;( | 19:01 |
+patspam | I'm on the wrong coast I think | 19:01 |
+perlDreamer | for coffee, yes | 19:01 |
+perlDreamer | I'll bring you a bag for the WUC | 19:01 |
+patspam | wooh! | 19:01 |
+patspam | I've considered starting a cafe more than once since arriving here | 19:01 |
+patspam | how long do you reckon it'd take to add Drafts to wG's inbox? | 19:02 |
+patspam | just had a client feature request for it | 19:02 |
+perlDreamer | hm | 19:03 |
+perlDreamer | It'd be a bit | 19:03 |
+perlDreamer | The inbox messages would need a new state | 19:03 |
+perlDreamer | Draft | 19:03 |
+perlDreamer | the current inbox would have to filter on that | 19:03 |
+perlDreamer | there would have to be a UI for it | 19:04 |
+perlDreamer | to display the list of drafts | 19:04 |
+perlDreamer | then to allow them to be edited | 19:04 |
+perlDreamer | all the UI has to be templated | 19:04 |
+patspam | this is why webgui needs a freelance marketplace | 19:05 |
+patspam | should be able to flag an RFE as "open for tender" | 19:06 |
+perlDreamer | 1-2 weeks on the outside, patspam | 19:07 |
+perlDreamer | patspam, you should also talk with khenn, because he submitted an RFE for adding Sent Mail to the Inbox | 19:08 |
+perlDreamer | maybe the two could dovetail? | 19:08 |
+patspam | yeah I reckon | 19:08 |
+patspam | we half added Sent Mail already though | 19:08 |
+patspam | it's just very simplistic | 19:08 |
@khenn | inbox is currently broken | 19:08 |
@khenn | so I wouldn't do anything there just yet | 19:08 |
@khenn | not till it's fixed | 19:09 |
+patspam | hey khenn | 19:09 |
+patspam | what's broken? | 19:09 |
@khenn | two problems | 19:09 |
@khenn | it's not showing users all of their inbox messages | 19:09 |
@khenn | it's using the wrong query to display them | 19:09 |
@khenn | I already posted a solution for that one | 19:10 |
@khenn | haven't had a chance to fix and test though | 19:10 |
@khenn | the other issue is that there are processes in webgui that are deleting inbox messages without using the API | 19:10 |
@khenn | and so they are creating orphaned data | 19:10 |
@khenn | in the inbox_messageState table | 19:10 |
@khenn | also an easy fix but it needs to come with an upgrade to clean that stuff up | 19:11 |
+patspam | what sorts of messages are not displaying? | 19:11 |
@khenn | group ones | 19:11 |
@khenn | so you are in group a | 19:11 |
@khenn | group a is sent an email | 19:11 |
@khenn | you see the email in your inbox | 19:12 |
@khenn | but you don't read it | 19:12 |
@khenn | then you are removed from group a | 19:12 |
@khenn | that message is still tied to your account | 19:12 |
@khenn | but it won't show in your inbox anymore | 19:12 |
+patspam | ha | 19:12 |
@khenn | and | 19:12 |
@khenn | it still reports it as an unread message | 19:12 |
+patspam | oh brilliant | 19:12 |
@khenn | so you wind up with people having unread messages they can no longer do anything about | 19:12 |
+patspam | at least it makes the bug obvious | 19:13 |
@khenn | yeah | 19:13 |
@khenn | it's my fault | 19:13 |
@khenn | too | 19:13 |
@khenn | =( | 19:13 |
+perlDreamer | Your fault, you fix it! | 19:13 |
+patspam | heh don't feel bad, after those performance tweaks you've got lots of excess karma | 19:13 |
+perlDreamer | Shame, shame on you and your whole family | 19:13 |
+patspam | perlDreamer and I are doing good cop, bad cop | 19:14 |
@khenn | what performance tweaks? | 19:14 |
@khenn | you mean the group stuff? | 19:14 |
+patspam | yeah | 19:14 |
@khenn | ah yeah | 19:14 |
@khenn | not sure if you've upgraded yet | 19:15 |
@khenn | but it's a lot faster | 19:15 |
+patspam | nah I haven't upgraded most of my sites yet | 19:15 |
+patspam | were you talking about Nav performance tweaks too? | 19:15 |
+patspam | that would be much bigger for me | 19:15 |
+patspam | last time I checked 50% of the response time on the front page of the default site is spent doing Nav | 19:16 |
@khenn | yes | 19:17 |
@khenn | JT didn't like my idea | 19:17 |
@khenn | not sure if that swayed preaction or not | 19:17 |
+perlDreamer | you'll come up with another one | 19:17 |
@khenn | I don't think I have to | 19:17 |
@khenn | I think my idea is valid and not a hack | 19:17 |
@khenn | as long as preaction is still ok with it | 19:18 |
@khenn | I'll just add API methods for doing what needs to be done | 19:18 |
@khenn | that way it's not hacked in | 19:18 |
@preaction | so some way to short-circuit canView | 19:19 |
@preaction | test it first, it might not be that much faster | 19:20 |
@khenn | well I was thinking that canView could be called as a class Method | 19:20 |
@khenn | as well as a session method | 19:20 |
@preaction | how? it needs all the data from the database | 19:20 |
@khenn | if it gets called from the class it would just look the stuff up it needs directly from the db | 19:20 |
@khenn | without instantiating the asset | 19:20 |
+perlDreamer | breaking object encapsulation for the sake of speed isn't the best of ideas | 19:21 |
@khenn | though now that I think about it | 19:21 |
@khenn | that won't work | 19:21 |
@preaction | it's that very DB query, looking up the stuff, that is the problem. the idea you had was joining assetData, and using groupIdView if you absolutely knew that was the only permissions check | 19:21 |
@khenn | right | 19:21 |
@khenn | that's still the idea | 19:21 |
@khenn | just trying to figure out how to make it work without "hacking" it | 19:22 |
@preaction | there are other db queries we can remove during a page request, the template attachments have three queries when it could be one for example | 19:22 |
@khenn | I was also mulling around the idea of a quick asset instance method | 19:22 |
@khenn | but I'm not sure that will work either | 19:22 |
@khenn | actually, you know what might work | 19:23 |
@khenn | newByHashRef | 19:23 |
@khenn | no never mind | 19:23 |
@khenn | that won't work either | 19:23 |
@khenn | meh | 19:23 |
@khenn | too much going on to think about it | 19:23 |
+perlDreamer | patspam, got some Survey questions for you | 19:23 |
@khenn | I need to duck out for a bit | 19:23 |
+patspam | shoot | 19:23 |
+perlDreamer | If a Survey is not committed, can you still take the survey? | 19:24 |
+patspam | no idea | 19:24 |
+patspam | I don't think the code ever considers whether or not the instance is committed | 19:25 |
+patspam | it just inherits whatever wobjects do in that situation | 19:25 |
+perlDreamer | this is the problem I'm seeing in the Survey.t test | 19:26 |
+perlDreamer | The main survey used in the test is never committed | 19:27 |
+perlDreamer | but when it adds a response, it commits the first version, and leaves the new version uncommitted | 19:27 |
+perlDreamer | This is causing bad problems in WebGUI8 | 19:27 |
+patspam | ah right | 19:27 |
+patspam | so | 19:27 |
+patspam | that's related to Survey trying to be smart about edits to its structure | 19:27 |
+perlDreamer | yes | 19:28 |
+patspam | the structure is versioned | 19:28 |
+patspam | so if someone has already started a response, changes you make to the structure don't affect them | 19:28 |
+perlDreamer | and that requires the responses to be correspondingly versioned | 19:28 |
+patspam | new changes to structure don't get committed as a new version until someone starts a new response | 19:29 |
+patspam | so in that test, starting the response causes a version commit | 19:29 |
+perlDreamer | submitObjectEdit causes the commit. I'm not sure if that is called upstream by the new response or not | 19:31 |
+patspam | perlDreamer: was "1-2 weeks on the outside" serious or a joke? | 19:37 |
+perlDreamer | I think it'll take 3-4 days if everything goes smoothly | 19:38 |
+patspam | yeah that's more like it :) | 19:38 |
+perlDreamer | so, 1-2 weeks was a loose estimate | 19:38 |
scrottie | Haarg, did you run t/Keywords.t on your example? on my machine... and I upgraded to the latest Moose... the warns in the wrapping methods don't go off. | 20:10 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 20:10 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r4eca8bb / t/Asset/Wobject/Survey.t : Commit the initial Survey for the test. - http://bit.ly/caFX43 | 20:38 |
-!- SDuensin [~Scott@mobile-166-137-143-214.mycingular.net] has quit [Read error: Connection reset by peer] | 20:38 |
Haarg | scrottie, yes i did | 20:39 |
scrottie | hmm. out of curiousity, did those three failing tests pass? | 20:40 |
scrottie | er, wait | 20:40 |
scrottie | sorry, different code | 20:40 |
Haarg | i had my other patch in there so everything worked | 20:40 |
scrottie | perlDreamer, do you want to see if you can get that patch to work and if so commit it? | 20:41 |
+perlDreamer | which patch, scrottie? | 20:41 |
scrottie | or adapt it however you see fit and commit it? it follows your original suggestion. | 20:41 |
+perlDreamer | wrapping get and set in Asset.pm | 20:42 |
Haarg | http://gist.github.com/425004 this is roughly the idea i had keywords stuff | 20:42 |
scrottie | that one, or else pulling in a role that's only ever used there =P | 20:42 |
scrottie | oh yeah. and Haarg was still exploring settable attributes. I told him to talk to you. | 20:42 |
scrottie | I'm trying to wash my hands of this. I've spent too much time on these three failed tests in t/Keywords.t. | 20:43 |
scrottie | http://github.com/scrottie/webgui/commit/4b117ec0192adc6fd50b8e40e994304d65924a19 ... that for one isn't working. | 20:44 |
+perlDreamer | scrottie, it's not just those 3 tests | 20:45 |
+perlDreamer | it's also t/Story.t, t/Asset/Wobject/Story*.t | 20:46 |
+perlDreamer | t/WikiPage.t | 20:46 |
+perlDreamer | and several others | 20:46 |
scrottie | I know there are more failing tests; I'm not trying to fix all of them with one patch. | 20:46 |
scrottie | I am running prove > prove$n.txt and komparing output to make sure that I don't break stuff. | 20:46 |
scrottie | after that first fumble. | 20:46 |
scrottie | I have another branch sitting here that I don't think I've pushed that does the same thing but with a 'with' and that moved into a role. Actually I think I emailed you a link to that and did push it. | 20:47 |
scrottie | and asked for comments on what I was doing wrong with Moose. | 20:47 |
+perlDreamer | Haarg, I think that works for everything, except the direct accessor | 20:48 |
+perlDreamer | $asset->keywords('new, keyword, list'); | 20:48 |
scrottie | I am trying to solve the problem in the general case to some degree ;) and so is Haarg. I'm trying to move on to other things here but if you're occupied right now we can hash through options later. | 20:48 |
Haarg | what kind of behavior do we want that to have perlDreamer? | 20:49 |
+perlDreamer | it should work just like $asset->set('keywords', 'new, keyword, list'); | 20:49 |
Haarg | it does | 20:49 |
+perlDreamer | how does it work in the direct case? | 20:51 |
Haarg | it's just an accessor | 20:52 |
scrottie | Asset's keyword attribute has an 'around' on it already. | 20:52 |
scrottie | that calls off to SetKeywordsForAsset or whatever that is. | 20:52 |
Haarg | ->keywords and ->set('keywords') just set the value in memory | 20:53 |
Haarg | ->write sets it in the database | 20:53 |
Haarg | (in my code) | 20:53 |
+perlDreamer | I see, I missed the line for the write method | 20:54 |
Haarg | it fixes t/Keyword.t and t/Asset.t stays the same. kind of simplifies things as well. 'Settable' as a marker attribute trait isn't perfect but it does seem like something we need so i don't know if there is a better name or implementation of a flag like that. | 20:56 |
-!- daviddelikat1 [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 20:59 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Ping timeout: 240 seconds] | 21:03 |
+perlDreamer | Haarg, that seems to work fine | 21:07 |
+perlDreamer | I added explicit tests for that in Asset.t | 21:07 |
+perlDreamer | and they're all passing | 21:07 |
+perlDreamer | I'll try the whole suite next | 21:07 |
+perlDreamer | is there someplace I can pull | 21:07 |
Haarg | it's not pushed anywhere | 21:07 |
Haarg | the other thing i don't like is the ->keywords('list, of, keywords') vs ->keywords(['list', 'of', 'keywords']) thing. a type coercion may be a good way to deal with that though. | 21:09 |
+perlDreamer | yeah | 21:13 |
+perlDreamer | setKeywordsForAsset will take either | 21:14 |
+perlDreamer | but whatever is left in the asset object is another story | 21:14 |
+perlDreamer | but, in 7 | 21:14 |
+perlDreamer | it works with strings | 21:15 |
+perlDreamer | so we should probably coerce from array to string | 21:15 |
Haarg | yeah | 21:15 |
+perlDreamer | what were we thinking back then? | 21:17 |
Haarg | ask jt | 21:19 |
+perlDreamer | maybe we can fix it in WebGUI 8.1 ... ;) | 21:19 |
+perlDreamer | The keywords, not JT | 21:19 |
@preaction | oh i'll fix him, i'll fix him with both hands | 21:19 |
* preaction can get him metal legs | 21:20 |
+perlDreamer | are those like concrete shoes? | 21:20 |
+perlDreamer | while adding lots of tests is great for coverage | 21:22 |
+perlDreamer | it's bad for time | 21:22 |
+perlDreamer | Haarg, it's a winner! | 21:32 |
+perlDreamer | Could you push and merge, or do you want me to commit this? | 21:32 |
Haarg | you can go ahead | 21:32 |
scrottie | Haarg++ | 21:32 |
+perlDreamer | so done | 21:33 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r8c759ed / (5 files in 4 dirs): Implement keywords differently (successfully) in the Asset class. Extra tests to verify it in Asset.t - http://bit.ly/bC1Mzo | 21:34 |
@frodwith | perlDreamer: http://www.plainblack.com/wuc/schedule | 21:50 |
@frodwith | got vrby to switch 'em | 21:50 |
+perlDreamer | you are a man of considerable influence | 21:50 |
* perlDreamer takes a lunch break | 21:51 |
-!- SDuensin [~Scott@53.sub-97-38-157.myvzw.com] has joined #webgui | 22:12 |
@preaction | trying to run the 8 test suite: Can't locate WebGUI/Definition/Meta/Settable.pm | 22:26 |
@preaction | http://sshmenu.sourceforge.net/articles/bcvi/ <- we should install this on our servers. | 22:31 |
@preaction | perlDreamer: looks like you missed adding WebGUI::Definition::Meta::Settable | 22:34 |
-!- SDuensin [~Scott@53.sub-97-38-157.myvzw.com] has quit [Quit: Leaving] | 22:40 |
scrottie | there's sshfs for FUSE... | 22:47 |
scrottie | then you can run vi locally on remote files. | 22:47 |
-!- bopbop [~kristi@76-255-21-207.lightspeed.mdsnwi.sbcglobal.net] has quit [Quit: bye] | 22:47 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:49 |
@preaction | yeah. that would work, but it would require setup each time i wanted to do something. bcvi requires one-time setup and then Just Works | 23:00 |
+perlDreamer | sorry, preaction | 23:19 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r193223c / lib/WebGUI/Definition/Meta/Settable.pm : Adding Settable flag for non-properties that should be handled by set/write. - http://bit.ly/a4sxYN | 23:20 |
+perlDreamer | down to 24 failing WebGUI8 tests | 23:28 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rdd716fa / (lib/WebGUI/Asset.pm t/Asset.t): Fix the default URL for an Asset. It should be based on the parent, if available, and the menutitle. - http://bit.ly/chWp03 | 23:28 |
+perlDreamer | 23 | 23:32 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r13e59e7 / t/Asset/Wobject/EventManagementSystem.t : EMS does not return session as a template variable any longer. - http://bit.ly/d8vTh8 | 23:32 |
@preaction | failing test scripts? | 23:32 |
+perlDreamer | yes | 23:32 |
@preaction | or tests period? | 23:32 |
+perlDreamer | scripts | 23:32 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r0a9785e / t/Asset/Wobject/StoryArchive.t : Fix a simple typo in the script. - http://bit.ly/920itN | 23:34 |
+perlDreamer | scrottie, could you look at t/Asset/JSONCollateral next? | 23:35 |
+perlDreamer | it will need a complete rewrite, both the test, and the module | 23:35 |
scrottie | what am I looking for? | 23:35 |
+perlDreamer | JSONCollateral should be reconsidered in light of the JSONArray WebGUI::Type module | 23:35 |
scrottie | I think Frank is having me fix some alumini site bugs and then do some development, and then I'm supposed to be working on the helpdesk rewrite too, but otherwise, sure. | 23:36 |
scrottie | (but in reality I'm on lunch trying to make bloody Firefox work... I blew away .firefox and started over since it was getting impossibily, unusably slow, and now it won't install plugins) | 23:36 |
scrottie | and today is going to be short... I'm supposed to hike tomorrow, which I should have said no to, so I have to pack and get over to the other side of town and be to bed in time to getup at 5am. | 23:37 |
scrottie | so, yeah, sure, as long as you aren't in a huge hurry. | 23:38 |
scrottie | maybe in five or ten years I'll figure out how to operate a bloody webbrowser. | 23:38 |
+perlDreamer | you need one of them pointy rat thinies | 23:38 |
+perlDreamer | thingies | 23:38 |
@preaction | a rat flail? | 23:44 |
+perlDreamer | is that like a cat o' nine tails? | 23:45 |
@preaction | http://www.myfconline.com/boards/uploads/14340.jpg <- no. it's a flail made of rats | 23:45 |
+perlDreamer | khenn, you've exceeded your quote for bug postings this week | 23:45 |
+perlDreamer | please retract a couple of them | 23:45 |
@khenn | well I'm fixing one of them | 23:45 |
@khenn | I've assigned that one to myself | 23:45 |
+perlDreamer | that's okay then | 23:45 |
@khenn | =) | 23:45 |
+perlDreamer | would you like some more to be assigned, too? | 23:46 |
+perlDreamer | we can do that | 23:46 |
@preaction | http://www.vgcats.com/comics/?strip_id=110 | 23:46 |
* perlDreamer is out to pick up the kids. | 23:48 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r910a0a0 / (t/AssetAspect/RssFeed.t t/lib/WebGUI/Asset/RssAspectDummy.pm): Upgrade this test for Definition. Something bad is still happening in export. - http://bit.ly/cq6DWR | 23:49 |
--- Day changed Sat Jun 05 2010 |
-!- daviddelikat1 [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Quit: Leaving.] | 00:25 |
CIA-57 | webgui: khenn master * rd082e4e / lib/WebGUI/Asset/Wobject/Thingy.pm : Fixed #11613 - After successful save of a Thing, the form is cleared for the next thing to be entered - http://bit.ly/b0uoaz | 01:04 |
CIA-57 | webgui: khenn master * r18af5d1 / docs/changelog/7.x.x.txt : Fixed #11613: Thingy: If next action after add is to add more things, previous data remains - http://bit.ly/aOcCwC | 01:04 |
CIA-57 | webgui: khenn master * r5a329f8 / (3 files in 3 dirs): Merge branch 'master' of git@github.com:plainblack/webgui - http://bit.ly/csbXGX | 01:04 |
+perlDreamer | khenn, should that fix be backported to the 7.8 branch? | 01:05 |
-!- khenn [~frank@adsl-71-150-248-232.dsl.mdsnwi.sbcglobal.net] has left #webgui [] | 01:08 |
-!- khenn [~frank@71.150.248.232] has joined #webgui | 01:11 |
-!- mode/#webgui [+o khenn] by ChanServ | 01:11 |
@khenn | I think Colloquy just crashed my server | 01:11 |
@khenn | er | 01:11 |
@khenn | my computer | 01:11 |
@khenn | perlDreamer: I don't think it needs to be backported | 01:12 |
@khenn | it's not a fatal bug | 01:12 |
+perlDreamer | we backport all bugs back to 7.8 | 01:12 |
* perlDreamer was trying to prod you politely | 01:13 |
+perlDreamer | but since that didn't work... | 01:13 |
@khenn | oh | 01:14 |
@khenn | guess I'm not set up to do that | 01:14 |
@khenn | is there a way to merge changes? | 01:14 |
+perlDreamer | yes | 01:15 |
+perlDreamer | make a checkout of the 7.8 branch | 01:15 |
+perlDreamer | git checkout --track --branch webgui-7.8 webgui-7.8 | 01:15 |
+perlDreamer | that will not only make the branch, but make you use it | 01:15 |
+perlDreamer | then you use the cherry-pick command to bring in the commits from another branch | 01:16 |
+perlDreamer | git cherry-pick d082e4e | 01:16 |
+perlDreamer | and for the other two branches | 01:16 |
+perlDreamer | you may have a merge conflict with the changelog | 01:16 |
+perlDreamer | if so, just resolve it like you would with SVN | 01:17 |
+perlDreamer | and then... | 01:17 |
+perlDreamer | git add file_with_merge_problems | 01:17 |
@khenn | yeah I deal with cherry-picks | 01:17 |
@khenn | yep | 01:17 |
@khenn | would you mind merging this one for me? | 01:17 |
@khenn | I'm having issues with my computer | 01:17 |
@khenn | I'll check out 7.8 after I do a reboot | 01:18 |
@khenn | need to patch a server first though | 01:18 |
-!- khenn [~frank@71.150.248.232] has left #webgui [] | 01:18 |
CIA-57 | webgui: khenn webgui-7.8 * re1be898 / lib/WebGUI/Asset/Wobject/Thingy.pm : Fixed #11613 - After successful save of a Thing, the form is cleared for the next thing to be entered - http://bit.ly/a7V9Gv | 01:21 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rf81eeeb / docs/changelog/7.x.x.txt : Fixed #11613: Thingy: If next action after add is to add more things, previous data remains - http://bit.ly/bqsEJY | 01:21 |
CIA-57 | webgui: khenn master * re74753c / lib/WebGUI/Asset/Wobject/Thingy.pm : Not enough arguments to searchOther - http://bit.ly/9DXE57 | 01:29 |
+perlDreamer | preaction, in the new style chooser, can we make Style3 on by default, and put a save button at the top as well as the bottom? | 01:32 |
@preaction | sure, but then put Style_03 on the top as well | 01:32 |
scrottie | docs say to connect to the newly running WebGUI instance (using 7 here...) and it'll "walk me through the rest of the configuration". that doesn't seem to be happening. the "Getting Started" and "Your Next Step" do nothing and I don't know what the initial password is. | 02:07 |
scrottie | http://www.webgui.org/wiki/wre-installation says to go to /setup but that gives "The URL setup was requested, but does not exist in your asset tree." | 02:09 |
scrottie | need the thing running to test alumini fixes. | 02:10 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 02:12 |
scrottie | wow, did people actually get off the computer and show their faces to their loved ones? GOOD. thank heavens. | 02:12 |
scrottie | you people scare me. | 02:13 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 02:14 |
+perlDreamer | scrottie: if you build a site with wgd reset -d, it skips the site starter | 02:27 |
+perlDreamer | time for me to show my face to the fam | 02:29 |
+perlDreamer | I'll be back on later, or tomorrow. | 02:29 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 02:29 |
scrottie | It's Friday! Go drink! See a movie! | 02:56 |
scrottie | Joust tallbikes. Go skydiving. Something. | 02:56 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 02:58 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 03:00 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 03:09 |
Haarg | scrottie, re: site startup | 03:28 |
Haarg | the thing in the wre docs is for the WRE setup, allowing you to add new sites etc | 03:29 |
Haarg | there is also the WebGUI site starter which is shown for new WebGUI sites | 03:29 |
Haarg | wgd reset -d will disable the site starter, as usually when developing you don't need it | 03:29 |
Haarg | in that case it leaves the username/password the same as the default, which is 123qwe | 03:29 |
Haarg | wgd reset will also accept the --starter and --no-starter switches to control that | 03:30 |
Haarg | the wre console password is the mysql root user password, so if you need that it's a separate issue | 03:31 |
Haarg | wgd reset also has an option to attempt to use your local cookies to automatically log you on to the site so you don't need to do that step either | 03:32 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 03:54 |
scrottie | Haarg: nice, nice, nice. thank you. | 03:55 |
scrottie | PerlDreamer, you better be jet skiing! | 03:55 |
scrottie | I'm out... cheers. | 03:55 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 03:57 |
-!- mode/#webgui [+v patspam] by ChanServ | 03:57 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 252 seconds] | 04:00 |
CIA-57 | webgui: Patrick Donelan psgi * rd75fa54 / t/lib/WebGUI/Test.pm : Preliminary PseudoRequest workarounds (+79 more commits...) - http://bit.ly/9EL2po | 05:33 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 05:33 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 05:40 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 06:19 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 06:24 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 07:13 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 07:36 |
-!- fokat [~lem@200.84.244.194] has quit [Ping timeout: 240 seconds] | 08:52 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 11:08 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:08 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:08 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:12 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:12 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:12 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:16 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:16 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:16 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:20 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:21 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:21 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:24 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:25 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:25 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 11:30 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:31 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:31 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:34 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:35 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:35 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:39 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:40 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:40 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:43 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:44 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:44 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 11:52 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:52 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:52 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Ping timeout: 265 seconds] | 11:57 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:57 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:57 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:02 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:02 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:02 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:06 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:06 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:06 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:10 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:11 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:11 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:16 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:16 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:16 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:21 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:21 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:21 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:25 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Read error: Connection reset by peer] | 12:26 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:26 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:26 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:29 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:30 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:30 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:38 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:38 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:38 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:43 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:43 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:43 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:47 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:47 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:47 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:51 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:51 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:51 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:57 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:57 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:57 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 13:00 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 13:02 |
-!- mode/#webgui [+v Radix_] by ChanServ | 13:02 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Ping timeout: 265 seconds] | 13:07 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 13:20 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 14:39 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 19:07 |
-!- mode/#webgui [+v patspam] by ChanServ | 19:07 |
-!- CIA-57 [cia@208.69.182.149] has quit [Ping timeout: 245 seconds] | 19:40 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 19:46 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 19:50 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 20:11 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 20:15 |
-!- CIA-57 [cia@208.69.182.149] has joined #webgui | 20:31 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 20:33 |
-!- mode/#webgui [+v Radix_] by ChanServ | 20:33 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 20:41 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 20:49 |
-!- d34df00d [~d34df00d@93.175.7.95] has joined #webgui | 20:53 |
d34df00d | Hi! | 20:57 |
d34df00d | Is there a way to have different language versions of each article? | 20:57 |
d34df00d | Show only one of them at the same time, based on user preferences or cookies or whatever seems best, but allow to switch the language. | 20:57 |
d34df00d | And, maybe, encode the language code (like home/welcome/en or home/welcome/ru for example) to optimize for search engines. They seem to not like when the same page on the same URL may appear in different languages. | 20:58 |
d34df00d | I've googled a bit and found http://www.webgui.org/web_design_templates_and_themes/creating-a-multilingual-website, but the final comment there says: | 20:58 |
d34df00d | There is internationalization of the interface of WebGUI. So you can translate WebGUI strings into your own language but there is no true support for multilingual websites unfortunately... I also would like to have it though. | 20:58 |
-!- d34df00d [~d34df00d@93.175.7.95] has left #webgui ["Konversation terminated!"] | 21:39 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 22:33 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 22:57 |
--- Day changed Sun Jun 06 2010 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 00:03 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 00:39 |
-!- carogray1 [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 01:54 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Ping timeout: 265 seconds] | 01:57 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 02:10 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 03:48 |
-!- carogray1 [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 06:02 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 06:33 |
CIA-57 | webgui: Colin Kuskie master * r8d85912 / t/Asset/Wobject/Survey.t : Commit the initial Survey for the test. - http://bit.ly/cIfCDt | 07:24 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rbe259d8 / (2 files in 2 dirs): | 08:27 |
CIA-57 | webgui: Fix problems with assetExportHtml. The method needs to be rethought, and make | 08:27 |
CIA-57 | webgui: check that one exists before calling it via can/DOES. Fix a problem with | 08:27 |
CIA-57 | webgui: duplicating the session, since duplicate is not a class method. - | 08:27 |
CIA-57 | webgui: http://bit.ly/dqcw6p | 08:27 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 11:09 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:10 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:10 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:13 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:14 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:14 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:18 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:19 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:19 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:22 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:23 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:23 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:26 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:27 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:27 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:31 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:32 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:33 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:36 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:37 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:37 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:40 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:40 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:41 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:44 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:45 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:45 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 11:50 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:51 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:51 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 11:55 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 11:56 |
-!- mode/#webgui [+v Radix_] by ChanServ | 11:56 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:00 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:01 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:01 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:06 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:07 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:07 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:11 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:11 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:11 |
-!- Radix_ [~Radix@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:17 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:17 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:17 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Quit: No Ping reply in 180 seconds.] | 12:24 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:24 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:24 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:28 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:28 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:28 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:32 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:32 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:32 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has quit [Client Quit] | 12:36 |
-!- Radix_ [quasselcor@203.161.71.161.static.amnet.net.au] has joined #webgui | 12:36 |
-!- mode/#webgui [+v Radix_] by ChanServ | 12:36 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 15:19 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 16:27 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Ping timeout: 264 seconds] | 18:39 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 18:40 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 19:12 |
-!- mode/#webgui [+v patspam] by ChanServ | 19:12 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 20:00 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 20:44 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 20:59 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 21:04 |
-!- fokat [~lem@200.84.244.194] has joined #webgui | 21:28 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 21:47 |
-!- fokat [~lem@200.84.244.194] has quit [Quit: Ex-Chat] | 22:20 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 22:55 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 23:25 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 23:39 |
-!- carogray1 [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 23:41 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Ping timeout: 265 seconds] | 23:43 |
--- Day changed Mon Jun 07 2010 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 00:01 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 00:26 |
-!- mode/#webgui [+v patspam] by ChanServ | 00:26 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 00:27 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 00:54 |
-!- carogray1 [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 01:29 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Read error: Connection reset by peer] | 01:52 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 01:58 |
-!- mode/#webgui [+v patspam] by ChanServ | 01:58 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 02:14 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 02:22 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 02:59 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 03:14 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 04:52 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 05:01 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 05:39 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 07:13 |
CIA-57 | webgui: Colin Kuskie master * rd81a28b / (6 files in 3 dirs): Fix some broken Form fields. Fixes bug #11611 - http://bit.ly/9VNQoo | 08:30 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rf6408ce / (3 files in 3 dirs): Fix some broken Form fields. Fixes bug #11611. - http://bit.ly/ahLq2k | 08:33 |
CIA-57 | webgui: Colin Kuskie master * rc5203cb / lib/WebGUI/Form/FieldType.pm : Remove some debug code. - http://bit.ly/96Dv7W | 08:33 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 09:05 |
-!- kaare is now known as Guest54945 | 09:05 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:05 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:05 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 12:14 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 12:25 |
-!- carogray [~Caroline@166.128.245.96] has joined #webgui | 13:48 |
-!- carogray1 [~Caroline@166.203.103.32] has joined #webgui | 14:04 |
-!- carogray [~Caroline@166.128.245.96] has quit [Ping timeout: 258 seconds] | 14:06 |
-!- carogray [~Caroline@mobile-166-217-159-173.mycingular.net] has joined #webgui | 14:19 |
-!- carogray1 [~Caroline@166.203.103.32] has quit [Ping timeout: 258 seconds] | 14:22 |
-!- carogray [~Caroline@mobile-166-217-159-173.mycingular.net] has quit [Ping timeout: 258 seconds] | 14:25 |
-!- carogray [~Caroline@32.178.44.64] has joined #webgui | 14:56 |
-!- carogray1 [~Caroline@166.203.211.134] has joined #webgui | 15:01 |
-!- carogray [~Caroline@32.178.44.64] has quit [Ping timeout: 258 seconds] | 15:01 |
-!- carogray1 [~Caroline@166.203.211.134] has quit [Ping timeout: 258 seconds] | 15:05 |
-!- carogray [~Caroline@166.203.207.248] has joined #webgui | 15:08 |
-!- carogray [~Caroline@166.203.207.248] has quit [Ping timeout: 258 seconds] | 15:15 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 15:27 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 15:33 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Read error: Connection reset by peer] | 15:45 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 15:48 |
-!- ryuu_ro [~rory@194.171.50.69] has joined #webgui | 15:55 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has joined #webgui | 16:03 |
-!- Guest54945 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 16:16 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 16:25 |
-!- SDuensin [~Scott@62.sub-174-220-109.myvzw.com] has joined #webgui | 16:30 |
SDuensin | Howdy. | 16:32 |
+bartjol | ahoi cowboy | 16:35 |
+bartjol | mmm, the bug tracker seems a bit borked | 16:56 |
plainhao | how so, bartjol? | 16:58 |
+bartjol | the pagination isn't working | 16:58 |
plainhao | you mean in search? | 16:59 |
+bartjol | yes | 16:59 |
plainhao | yeah, i noticed that too | 16:59 |
plainhao | frank closed the ticket already, maybe he forgot to push something for the fix | 16:59 |
+bartjol | trying to find an old bug | 16:59 |
+bartjol | changelogs are prolly better | 17:00 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 17:31 |
-!- mode/#webgui [+o preaction] by ChanServ | 17:31 |
+bartjol | found it! | 17:36 |
-!- ryuu_ro [~rory@194.171.50.69] has quit [Quit: ryuu_ro] | 17:40 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 17:44 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 17:45 |
-!- mode/#webgui [+v patspam] by ChanServ | 17:45 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 17:47 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 17:57 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 17:57 |
+perlDreamer | morning, folks | 17:57 |
CIA-57 | webgui: Colin Kuskie master * r20e6ba5 / (2 files in 2 dirs): Fix a typo in the CS sort by hover help. Fixes bug #11610 - http://bit.ly/cJg1lW | 18:00 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rf872b46 / (2 files in 2 dirs): Fix a typo in the CS sort by hover help. Fixes bug #11610 - http://bit.ly/b0LCRf | 18:00 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r8de257f / (3 files in 3 dirs): Make the state field required in the ITransact credentials form. Fixes bug #11608 - http://bit.ly/caWIVZ | 18:15 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:23 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r1bb0e31 / (2 files in 2 dirs): Remove some dead code from the UserList wobject. Fixes bug #11605 - http://bit.ly/a0fttB | 18:25 |
CIA-57 | webgui: Colin Kuskie master * r28eabdd / (2 files in 2 dirs): Remove some dead code from the UserList wobject. Fixes bug #11605 | 18:26 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 18:51 |
-!- mode/#webgui [+o tavisto] by ChanServ | 18:51 |
+perlDreamer | frodwith, I need a logic double check. | 18:57 |
@frodwith | Mmmmyeasss? | 18:58 |
+perlDreamer | Have a peek at /data/WebGUI/lib/WebGUI/Workflow/Activity/PurgeOldInboxMessages.pm | 18:58 |
+perlDreamer | and the little blurb at the end of the execute subroutine | 19:00 |
+perlDreamer | if the while loop finishes | 19:00 |
+perlDreamer | then the limit check should never be reached, right? | 19:01 |
@frodwith | it doesn't look like that can ever happen | 19:03 |
@frodwith | well, or rather | 19:03 |
@frodwith | it's the wrong check | 19:03 |
@frodwith | $sth->rows might very well be over limit | 19:03 |
@frodwith | but who cares? | 19:03 |
+perlDreamer | yeah, they have to be processed anyway | 19:03 |
@frodwith | they already -got- processed | 19:03 |
@frodwith | i think someone forgot a LIMIT in the sql query | 19:04 |
+perlDreamer | i don't think that matters, because there's a time bomb inside the while loop, and we loop over an iterator | 19:04 |
@frodwith | i mean, if they're going to bother with a limit at all | 19:05 |
@frodwith | you're right that there's no reason to | 19:05 |
+perlDreamer | okay, yeah | 19:05 |
+perlDreamer | thanks for the double check, frodwith | 19:09 |
@frodwith | np | 19:09 |
* perlDreamer is only running on about 5/6 cylinders today | 19:09 |
@frodwith | Out partying all weekend, you dog? | 19:10 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has quit [Read error: Operation timed out] | 19:10 |
+perlDreamer | yeah, you know me | 19:10 |
+perlDreamer | too much punch after the church concert last night | 19:19 |
@frodwith | They don't put anything in it, mind, perlDreamer just has a very sensitive constitution | 19:20 |
+perlDreamer | It was PINK, that counts | 19:20 |
@frodwith | nothing natural is pink | 19:20 |
@frodwith | except maybe flowers | 19:20 |
@frodwith | was it flower punch? | 19:21 |
+perlDreamer | No, like fake pink lemonade | 19:21 |
@frodwith | that artificial flavoring can really knock you for a loop | 19:22 |
+perlDreamer | it was either that, or the hour long tuba playing session | 19:23 |
@frodwith | o_o | 19:24 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 19:35 |
-!- mode/#webgui [+o scrottie] by ChanServ | 19:35 |
+perlDreamer | yo, scrottie | 19:36 |
+perlDreamer | how was the hike? | 19:36 |
@scrottie | hey. | 19:36 |
@scrottie | it's nice to go visit trees. we really don't get those here in Phoenix. | 19:37 |
@scrottie | ditto for water. not often in Phoenix you get to wade through streams with water up to your neck. | 19:37 |
+perlDreamer | hm, water up to your neck. Sounds like Oregon | 19:37 |
@scrottie | heh | 19:38 |
@scrottie | have a good weekend? get out of the house? | 19:55 |
* frodwith got out of the house for church. Does that count? | 19:56 |
+perlDreamer | Did tons of yard work, spent 8 hours at church, baked cookies | 19:58 |
plainhao | how often do you go, frod? | 19:58 |
@frodwith | bout once a week hao | 19:58 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 20:08 |
-!- kimd [~spunky@p549F34F0.dip.t-dialin.net] has joined #webgui | 20:46 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 240 seconds] | 20:46 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 20:46 |
CIA-57 | webgui: Colin Kuskie master * r30e869b / (6 files in 5 dirs): Better cleanup of Inbox messages. Encapsulate all SQL in Inbox/Message. Fix workflow. Upgrade script to cleanup state table. Fixes bug #11595. - http://bit.ly/ciu8Y2 | 20:47 |
CIA-57 | webgui: Colin Kuskie master * r99063a3 / (t/Inbox.t t/lib/WebGUI/Test.pm): Allow for cleanup of inbox messages in tests. - http://bit.ly/auF5O0 | 20:47 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rc1af736 / (t/Inbox.t t/lib/WebGUI/Test.pm): Allow for cleanup of inbox messages in tests. - http://bit.ly/9gMdBd | 20:48 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r5c5b6ed / (6 files in 5 dirs): Better cleanup of Inbox messages. Encapsulate all SQL in Inbox/Message. Fix workflow. Upgrade script to cleanup state table. Fixes bug #11595. - http://bit.ly/9xf9J1 | 20:49 |
scrottie | Colin, are you working on the alumni bug report with messages vanishing after people get booted out of groups? | 20:50 |
scrottie | s/report // | 20:50 |
+perlDreamer | not right now | 20:50 |
+perlDreamer | You can fix it if you want :) | 20:50 |
scrottie | okay. Frank asked me to do that and those commits looked maybe repeated but what do I know. just trying to avoid stepping on toes. | 20:51 |
+perlDreamer | It's a different bug. The commits are repeated because all bugs have to be backported to the stable branch | 20:52 |
scrottie | yeah. fwiw, Frank asked me to look at 11595 and 11594. | 20:57 |
+perlDreamer | If you've been asked/assigned/volunteered/been bribed/threatened/etc to fix a bug, then you should assign the bugs to yourself in the bug tracker | 20:57 |
scrottie | yeah. | 20:57 |
scrottie | not complaining, btw. | 20:58 |
scrottie | next time. | 20:58 |
+perlDreamer | I know. I don't like stepping on toes either | 20:58 |
+perlDreamer | by default, I'm tasked with fixing all bugs | 20:58 |
+perlDreamer | all WebGUI bugs, that is | 20:58 |
scrottie | heh | 20:58 |
+perlDreamer | speaking of which... | 20:59 |
+perlDreamer | dionak, I'd love to fix serif's Syndicated Content bug, but I need some feedback | 20:59 |
+perlDreamer | can you give her a ping, or perhaps look at the bug yourself and answer the question? | 20:59 |
dionak | ok, i'll ask her to sign on | 20:59 |
dionak | i've pinged. if she's available, she'll sign on | 21:00 |
dionak | or when she's available i should say | 21:01 |
dionak | perlDreamer, she's knee-deep in developing atm. said she would follow up with you. | 21:02 |
scrottie | I can't seem to wake up this morning. uuuurrrgh. | 21:03 |
+perlDreamer | awesome, I'll wait for a bug ticket posting then :) | 21:03 |
scrottie | perlDreamer, status on #11594? | 21:03 |
+perlDreamer | haven't touched it yet | 21:03 |
scrottie | hmm. thinking of assigning it to myself. but I'm also 100% certain that Frank would be perfectly happy to let you do it and have me do something else. | 21:05 |
+perlDreamer | or he may want you to start learning the API this way | 21:05 |
+perlDreamer | best to ask him | 21:06 |
kimd | pearlDreamer does not have time. He has to answer all my questions. | 21:06 |
kimd | Hello pearlDreamer, btw :-) | 21:06 |
+perlDreamer | bring it on, kimd! | 21:06 |
kimd | Not yet. I am still trying to find out myself. | 21:07 |
kimd | But I will most certainly give up in about 5 minutes. | 21:07 |
* perlDreamer will be here | 21:07 |
kimd | It's about WWW::Mechanize if you want to warm up a bit. | 21:07 |
scrottie | hmm. I think I'll not assign it to myself, read code, and if it gets fixed before I commit something, I'll ask for something else =) | 21:12 |
+perlDreamer | for the kinds of changes he's talking about, I recommend some tests | 21:12 |
+perlDreamer | write ones that will fail before the bug fix | 21:13 |
scrottie | sir, YES SIR | 21:13 |
CIA-57 | webgui: Colin Kuskie master * r59fed35 / (docs/changelog/7.x.x.txt lib/WebGUI/Shop/AddressBook.pm): Fix error feedback for missing fields, when using the AddressBook to add an address. - http://bit.ly/9va8gV | 21:18 |
kimd | pearlDreamer, I am ready to give up :-( | 21:18 |
kimd | The testing code I am working on is here: http://webgui.pastebin.com/4Wb2NYAR | 21:18 |
kimd | I am trying to edit an existing photo in a gallery using the web interface. | 21:18 |
kimd | Submittal of the form seems to be fine. Values do not get updated, however. | 21:19 |
kimd | I have checked by comparing the properties hash and the web server response. | 21:19 |
kimd | Any idea about the possible reason? | 21:20 |
+perlDreamer | reading and thinking... | 21:20 |
@frodwith | scrottie: http://www.humbledmba.com/become-a-morning-person-how-to-end-insomnia-f | 21:20 |
scrottie | I don't have insomnia. I sleep like a ROCK when I finally pass out, which is often about the time the sun is coming up. | 21:21 |
@frodwith | that's called "insomnia" | 21:21 |
+perlDreamer | kimd, are you sure there's only 1 form on the page? | 21:21 |
kimd | No. But I have named the form and it is explicitly selected. | 21:22 |
@frodwith | the f.lux thing worked really well for me last night, i woke up at 6:30 this morning. But that may be entirely psychosomatic. | 21:22 |
kimd | I made a change in WebGUI::Asset::File::GalleryFile::Photo. | 21:22 |
@frodwith | er | 21:22 |
scrottie | I've known people who really barely ever sleep and really want to. I don't have that problem. I can sleep any time. I'm wall respected napper, too. I can sleep in planes, on buses, in parks... | 21:22 |
@frodwith | placebo effect | 21:22 |
scrottie | problem is, I'm dating a morning person. | 21:22 |
@frodwith | the f.lux thing is for getting you to feel sleepy when it gets dark outside | 21:22 |
scrottie | I'm jetlagged. | 21:22 |
@frodwith | if you're an evening computer user | 21:23 |
-!- SDuensin [~Scott@62.sub-174-220-109.myvzw.com] has quit [Ping timeout: 240 seconds] | 21:23 |
kimd | pearlDreamer, I just noticed that it is reproducible when I do it manually. | 21:24 |
kimd | Changes become only visible after a refresh of the page. | 21:24 |
kimd | Let me check in the current demo. | 21:24 |
kimd | Maybe it is a bug. | 21:24 |
-!- SDuensin [~Scott@62.sub-174-220-109.myvzw.com] has joined #webgui | 21:25 |
scrottie | argh, people are sending me Internet self help links =( | 21:27 |
scrottie | lifestyle fail. | 21:27 |
scrottie | I guess it's fair. I was yelling at perlDreamer to get out of the house jetsky or skydrive or *something* the other day. | 21:28 |
scrottie | the house and jetsky or ... | 21:28 |
+perlDreamer | jetski | 21:28 |
scrottie | yeah. that. | 21:28 |
@frodwith | Next thanksgiving, scrottie will drive a float through town square. It just be a large sign on a platform. The sign will read "Frodwith, you jerk!" And scrottie will be riding on it, shouting the phrase at intervals into a bullhorn. | 21:29 |
+perlDreamer | the back of the sign will say, "He was right!" | 21:29 |
scrottie | I have in the past been on a morning schedule. I can go to bed at night and sleep. I honestly enjoy my late nights. I like the solitude and the quiet. I take long walks when there's no one else on the streets. | 21:30 |
scrottie | Some times I start staying up till 2am and then have to get up at 4am to meet a friend at 5am to get to Sedona by 7ish. | 21:31 |
scrottie | and wade around in cold water all day. | 21:31 |
scrottie | I do it to myself. I realize that. And I don't have plans to stop. | 21:31 |
@frodwith | hehe | 21:31 |
@frodwith | Self-inflicted is the best kind of pain | 21:31 |
scrottie | and now I'm listening to old audio tapes =) | 21:31 |
-!- SDuensin_ [~Scott@235.sub-72-107-14.myvzw.com] has joined #webgui | 21:32 |
scrottie | the noise isn't bad but the tape stretch is kinda painful. | 21:32 |
-!- SDuensin [~Scott@62.sub-174-220-109.myvzw.com] has quit [Ping timeout: 240 seconds] | 21:33 |
kimd | pearlDreamer, it seems to be a bug. | 21:35 |
kimd | The behavior is reproducible on demo.webgui.org and beta.webgui.org. | 21:36 |
+perlDreamer | that's not good | 21:36 |
kimd | The problem occurs if there is no image file attached to a photo. | 21:36 |
+perlDreamer | but didn't you specify a file to upload in the form submission? | 21:36 |
kimd | In that case you need a refresh before the values become visible. | 21:36 |
kimd | No. You do not have to. The form is still accepted. | 21:37 |
+perlDreamer | okay | 21:37 |
+perlDreamer | still, I thought that, in your test, you specified a file in the form submission | 21:37 |
kimd | However, only if an image is present www_showConfirmation will be called properly after www_editSave | 21:37 |
kimd | No. I am only changing the text properties. | 21:38 |
+perlDreamer | line 183, newFile_file = ... ?? | 21:38 |
kimd | But the photo asset was created without an attachment. | 21:38 |
+perlDreamer | ah, I see | 21:39 |
kimd | No, that isn't my code. And that part is skipped. | 21:39 |
kimd | But I can attach an image file at the beginning. Let's what happens... | 21:39 |
kimd | ... see ... | 21:39 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Read error: Connection reset by peer] | 21:41 |
CIA-57 | webgui: Colin Kuskie master * rc9dc084 / (3 files in 3 dirs): Stories have to pass along absolute links in their RSS feeds. Fixes bug #11606 - http://bit.ly/bjgTVN | 21:45 |
kimd | Interesting. If a request the photo default view a second time, I get the expected result. | 21:45 |
kimd | Evidently, it takes two requests before the Asset gets updated. What could be the reason for this behavior? | 21:45 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r834a85c / (3 files in 3 dirs): Stories have to pass along absolute links in their RSS feeds. Fixes bug #11606 - http://bit.ly/btPbOR | 21:45 |
+perlDreamer | no idea, kimd | 21:47 |
kimd | Is it possible that theres is some delay due to spectre processing changes in the background? | 21:48 |
+perlDreamer | No | 21:48 |
+perlDreamer | For most development work, I don't even turn spectre on | 21:48 |
kimd | But it must be some kind of race condition. | 21:48 |
+perlDreamer | committing a single asset should be very fast | 21:48 |
+perlDreamer | Let me make sure I understand the process. | 21:50 |
+perlDreamer | Make a gallery | 21:50 |
+perlDreamer | add an album to it | 21:50 |
+perlDreamer | create a photo, but do not upload a photo into it | 21:50 |
+perlDreamer | then, try to edit that photo | 21:50 |
+perlDreamer | your changes do not show up right away | 21:51 |
+perlDreamer | but instead, you have to reload the view photo screen to see them | 21:51 |
kimd | Yes. That is what I observe. Attaching a photo in the testing code does not make a difference, btw. | 21:51 |
kimd | I also noticed that I do not get forwarded to www_showConfirmation. | 21:52 |
+perlDreamer | that may be due to a problem with how file uploads are handled by Mech | 21:52 |
+perlDreamer | but let's deal with the bug at hand, first | 21:53 |
kimd | Don't you think it is related? | 21:54 |
kimd | If I create a photo manually and do not attach an image, I am returned to the default view immediately after editing. | 21:54 |
kimd | If I attach an image, www_showConfirmation is called instead after editing. | 21:54 |
kimd | That alone I would consider a bug. | 21:54 |
kimd | There must be an issue in www_editSave. | 21:55 |
+perlDreamer | probably, kimd | 21:55 |
kimd | If a return from www_showConfirmation (manually), the asset is always up to date. | 21:56 |
+perlDreamer | Couldn't call method editSave on asset for url: home/untitled/test/great-photo Root cause: Couldn't copy '' to '800.jpg': Is a directory at /data/WebGUI/lib/WebGUI/Asset/File/GalleryFile/Photo.pm line 422 | 21:56 |
+perlDreamer | that's the problem | 21:56 |
kimd | That sounds like makeResolutions. | 21:56 |
kimd | It obviously does not check for a missing image. | 21:57 |
kimd | I will check. Thanks a lot. | 21:57 |
+perlDreamer | hack on, kimd | 21:57 |
kimd | Think I found it. | 21:58 |
kimd | Is it ok to use croak for reporting errors? | 21:58 |
kimd | Still being used here and there in the code. | 21:59 |
+perlDreamer | it's better to use WebGUI::Error->throw | 21:59 |
+perlDreamer | and then catch the exception and report an error to the user | 22:00 |
kimd | Can you give me a file with an example? | 22:00 |
+perlDreamer | yes... | 22:00 |
+perlDreamer | Shop/PayDriver, line 482, for throwing the error | 22:01 |
kimd | Cool. | 22:02 |
kimd | But wouldn't logging be sufficient in that case? | 22:02 |
+perlDreamer | well, yes and no | 22:03 |
kimd | If there is no image attached we can just skip making resolutions and log a message. | 22:03 |
+perlDreamer | there you go | 22:03 |
kimd | Ok. Will do that then. | 22:03 |
kimd | perlDreamer, do you think it would be good to attach a default image to new photos? | 22:07 |
+perlDreamer | no | 22:08 |
+perlDreamer | hm | 22:15 |
+perlDreamer | that's the 2nd time that I've heard that idea though | 22:15 |
+perlDreamer | maybe I'm being too stubborn | 22:15 |
@frodwith | I seem to remember there being something about a default image once on the alumni site. It's ringing a bell. | 22:21 |
@frodwith | an alarm bell. | 22:21 |
+perlDreamer | it was posted as a bug | 22:21 |
+perlDreamer | but we were unable to duplicate it in either recent branch | 22:21 |
+perlDreamer | attributing it to recent bug fixes, or perhaps some custom code issue | 22:22 |
* perlDreamer is out to lunch, with all appropriate connotations | 22:27 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:30 |
kimd | Can someone explain to me why $asset = $asset->cloneFromDb is not the same as $asset = WebGUI::Asset->newByDynamicClass($session, $asset->getId) ? | 22:41 |
kimd | preaction, would you be willing to help me out if I told you that the new style selector rocks? | 22:42 |
* kimd is having a break, too. | 22:49 |
-!- SDuensin_ [~Scott@235.sub-72-107-14.myvzw.com] has quit [Quit: Leaving] | 23:00 |
+perlDreamer | cloneFromDb is shorter, and it uses the same revisionDate | 23:18 |
+perlDreamer | there you go, kimd, that's why it's not the same | 23:18 |
+perlDreamer | i have to go reheat a zigeuner schnitzel, brb | 23:18 |
kimd | Thanks, perlDreamer! Enjoy the Schnitzel. | 23:28 |
kimd | pearlDreamer, I ran into another problem (surprise!) | 23:34 |
kimd | WWW::Mechanize is causing a server error sometimes but not always. | 23:34 |
kimd | Executing the test script sometimes returns the following error message: http://webgui.pastebin.com/4zHBanaB | 23:35 |
kimd | I suspect it has something to do with the getMechLogin function. | 23:35 |
kimd | Ever seen that before? | 23:35 |
kimd | In the log I can see the following error message: 2010/06/07 22:36:23 - FATAL - dev.localhost.localdomain.conf - WebGUI::SQL::ResultSet::execute[137] - Couldn't execute prepared statement: insert into assetData (assetId, revisionDate, revisedBy, tagId, status, url, ownerUserId, groupIdEdit, groupIdView) values (?, ?, ?, ?, 'pending', ?, '3','3','7') : With place holders: h9Xrbp1on2GNA7U69N3vhQ, 1275942983, JU7-WeWMzgBi17SnTUEIgg, hx0963l51-hKtSwx | 23:36 |
kimd | 9VWUjw, h9Xrbp1on2GNA7U69N3vhQ. Root cause: Duplicate entry 'h9Xrbp1on2GNA7U69N3vhQ-1275942983' for key 1 | 23:36 |
kimd | "wgd reset" does not solve the problem. | 23:38 |
scrottie | afk a few | 23:41 |
kimd | It is the testing code starting in line 164 that causes the problem (see http://webgui.pastebin.com/GzRgTXPR) | 23:42 |
+perlDreamer | kimd, it's not allowed to have the revisionDate the same on two revisions | 23:44 |
+perlDreamer | if the script runs fast enough, the www_edit method can do that | 23:44 |
+perlDreamer | so, it's safest to force the revisionDate on gallery, album, and original photo to be 4-5 seconds in the past | 23:44 |
kimd | I see. Should I sleep for a second? Or change the revisionDate manually? | 23:45 |
+perlDreamer | change it manually | 23:45 |
+perlDreamer | it'll save test time | 23:45 |
kimd | Is there an API function for that? | 23:45 |
+perlDreamer | see addChild method on how to set it manually | 23:45 |
kimd | I will. Thanks again. | 23:45 |
kimd | Ok, seems to solve the problem. Will have to make the code nicer. | 23:52 |
+perlDreamer | ugh, patspam. MIME::Entity is seriously nasty stuff | 23:54 |
+perlDreamer | like drinking freeze-dried new york coffee | 23:54 |
+patspam | ow sorry perlDreamer | 23:54 |
kimd | A last question for tonight: | 23:56 |
+perlDreamer | k | 23:56 |
kimd | k? | 23:56 |
+perlDreamer | short for okay | 23:56 |
kimd | Ah. | 23:56 |
-!- preaction [~doug@207.200.236.230] has quit [Quit: preaction] | 23:56 |
+perlDreamer | okay => ok => kay => k | 23:56 |
kimd | Redirecting via the "proceed" parameter will not update the current URL. | 23:56 |
kimd | Is there a way to get around that? | 23:57 |
kimd | For example, calling with "?proceed=viewParent" will display the parent's default view still showing the URL of the child. | 23:57 |
+perlDreamer | right | 23:57 |
+perlDreamer | currently, if you call all the way back up to Asset's www_editSave, no | 23:58 |
kimd | Isn't that buggy? At least it makes testing very difficult. | 23:58 |
+perlDreamer | it's not buggy | 23:58 |
+perlDreamer | it's not great either, though | 23:58 |
+perlDreamer | I've heard that we won't do funky internal redirects like that anymore | 23:58 |
+perlDreamer | but for now... I'm afraid you're stuck | 23:58 |
kimd | What would be the new way of doing this correctly? | 23:59 |
kimd | Oh. | 23:59 |
+perlDreamer | set a redirect :) | 23:59 |
kimd | That would be a drastic change in editSave, wouldn't it? | 23:59 |
+perlDreamer | yes | 23:59 |
kimd | Allowed in 7.9.x? | 23:59 |
+perlDreamer | i don't think so, but that would be preaction's call | 23:59 |
--- Day changed Tue Jun 08 2010 |
kimd | He is gone. He just quit. | 00:00 |
+perlDreamer | he'll be back. Send him a dev posting about the problem | 00:00 |
kimd | I will. But only tomorrow. I need to get some sleep now. | 00:00 |
kimd | Thanks for all the help.l | 00:00 |
+perlDreamer | you're always welcome, kimd | 00:01 |
* perlDreamer is off to pick up children from school | 00:01 |
kimd | Enjoy the rest of your day. And everyone else as well, of course. | 00:01 |
+perlDreamer | back i n30 | 00:01 |
-!- kimd [~spunky@p549F34F0.dip.t-dialin.net] has quit [Quit: Ex-Chat] | 00:01 |
-!- ckotil [~ckotil@snare.grnoc.iu.edu] has joined #webgui | 00:02 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Quit: Leaving.] | 00:04 |
-!- preaction [~doug@71-90-29-5.dhcp.ftbg.wi.charter.com] has joined #webgui | 00:24 |
-!- mode/#webgui [+o preaction] by ChanServ | 00:24 |
-!- preaction [~doug@71-90-29-5.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 00:38 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 00:40 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 00:45 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 00:52 |
-!- mode/#webgui [+o preaction] by ChanServ | 00:52 |
CIA-57 | webgui: Colin Kuskie master * rc4e85d8 / (2 files in 2 dirs): Restore the other fields that a CS can be sorted on, from the thread table. Fixes bug #11614. - http://bit.ly/devEIx | 01:05 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r56e01cb / (2 files in 2 dirs): Restore the other fields that a CS can be sorted on, from the thread table. Fixes bug #11614. - http://bit.ly/9hzOaZ | 01:05 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 240 seconds] | 01:11 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 01:12 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 01:17 |
-!- mode/#webgui [+o scrottie] by ChanServ | 01:17 |
Haarg | perlDreamer, re: be259d8 | 01:22 |
+perlDreamer | yes sir! | 01:23 |
+perlDreamer | ? | 01:23 |
Haarg | first is that the $orig call looks wrong | 01:23 |
Haarg | since the params have already been shifted off | 01:23 |
Haarg | second, i'm not quite clear on what you mean with checking if one exists in the commit message | 01:23 |
+perlDreamer | let me finish this hot patch, and I'll review the WebGUI8 log | 01:24 |
Haarg | there are a bunch of parts of the export code i don't love, but what is the actual problem you are seeing? | 01:24 |
+perlDreamer | inside WebGUI::Session->config, when it tries to return $self->{_config}, it says, "Unable to use string 'WebGUI::Session' as a hash reference. | 01:25 |
+perlDreamer | that's off the top of my head | 01:25 |
+perlDreamer | you could always revert the patch, then try to run t/AssetAspect/RssFeed.t | 01:25 |
+perlDreamer | and it will tell you exactly | 01:25 |
Haarg | oh, well yeah i see what the change was meant to fix | 01:25 |
Haarg | i mean the "The method needs to be rethought, and make check that one exists before calling it via can/DOES." in the commit message | 01:26 |
+perlDreamer | ah, yes | 01:27 |
+perlDreamer | "this method" being exportAssetCollateral | 01:27 |
+perlDreamer | instead of calling it all the time, it would be good to check that the asset has such a method, and then call it | 01:27 |
Haarg | don't all assets have it though? | 01:28 |
+perlDreamer | no | 01:28 |
+perlDreamer | the method supplied by AssetExportHtml is empty | 01:28 |
Haarg | oh, yeah | 01:28 |
Haarg | if we were going to go that route it seems like it would make more sense to have assets use 'after' on exportWriteFile | 01:30 |
Haarg | you are right that the WebGUI::Session->duplicate thing came from a mistake while merging | 01:31 |
+perlDreamer | except that it wouldn't have any way of getting either the reportSession, or the options | 01:31 |
Haarg | well, that could be changed | 01:31 |
+perlDreamer | yes, but changes ripple | 01:32 |
Haarg | if don't know if there is a strong motivation to change it though | 01:32 |
Haarg | the export code in general could use some refactoring | 01:32 |
+perlDreamer | definitely | 01:33 |
+perlDreamer | I can think of a reason to rewrite it | 01:33 |
+perlDreamer | after doesn't get the arguments, does it? | 01:33 |
+perlDreamer | mmmm, yes | 01:34 |
+perlDreamer | but they cannot be modified | 01:34 |
+perlDreamer | which in this case is fine | 01:34 |
* perlDreamer better sit in on frodwith's Moose class at the WUC | 01:34 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 01:37 |
+perlDreamer | Haarg, since exportWriteFile takes no arguments, there's no reason we can't add additional arguments to it | 01:39 |
Haarg | that's kind of what i was thinking | 01:39 |
+perlDreamer | like the options, reportSession, and URL | 01:39 |
Haarg | aside from general dissatisfaction with it though, what are the problems we would fix by changing it? | 01:40 |
+perlDreamer | Assuming that we get rid of the bare exportAssetCollateral sub, and go to can/DOES... | 01:42 |
+perlDreamer | then, for packages which only import roles, they need a placeholder sub for exportAssetCollateral | 01:43 |
+perlDreamer | since roles, like RssFeed, have to assume that their consumer may have one, and use a method modifier like after | 01:43 |
Haarg | there are ways around that, but it's kind of ugly | 01:43 |
+perlDreamer | really? | 01:44 |
Haarg | i think so | 01:44 |
+perlDreamer | how would you do it? | 01:44 |
Haarg | i think you can add the sub into the role as well as the modifier | 01:44 |
Haarg | i'm still not seeing the up side to this though | 01:44 |
+perlDreamer | no, I think using an after modifier on exportWriteFile is better | 01:44 |
Haarg | well yes | 01:45 |
Haarg | but why do we need to change it at all? | 01:45 |
+perlDreamer | and the little naked sub offends me | 01:45 |
+perlDreamer | that's the only reason. The little sub offends me. | 01:45 |
+perlDreamer | it would offend me less in the case of having it in a consumer of a role | 01:46 |
+perlDreamer | but no need for every asset to get it when it's not needed. | 01:46 |
Haarg | not that i disagree with you, but it seems like a bit of work to fix a problem that has no real impact | 01:47 |
+perlDreamer | probably 1.5 - 2 hours with testing | 01:47 |
+perlDreamer | but you're right about extra time, tight deadlines, and the need to merge in psgi | 01:48 |
+perlDreamer | I'll just fix the bad around code, and keep it in a note for future WebGUI purification | 01:48 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r963591d / lib/WebGUI/Role/Asset/RssFeed.pm : Fix a bad around wrapper in the RssFeed assetExportHtml sub. - http://bit.ly/cvjSiU | 01:50 |
* Haarg is currently manually modifying svn dump files to make something git-svn can understand | 01:51 |
* perlDreamer needs to head outside, and mow the lawns at warp speed, before the rains return | 01:51 |
CIA-57 | webgui: Graham Knop WebGUI8 * r9c99fa2 / t/lib/WebGUI/Test.pm : clean up some parts of WebGUI::Test - http://bit.ly/bSHfrX | 01:55 |
CIA-57 | webgui: Graham Knop WebGUI8 * r033fc6c / t/lib/WebGUI/Test.pm : allow skipping test cleanup - http://bit.ly/dq5hGS | 02:01 |
CIA-57 | webgui: Graham Knop WebGUI8 * r5cb384e / lib/WebGUI/Types.pm : ensure JSON is loaded - http://bit.ly/cwv0oR | 02:01 |
CIA-57 | webgui: Graham Knop WebGUI8 * r1e2b6fd / (lib/WebGUI/Asset/Snippet.pm lib/WebGUI/Asset/Template.pm): allow undefined template or snippet text - http://bit.ly/dAy8k3 | 02:12 |
Haarg | preaction, i noticed the latest CHI automatically serializes keys | 02:38 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 260 seconds] | 02:40 |
@scrottie | alright, why do you have to do $session->config->set( 'emailOverride' before WebGUI tests will queue email messages? | 02:44 |
@scrottie | or do you? what exactly does that accomplish, I guess I mean I think. | 02:44 |
@scrottie | no, setting a from in the WebGUI::Mail::Send works too. | 02:47 |
@scrottie | no, that just didn't get undone and now the default stuck. hmm. | 02:53 |
+perlDreamer | scrottie, you don't | 02:55 |
+perlDreamer | it's just one way to test emails | 02:56 |
+perlDreamer | personally, I like the mini email test server that preaction set up | 02:56 |
Haarg | emailOverride is more for manually testing email stuff, not for test scripts | 02:56 |
Haarg | IO::Socket::SSL is needed for LDAPS. i guess it should just be a normal prereq then? | 02:59 |
CIA-57 | webgui: Graham Knop WebGUI8 * r950d751 / sbin/testEnvironment.pl : add IO::Socket::SSL as prereq for LDAPS - http://bit.ly/d4soh8 | 03:01 |
+perlDreamer | and we'll need that back in beta/stable, too, won't we Haarg? | 03:03 |
Haarg | probably | 03:04 |
+perlDreamer | done | 03:05 |
CIA-57 | webgui: Colin Kuskie master * rbbe962a / sbin/testEnvironment.pl : add IO::Socket::SSL as prereq for LDAPS - http://bit.ly/bE9v5g | 03:05 |
@scrottie | testing disables logging... is there an easy way to undo that or to get at the messages otherwise? | 03:06 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r63e0f8a / sbin/testEnvironment.pl : add IO::Socket::SSL as prereq for LDAPS - http://bit.ly/9r63uv | 03:06 |
+perlDreamer | scrottie, they log into scalars | 03:06 |
+perlDreamer | in general, testing does not disable logging | 03:06 |
+perlDreamer | you have to ask it to do that for you | 03:06 |
@scrottie | hrm. | 03:06 |
+perlDreamer | I think it's WebGUI::Test->intercept_logging, and ->enable_logging | 03:07 |
+perlDreamer | but you should check those, I haven't used them for a very long time | 03:07 |
@scrottie | righto. thanks. hmm. | 03:09 |
@scrottie | I guess I'm confused. This has tables to hold messages internally but the code in WebGUI::Mail::Get/Send talks about POP and SMTP servers an awful lot. | 03:10 |
@scrottie | and it was internal tables that were finding themselves with inconsistent state. | 03:11 |
+perlDreamer | I think you may be confusing WebGUI::Inbox{,::Message} with WebGUI::Mail::Send | 03:11 |
@scrottie | the code is also really interested in finding and plugging in real email addresses. | 03:11 |
@scrottie | ahh. | 03:11 |
+perlDreamer | the first is for internal messaging | 03:11 |
@scrottie | yeah. | 03:11 |
+perlDreamer | the second is for queueing and sending emails | 03:12 |
+perlDreamer | emails are queued during active user requests | 03:12 |
@scrottie | yeah, that explains a lot. and this bug even says "WebGUI::Inbox". | 03:12 |
+perlDreamer | then Spectre dials up WebGUI, and starts sending them | 03:12 |
+perlDreamer | you don't want to learn about spectre yet | 03:13 |
@scrottie | sir, NO SIR. | 03:15 |
* perlDreamer takes a dinner break | 03:17 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 03:37 |
-!- dionak_ [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 03:37 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Ping timeout: 258 seconds] | 03:40 |
-!- dionak_ is now known as dionak | 03:40 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 03:54 |
-!- mducharme1 [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 03:56 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Ping timeout: 240 seconds] | 03:58 |
CIA-57 | webgui: Colin Kuskie master * r3b7d582 / (t/Exception/Shop.t t/Mail/Send.t t/i18n/template.t): Removing END blocks - http://bit.ly/c3oxAk | 04:12 |
+perlDreamer | Haarg, don't we have enough pieces to get rid of _all_ the END blocks in the tests? | 04:15 |
Haarg | i think so | 04:16 |
Haarg | for anything we don't have an easy cleanup thing for, you can just provide an arbitrary sub | 04:16 |
+perlDreamer | ... there is no way to delete a TaxDriver? | 04:28 |
Haarg | of course not. you can never get rid of taxes. | 04:28 |
CIA-57 | webgui: Colin Kuskie master * r65aa327 / (7 files in 4 dirs): Removing more END blocks - http://bit.ly/app6mi | 04:31 |
CIA-57 | webgui: Colin Kuskie master * r41b7413 / (t/Account/Friends.t t/Shop/Ship.t t/Shop/TaxDriver/Generic.t): More END block work. - http://bit.ly/b32VkK | 04:31 |
+perlDreamer | If I do 10 tests per night | 04:46 |
CIA-57 | webgui: Colin Kuskie master * rb728eab / (4 files in 2 dirs): Add cleanup for Shop::Vendors. More end block removal. - http://bit.ly/buAFGj | 04:46 |
+perlDreamer | in two weeks we can test Test::Aggregate | 04:46 |
-!- frodwith_ [~pdriver@helios.tapodi.net] has joined #webgui | 04:53 |
-!- frodwith [~pdriver@helios.tapodi.net] has quit [Ping timeout: 240 seconds] | 04:53 |
CIA-57 | webgui: Colin Kuskie master * r8a62abc / (3 files in 3 dirs): Add cleanup for AdSpaces, END block cleanup. - http://bit.ly/bG4lFs | 04:54 |
-!- steveo_aa [~sno@adsl-76-232-154-192.dsl.sfldmi.sbcglobal.net] has joined #webgui | 04:54 |
-!- mode/#webgui [+v steveo_aa] by ChanServ | 04:54 |
@scrottie | preaction, did the whole 'Tasks' thing just not happen today? | 05:04 |
CIA-57 | webgui: Colin Kuskie master * r7034e2c / (10 files in 4 dirs): More END block cleanups. - http://bit.ly/dC7FjY | 05:08 |
@preaction | scrottie: 4 of us were moving The Game Crafter's production facilities onto a truck, Kristi was sick, Tavis was sick (can't verify those though) | 05:21 |
@scrottie | alright. I'll not be shy then. | 05:26 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Ping timeout: 248 seconds] | 05:30 |
+perlDreamer | Haarg, have you run prove with WEBGUI_TEST_DEBUG recently? | 05:36 |
+perlDreamer | the number of sessions and scratch sessions slowly creeps up | 05:36 |
@scrottie | hrm. test passing. not reproducing. looks like the user is still in the group even though I've removed them. grr. | 05:39 |
@scrottie | so I have to fix a bug to make my test fail so I can make my test pass. | 05:39 |
+perlDreamer | scrottie, would it help if I looked at your test? | 05:41 |
@scrottie | yeah, we'll intimidate it! if I were a test, I'd be scared of you too. | 05:41 |
+perlDreamer | paste away, dude | 05:41 |
@scrottie | I'm wondering if getMessagesPaginator isn't just caching the groups the user is in. let me try that right quick. | 05:43 |
* perlDreamer is afk for a bit, time to read to the kiddos | 05:45 |
@scrottie | SQL output shows it still trying to join on groupId. modifying the SQL and running it at the mysql shell while the test is control-z'd, it fails to join if the group is removed from the list of groups for the user. | 05:45 |
@scrottie | so if the list of the groups for the users is correct, the bug is reproduceable. | 05:45 |
@scrottie | slowass.net/~scott/tmp/Groups.t.txt | 05:46 |
@scrottie | according to the bug report and what I'm seeing in the SQL, this test should fail: | 05:47 |
@scrottie | is($messageList->[0]->getId, $messageId, '... getMessagesForUser able to get message with messageId matching the message sent'); | 05:47 |
@scrottie | $user->getGroupIdsRecursive agrees that the user was removed from the group, but getMessagesForUser, which calls that (indirectly) still lists them as being in it. | 05:48 |
@scrottie | and what's with the user winding up in groups '2' and '7'? | 05:50 |
@scrottie | ooh, ooops. botched that test line. | 05:50 |
@scrottie | missing an array deref. | 05:51 |
@scrottie | group->getAllUsers is correct, getGroupIdsRecursive has stale data. | 05:52 |
@scrottie | $userFred->session->stow->delete("gotGroupsForUser"); # there, that fixed the brokenness | 05:56 |
@scrottie | so that the brokenness works right. | 05:56 |
@scrottie | the actual fix is straight forward but I have to pack up here and take off so I need to do that tomorrow. | 05:57 |
CIA-57 | webgui: Scott Walters master * r78de99a / (34 files in 22 dirs): Merge branch 'master' of http://github.com/plainblack/webgui - http://bit.ly/aYfBLL | 06:01 |
@scrottie | I know this code has some cruft but I have to say, it makes me really, really happy to be able to read it and see what's going on. It's about a billion times better than some code I've worked on. | 06:01 |
@scrottie | dammit, I need to figure out if it's possible to suppress those merge messages in git. | 06:02 |
@scrottie | guess I could stash, pull, unstash, commit, push. | 06:03 |
+perlDreamer | 34 files? | 06:05 |
+perlDreamer | scrottie, what is that? | 06:06 |
@scrottie | committed a merge. *sigh* | 06:06 |
@scrottie | know how to fix that? | 06:06 |
+perlDreamer | yes, roll it back | 06:06 |
+perlDreamer | then cherry pick the one commit | 06:06 |
@scrottie | and, like I said, I need to learn how to not do that. | 06:06 |
@scrottie | okay. | 06:06 |
Haarg | git config branch.webgui-7.6.rebase true | 06:08 |
Haarg | for each branch | 06:08 |
Haarg | and git config --global branch.autosetuprebase remote | 06:09 |
Haarg | and it will automatically be set for every branch created in the future | 06:09 |
+perlDreamer | okay, scrottie, some more test feedback | 06:13 |
+perlDreamer | we can't use done_testing in the main branches | 06:13 |
+perlDreamer | Test::Harness 3 isn't required until WebGUI8, so you still have to count tests :( | 06:13 |
@scrottie | grrrr. cannot get it to not put a merge message in the log. | 06:14 |
@scrottie | every time I pull. I did a bunch rebase true things and it said it was replaying my changes and I --hard checked out a previous ref... | 06:14 |
+perlDreamer | you also should not need to clear the cache | 06:14 |
+perlDreamer | if that isn't happening automatically, then there's a bug somewhere | 06:14 |
@scrottie | perlDreamer, I did have to clear the test. that was the missing piece. and comments in User.pm state that it cashes. that could be considered a bug. | 06:14 |
@scrottie | right. I need to deal with this stuff tomorrow. someone who likes to wake up early and go to bed early is going to be annoyed with me. | 06:15 |
@scrottie | I'll add a new test for that for User... | 06:15 |
+perlDreamer | good night, and good luck :) | 06:15 |
@scrottie | and try to fix git now... but might fail or make it worse. | 06:16 |
@scrottie | thanks =) | 06:16 |
Haarg | scrottie, can you paste your .git/config file? | 06:23 |
@scrottie | Haarg, thanks, but later... gotta go! | 06:26 |
CIA-57 | webgui: Scott Walters master * r9fb7b23 / t/Inbox/Groups.t : Tests reproducing bug #11594, users removed from groups no longer able to see previous messages to that group - http://bit.ly/dxcqAp | 06:26 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 06:26 |
@scrottie | crud. I forgot, I have to fix the tests style. I'll do that in the morning too. sorry. | 06:26 |
CIA-57 | webgui: Colin Kuskie master * r7034e2c / (10 files in 4 dirs): More END block cleanups. (+599 more commits...) - http://bit.ly/dC7FjY | 06:30 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 260 seconds] | 06:32 |
+perlDreamer | 'night, all | 06:34 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 06:34 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:10 |
-!- kaare is now known as Guest57824 | 08:11 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 08:30 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:07 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:07 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 11:03 |
-!- kaare is now known as Guest78028 | 11:03 |
-!- SDuensin_ [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 11:08 |
-!- Netsplit *.net <-> *.split quits: Guest57824, SDuensin | 11:09 |
-!- SynQ [koen@ringbreak.dnd.utwente.nl] has joined #webgui | 13:58 |
-!- mode/#webgui [+v SynQ] by ChanServ | 13:58 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 14:09 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 14:59 |
-!- mducharme1 [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Ping timeout: 265 seconds] | 14:59 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 15:14 |
-!- SDuensin_ [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:17 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 15:18 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 15:34 |
-!- dionak_ [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 15:38 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Read error: Connection reset by peer] | 15:38 |
-!- dionak_ is now known as dionak | 15:38 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 15:42 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 15:57 |
-!- Guest78028 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 16:06 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 16:18 |
-!- SDuensin [~Scott@200.sub-70-214-90.myvzw.com] has joined #webgui | 16:24 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 16:25 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 16:36 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 17:07 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Ping timeout: 276 seconds] | 17:12 |
-!- mode/#webgui [+o frodwith_] by ChanServ | 17:35 |
-!- frodwith_ is now known as frodwith | 17:35 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 17:45 |
-!- mode/#webgui [+o tavisto] by ChanServ | 17:45 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:03 |
CIA-57 | webgui: Colin Kuskie master * r1770e39 / (13 files in 8 dirs): END block cleanups. - http://bit.ly/cVh5kM | 18:43 |
CIA-57 | webgui: Colin Kuskie master * r4eb013e / t/Inbox/Groups.t : Remove uncontrolled diagnostics, and done_testing. - http://bit.ly/cWOuNE | 18:43 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:43 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:44 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 18:46 |
-!- mode/#webgui [+v patspam] by ChanServ | 18:46 |
CIA-57 | webgui: Colin Kuskie master * r2c08b4e / (3 files in 3 dirs): Fix a bug in getLineageSql, where it would return the empty string. This could cause downstream problems. Fixes bug #11616 - http://bit.ly/9laYJq | 19:23 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rac3f734 / (3 files in 3 dirs): Fix a bug in getLineageSql, where it would return the empty string. This could cause downstream problems. Fixes bug #11616 - http://bit.ly/biXpOa | 19:24 |
+perlDreamer | that was a particularly nasty bug in getLineageSql | 19:30 |
-!- SDuensin [~Scott@200.sub-70-214-90.myvzw.com] has quit [Ping timeout: 276 seconds] | 20:09 |
-!- SDuensin [~Scott@95.sub-72-107-248.myvzw.com] has joined #webgui | 20:12 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 20:14 |
-!- mode/#webgui [+o scrottie] by ChanServ | 20:14 |
+perlDreamer | morning, scrottie | 20:19 |
@scrottie | morning, perlDreamer | 20:19 |
+perlDreamer | patspam, preaction, the addFooter/addText/addHtml plan is not going to work. | 21:09 |
+patspam | oh noes! | 21:09 |
+perlDreamer | well, not without potential breakage | 21:09 |
+perlDreamer | from a core perspective, it should be fine | 21:09 |
+perlDreamer | let me talk through what I think the problem is | 21:09 |
+perlDreamer | Mail::Send has 3 main way to add parts | 21:10 |
+perlDreamer | addText, addHtml and addAttachment | 21:10 |
+patspam | (I'll backlog in 30mins - just heading out the door) | 21:10 |
+perlDreamer | addAttachment can add ANY kind of attachment, including text and HTML | 21:10 |
+perlDreamer | that makes addFooter's stated job difficult at best | 21:10 |
+perlDreamer | the last attachment may be part of a message from addText/Html, or it may be an attachment added via addAttachment | 21:11 |
+perlDreamer | in fact, there's no way to look at a part of a message and see where it came from | 21:11 |
+perlDreamer | so my next idea was to say, always append the footer to the first part of the email message | 21:12 |
+perlDreamer | that's the one that outlook is guaranteed to display | 21:12 |
+perlDreamer | but, if it was an HTML message, it's a complete HTML page, so you have to parse the message and append it to the bottom of the HTML | 21:13 |
+perlDreamer | so then I thought, what if we didn't generate the message as it's built, but work more like FormBuilder, and build an object that will serialize itself when being queued, or sent? | 21:14 |
+perlDreamer | but attachments again balk you here, since there's no guarantee that the file-system based attachments will still exist later | 21:15 |
+perlDreamer | basically, to fix this bug we're going to have to accept some breakage | 21:15 |
+perlDreamer | of existing non-core code, or at least the risk of it. | 21:16 |
@preaction | i think that's acceptable | 21:18 |
+perlDreamer | are you okay with the "append to first part" approach? I think it's going to be better than the late-serialize idea | 21:19 |
@preaction | sure, we can try it and see if anybody complains | 21:25 |
* perlDreamer will start coding in that direction, and wait for patspam to weigh in with final thoughts | 22:11 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Ping timeout: 260 seconds] | 22:18 |
-!- kimd [~spunky@p549F5436.dip.t-dialin.net] has joined #webgui | 22:26 |
kimd | perlDreamer, I have been thinking about how to handle photos that have no image file attached. | 22:27 |
+perlDreamer | okay, what have you come up with | 22:27 |
kimd | I think we need at least some kind of generic image for thumbnail creation. | 22:27 |
kimd | So many methods just expect an image to be present. | 22:28 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 22:28 |
kimd | Of course we could add testing code and error handling to each of them. | 22:28 |
kimd | But what would be the value? | 22:28 |
kimd | What is it that you do not like about using a generic image? | 22:28 |
+perlDreamer | having dozens of copies of some default image in the uploads area | 22:29 |
kimd | It could be a 1x1 white or transparent png. Does not really matter. | 22:29 |
kimd | And it would be replaced as soon as the user decides to upload an image. | 22:29 |
kimd | Photo assets without an image file attached do not make much sense anyhow. | 22:30 |
+perlDreamer | when an image is uploaded, it will create a new revision, with its own storage location | 22:30 |
kimd | Ok. That is a point. | 22:30 |
+perlDreamer | how about returning the user back to the edit screen if there's no image file? | 22:30 |
kimd | Equally possible. The form could report an error and reject submittal. | 22:31 |
kimd | In addition, we could check whether we really have an image. | 22:31 |
+perlDreamer | I think the Form::Image plugin may do that | 22:31 |
kimd | Ok. I will check that. | 22:32 |
kimd | A question on Form controls. In the code for the Photo asset, a function name WebGUI::Form::file is used. I cannot find that function in WebGUI::Form, however. Where is it defined? | 22:37 |
kimd | Ah. Everything is explained in the POD for WebGUI::Form. Never mind. | 22:38 |
+perlDreamer | kimd, if it uses Form::File, you should check to see that it got an image | 22:39 |
+perlDreamer | WebGUI::Storage has an isImage method for checking that | 22:39 |
kimd | Found it. | 22:41 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:43 |
+perlDreamer | MIME::Entity is not PBP compatible | 22:52 |
kimd | Suggested error message: "You need to select an image to upload." | 22:52 |
kimd | Ok? | 22:52 |
+perlDreamer | $i18n->get('You need to select an image to uploads'); | 22:53 |
+perlDreamer | yes :) | 22:53 |
kimd | Sure. | 22:53 |
Haarg | perlDreamer, question 252138777c301ea4e26f360e29bc0177a5adca4d | 22:56 |
Haarg | s/question/question about/ | 22:56 |
+perlDreamer | yup | 22:56 |
+perlDreamer | resolutions are strings, not numbers | 22:56 |
+perlDreamer | 800x600 | 22:56 |
+perlDreamer | 320x480 | 22:56 |
+perlDreamer | and so on | 22:56 |
Haarg | but then you get 1024, 320, 640, 800 and such | 22:57 |
* perlDreamer got tired of seeing 800x600 is not numeric in sort | 22:57 |
+perlDreamer | in the logs | 22:57 |
Haarg | ah, so it spits out warnings | 22:57 |
+perlDreamer | yes | 22:57 |
Haarg | are there other filenames aside from the resolution filenames? | 22:58 |
* perlDreamer doesn't remember | 22:58 |
Haarg | it should probably be done with a split and two part sort | 22:58 |
+perlDreamer | yeah, that would be better | 22:58 |
Haarg | i'll leave it as cmp for now though | 22:59 |
+perlDreamer | let me guess, now 1024 is showing up below 800 in the list of resolutions? | 22:59 |
Haarg | working on another master->WebGUI8 merge | 22:59 |
Haarg | just something i noticed when working on the merge | 22:59 |
Haarg | since sort { $a cmp $b } is the same as just sort | 22:59 |
+patspam | perlDreamer: sounds good re: mail footer | 23:03 |
+perlDreamer | cool | 23:03 |
+patspam | I'll do a test for you to see which mail clients care if you just append the extra html after </html> | 23:03 |
+perlDreamer | that'll make things easier | 23:04 |
+patspam | Plack::Middleware::Debug just does: $chunk =~ s!(?=</body>)!$content!i; | 23:04 |
+patspam | by necessity because it doesn't know if it's got a chunk of html or the whole doc | 23:05 |
+perlDreamer | how many email clients do you have access to? | 23:05 |
+patspam | but I'm yet to see it fail | 23:05 |
+patspam | heh and if it's good enough for miyagawa it's good enough for me ;) | 23:05 |
+patspam | I have: thunderbird, gmail, outlook 2003 | 23:06 |
-!- SDuensin [~Scott@95.sub-72-107-248.myvzw.com] has quit [Quit: Leaving] | 23:06 |
+perlDreamer | preaction has iMail | 23:06 |
+perlDreamer | I'll rally the troops on the dev channel | 23:06 |
+patspam | I reckon the code should try using the body tag regex, and if that doesn't match just append it | 23:07 |
+perlDreamer | body tag regex? | 23:07 |
+patspam | s!(?=</body>)!$content!i; | 23:07 |
+patspam | if the message doesn't have that it's invalid html, so "not your problem" | 23:07 |
+perlDreamer | there's an easier way | 23:08 |
+perlDreamer | the parts are tagged by addText, addHtml | 23:08 |
+perlDreamer | and everything coming from addHtml always has a closing body tag | 23:08 |
+perlDreamer | if they use addHtmlRaw, and omit a closing body tag, that's their own fault for writing bad HTML | 23:08 |
+patspam | yep, I agree | 23:09 |
+perlDreamer | I did check the core first before making that grand pronouncement, though ;) | 23:09 |
+patspam | heh | 23:09 |
+patspam | so no need to test mail clients for what they do given "<html>..</html>$blah" | 23:10 |
+perlDreamer | oh no | 23:10 |
+perlDreamer | uh, yeah | 23:10 |
+perlDreamer | sorry, Kathy's home from school today and my attention is divided | 23:10 |
+patspam | http://boxcar.io++ | 23:10 |
+patspam | iphone push notifications - means we can ditch our nagios sms alerts | 23:11 |
ckotil | nice | 23:14 |
-!- mducharme-work [~nothing@4-121-188-206.rev.knet.ca] has joined #webgui | 23:23 |
--- Day changed Wed Jun 09 2010 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 00:01 |
-!- khenn [~frank@adsl-71-150-248-232.dsl.mdsnwi.sbcglobal.net] has joined #webgui | 00:04 |
-!- mode/#webgui [+o khenn] by ChanServ | 00:04 |
--- Log closed Wed Jun 09 00:07:24 2010 |
--- Log opened Wed Jun 09 00:15:59 2010 |
kimd | Cool. I am more or less done with the boring RFEs. My next hacks will be on ajaxifying the gallery album edit view. Already looking forward to that. | 00:15 |
kimd | Enjoy hacking. I will go to bed. | 00:16 |
@scrottie | night kimd | 00:22 |
-!- kimd [~spunky@p549F5436.dip.t-dialin.net] has quit [Quit: Ex-Chat] | 00:24 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 00:43 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 00:47 |
+perlDreamer | well, it seems we have an in-lined footer working | 00:53 |
+patspam | perlDreamer++ | 00:58 |
+perlDreamer | that's by eyeballing the output | 00:59 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 01:30 |
@scrottie | hrm. my login on webgui.org stopped working. trying to do password recovery, it says "There is no email registered for this account. Password recovery via email is not possible." | 01:35 |
@scrottie | trying to make a new account, it confirms that scottwalters is already used. | 01:35 |
@scrottie | who do I talk to to have the thing kicked? | 01:35 |
+perlDreamer | let me see if I can help you out | 01:35 |
@scrottie | creating a ticket (in now; thanks), for "What's the bug in?", does git bleed == WebGUI Beta? that's kinda suspect. | 01:40 |
+perlDreamer | master == WebGUI Beta | 01:41 |
+perlDreamer | we don't file tickets for WebGUI8 yet | 01:42 |
@scrottie | er, this is master... something not far what has been released for 7. | 01:44 |
+perlDreamer | what's the bug? | 01:44 |
@scrottie | after removing a user from a group with WG:Group->deleteUsers(), $thatUser->getGroups() still lists them as being in the group. the cache key getGroupsForUser isn't being cleared in Group::clearCaches. | 01:46 |
@scrottie | WG::Group | 01:46 |
+perlDreamer | how do you know that bug hasn't been release yet? | 01:46 |
@scrottie | hmm? I don't know. | 01:46 |
@scrottie | I could check out tagged release versions. | 01:47 |
@scrottie | but first I thought I'd ask more about the procedure. | 01:47 |
@scrottie | previously, I was told, approximately, that bug fixes should have tickets. | 01:47 |
+perlDreamer | yes | 01:47 |
@scrottie | cool. details on that? | 01:47 |
+perlDreamer | it's best to try and narrow down when the bug was introduced | 01:48 |
@preaction | it's a judgement call, really. don't worry too much about obscure API bugs, but anything from the web interface should be documented | 01:48 |
@scrottie | well, I was given two days to fix that bug and I hit a bug in my effort to fix that bug, so my instinct is to fudge in the name of meeting my deadline. | 01:49 |
@scrottie | so, don't bother with tickets for obscure API calls, but if I do create a ticket, document which versions the bug effects? | 01:50 |
+perlDreamer | there isn't any unreleased code in Group.pm | 01:51 |
+perlDreamer | so it has to be in a released version | 01:51 |
@scrottie | okay, so verify that it effects at least one release version? | 01:51 |
@scrottie | preaction, can you comment on the policies here? | 01:52 |
@preaction | don't care about which versions it affects, just which version it'll be fixed in. if it affects someone, they'll find it (or we'll find it for them) | 01:53 |
@scrottie | okay. I'm going to have to continue asking on a case by case basis until I discover the pattern. | 01:53 |
@preaction | but yes, you might want to verify on a demo site: http://beta.webgui.org (for 7.9) or http://demo.webgui.org (for stable, 7.8) | 01:53 |
@scrottie | I should take and spend another day with the Wiki some time. | 01:53 |
@scrottie | well, it's API, not UI | 01:54 |
@scrottie | so I would be ssh'ing in. | 01:54 |
@preaction | ah, then don't worry about it. time better spent writing regression tests or moving on | 01:54 |
@scrottie | cool. | 01:55 |
@scrottie | yeah, this is already a tangent to what I was doing. | 01:55 |
@scrottie | ahem. I assume fixes get backported from WebGUI8->WebGUI7 and forward ported from WebGUI7->WebGUI8. or is there a procrastinated day of reconcilliation? | 01:56 |
Haarg | procrastinated | 01:56 |
Haarg | we don't do many bug fixes in WebGUI8 at this point aside from bug fixes to the WebGUI 8 stuff | 01:57 |
Haarg | i was just working on a merge of 7 into 8 but got tired of it | 01:57 |
+perlDreamer | time to take the kids to piano, back on later tonight | 01:59 |
@scrottie | Haarg: understandable. | 01:59 |
@scrottie | perlDreamer: have fun | 01:59 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 01:59 |
Haarg | i did one merge already, so it's not as bad as it could be, but it's probably time to do another. | 02:00 |
CIA-57 | webgui: Scott Walters master * r867095d / (lib/WebGUI/Group.pm t/Group.t): | 02:08 |
CIA-57 | webgui: A user removed from a group with deleteUsers() will still appear to be in that | 02:08 |
CIA-57 | webgui: group according to Inbox.pm, User::getGroupIdsRecursive() and User::getGroups(). | 02:08 |
CIA-57 | webgui: Groups.pm wasn't clearing the cache key "getGroupsForUser" in clearCaches(). | 02:08 |
CIA-57 | webgui: Tests and fix. - http://bit.ly/9RyuFA | 02:08 |
CIA-57 | webgui: Scott Walters master * r7ef3c7e / t/Inbox/Groups.t : Less diagnostic output and don't manually clear the group membership cache. - http://bit.ly/cVN2xV | 02:08 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 265 seconds] | 02:44 |
Haarg | patspam, what else needs to be done for pseudorequest? | 02:49 |
+patspam | hey haarg | 02:50 |
+patspam | pseudorequest is going away | 02:50 |
Haarg | ah :) sounds like a good idea | 02:51 |
+patspam | and I think all instances of WebGUI::Test::getPage() should be replaced with something like Plack::Test::test_psgi() where you pass in a callback to test the response | 02:51 |
+patspam | that way it will work for streaming responses too | 02:51 |
+patspam | and we'll be able to do the PLACK_SERVER thing to test under any server | 02:52 |
+patspam | but pseudorequest will be very valuable for one thing | 02:52 |
+patspam | colin's already done the leg work of mapping out and documenting a lot of the Apache2:: methods | 02:52 |
+patspam | we can use that as our cheat-sheet when finishing the job of ripping out WebGUI::Session::Http | 02:53 |
+patspam | and the mapping to WebGUI::Session::Request/Response which is mostly just Plack::Request/Response | 02:53 |
* patspam heads out to see a gig | 02:55 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 02:58 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 03:09 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 245 seconds] | 03:28 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 03:51 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 04:10 |
-!- perlDreamer [~colink@pool-71-182-84-164.ptldor.fios.verizon.net] has joined #webgui | 04:15 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 04:15 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 04:15 |
-!- mode/#webgui [+o scrottie] by ChanServ | 04:23 |
+perlDreamer | scrottie, I tracked down the Group caching bug. | 04:24 |
@scrottie | I know, I did too | 04:24 |
@scrottie | I told you what it was already, when you asked me what was going on =P | 04:25 |
+perlDreamer | yes, but when I looked for the variable that you named, it wasn't in the code | 04:25 |
@scrottie | not a variable, a cache key. | 04:25 |
+perlDreamer | it wasn't there either | 04:25 |
+perlDreamer | ack never lies | 04:25 |
@scrottie | http://github.com/plainblack/webgui/commit/867095d8117eba16debe5917e0577f17e00f6f57 | 04:27 |
@scrottie | that change to WebGUI::Group fixes the test failure in the test I added to t/Group.t | 04:27 |
@scrottie | and also changes the t/Inbox/Groups.t I put together the other night so that it fails in the way expected and consistent with the bug | 04:28 |
@scrottie | I've got revised SQL for that but I wanted to take a nap first before committing and look at the test outputs again and so on. I've finished the nap portion of that plan. | 04:28 |
+perlDreamer | excellent! | 04:29 |
+perlDreamer | a couple more notes | 04:30 |
@scrottie | sure! | 04:30 |
+perlDreamer | we release right out of the master repository on Tuesday | 04:30 |
+perlDreamer | which is today | 04:30 |
@scrottie | ack! | 04:30 |
+perlDreamer | and 1 requirement for release is that all tests pass | 04:30 |
+perlDreamer | so, for future reference, please don't commit tests that expose bugs unless fixes are shortly following, on Tuesdays ;) | 04:30 |
@scrottie | haha, okay | 04:30 |
+perlDreamer | the good news is that we alternate releases | 04:31 |
+perlDreamer | one tuesday is stable | 04:31 |
+perlDreamer | the following tuesday is beta | 04:31 |
+perlDreamer | so you got a week to straighten things out! | 04:31 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r2d3b14b / docs/changelog/7.x.x.txt : Fixed #11613: Thingy: If next action after add is to add more things, previous data remains - http://bit.ly/azEZGJ | 04:37 |
CIA-57 | webgui: khenn webgui-7.8 * rc4cc5c2 / lib/WebGUI/Asset/Wobject/Thingy.pm : Not enough arguments to searchOther - http://bit.ly/9Z2TE8 | 04:37 |
@scrottie | waiting for the 2nd prove to run so I can `kompare` them. wee! | 04:42 |
@scrottie | I think some of these warnings/failures are 5.12 induced. I should fix those. | 04:42 |
+perlDreamer | the canonical run of WebGUI (one that really counts) has to pass on the WRE | 04:42 |
+perlDreamer | with 5.8 | 04:43 |
+perlDreamer | no done_testing | 04:43 |
+perlDreamer | no say | 04:43 |
+perlDreamer | no ~~ | 04:43 |
* perlDreamer starts to whimper, "ITS NOT FAIR" | 04:43 |
@scrottie | and no grammar-plugins? awww =( | 04:43 |
+perlDreamer | all the rest of the world gets to use 5.10 | 04:43 |
@preaction | and yet we still have to test on IE6 | 04:44 |
+perlDreamer | but we'll be free after WebGUI8, yes? | 04:44 |
+perlDreamer | WebGUI8 == perl 5.10, Moose, CHI, plack and >=IE7 | 04:44 |
@preaction | probably not. | 04:44 |
+perlDreamer | what!!?? | 04:44 |
+perlDreamer | but you said so | 04:45 |
@preaction | that was before i remembered that plainblack's largest client is IE6-only | 04:45 |
+perlDreamer | they can upgrade | 04:45 |
+perlDreamer | they can run IE10 in IE6 compatibility mode | 04:45 |
@preaction | yes, they've been "going to upgrade" for years now | 04:46 |
@scrottie | you know, we could run khtml2png server-side and generate, as output, a gif image map and present that. | 04:46 |
@preaction | one of them even brought it up to The Big Boss in a huge pep-rally / meeting that made the news | 04:46 |
@scrottie | I guess people couldn't actually fill in forms but oh well. | 04:47 |
@preaction | http://www.downloadsquad.com/2009/07/14/us-state-department-employees-ask-hillary-clinton-for-firefox/ | 04:48 |
@scrottie | so this helpdesk rework I'm supposed to be doing... the AJAX has to go in IE6? | 04:49 |
@preaction | that's even after the WUC '06 where I was (again) talking to Palamara about it (or rather, Palamara was ranting about it) | 04:49 |
@preaction | nope, that's the beauty of the HelpDesk, it's not Core WebGUI | 04:49 |
@scrottie | ahh. fweeew. | 04:49 |
+perlDreamer | preaction, not to disagree | 04:49 |
+perlDreamer | but if our largest customer can't post tickets, it wouldn't be good | 04:50 |
+perlDreamer | it would reduce our workload initially | 04:50 |
+perlDreamer | but I suspect that would be a self-correcting problem | 04:50 |
@preaction | quelle horreur. they can spend their own time and money to get it fixed for their platform | 04:50 |
@scrottie | I love webapps that gracefully decode for browsers without JS or with JS disabled. | 04:51 |
@scrottie | degrade. not decode. | 04:51 |
+perlDreamer | WebGUI doesn't degrade, it breaks | 04:51 |
@preaction | i like them too, i just hate making them because it takes three times as long | 04:51 |
@scrottie | Can't locate object method "new" via package "CODE" (perhaps you forgot to load "CODE"?) at /home/scott/plainblack/WebGUI7/webgui/t/lib/WebGUI/Test.pm line 823. ... that's annoying. | 04:54 |
+perlDreamer | where's that scrottie | 04:54 |
@scrottie | not sure. one of the tests. | 04:55 |
+perlDreamer | I've got another half hour at piano lessons, I'll run the test suite on master and see what's up | 04:58 |
@scrottie | looking into it myself too... | 05:00 |
@scrottie | least I can do is get a good stack trace. | 05:00 |
+perlDreamer | I ran it several times last night while doing END block cleanups | 05:00 |
+perlDreamer | and I thought everything passed.... | 05:01 |
+perlDreamer | but I've been wrong too many times not to double check | 05:01 |
@scrottie | http://gist.github.com/430939 | 05:02 |
@scrottie | should I push my changes anyway and assume that my changes are unrelated? | 05:04 |
+perlDreamer | yes | 05:05 |
+perlDreamer | Haarg: pushing a code ref into addToCleanup doesn't work like CODE => sub { #something }, ? | 05:07 |
+perlDreamer | analogous to SQL? | 05:07 |
CIA-57 | webgui: Colin Kuskie master * rec4c31c / t/Config.t : Fix some cleanup code. - http://bit.ly/buomOt | 05:09 |
+perlDreamer | nice work all around scrottie | 05:09 |
+perlDreamer | just needs to be backported to the 7.8 branch | 05:09 |
@scrottie | shucks... | 05:09 |
@scrottie | haha | 05:09 |
* perlDreamer puts on his Code Cop hat | 05:09 |
+perlDreamer | it's not my favorite job | 05:10 |
CIA-57 | webgui: Scott Walters master * r07657e5 / lib/WebGUI/Inbox.pm : | 05:14 |
CIA-57 | webgui: Reworked active messages SQL. Fixes #11594. Don't try to relate | 05:14 |
CIA-57 | webgui: to groups that the user may not be a part of any longer. - http://bit.ly/8XHcv1 | 05:14 |
CIA-57 | webgui: Scott Walters master * r647dc6a / t/Inbox/Groups.t : Correct number of tests. - http://bit.ly/abzkRg | 05:14 |
@scrottie | so many questions... is this the sort of thing that goes into changelogs? | 05:14 |
+perlDreamer | The fix for Frank's bug, definitely | 05:15 |
+perlDreamer | the fix for the API... I say yes | 05:15 |
+perlDreamer | preaction may say no | 05:15 |
@preaction | doesn't matter to me either way really | 05:15 |
+perlDreamer | a while ago, we decided to be very thorough about opening bugs to record EVERYTHING we do | 05:15 |
+perlDreamer | and it's kind of lagged (all around) | 05:15 |
+perlDreamer | but I try to encourage people to do that | 05:16 |
+perlDreamer | just so he have good records | 05:16 |
* perlDreamer thinks that getMechLogin needs to be moved into a WebGUI::Test::Mech utility class | 05:18 |
+perlDreamer | scrottie, there's a potential, hidden bug in Frank's suggested SQL | 05:28 |
+perlDreamer | it doesn't return things in the right order | 05:28 |
+perlDreamer | and there's no tests for that | 05:28 |
+perlDreamer | time to take kids home | 05:29 |
+perlDreamer | back in 60 | 05:29 |
-!- perlDreamer [~colink@pool-71-182-84-164.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 05:29 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 05:41 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 264 seconds] | 05:45 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 05:47 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 05:53 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 05:58 |
-!- mode/#webgui [+o scrottie] by ChanServ | 05:59 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 06:07 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 06:30 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 06:34 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 06:34 |
CIA-57 | webgui: Scott Walters webgui-7.8 * r6c3bd64 / (lib/WebGUI/Group.pm t/Group.t): | 06:35 |
CIA-57 | webgui: A user removed from a group with deleteUsers() will still appear to be in that | 06:35 |
CIA-57 | webgui: group according to Inbox.pm, User::getGroupIdsRecursive() and User::getGroups(). | 06:35 |
CIA-57 | webgui: Groups.pm wasn't clearing the cache key "getGroupsForUser" in clearCaches(). | 06:35 |
CIA-57 | webgui: Tests and fix. - http://bit.ly/9dzrUv | 06:35 |
@scrottie | whoah, did I push that? | 06:38 |
@scrottie | no. | 06:38 |
+perlDreamer | nope | 06:40 |
+perlDreamer | I did | 06:40 |
@scrottie | thanks, I guess =P | 06:40 |
@scrottie | ORDER BY messageStatus='pending' DESC, dateStamp DESC ... | 06:41 |
@scrottie | should that messageStatus='pending' maybe be part of the WHERE clause? | 06:41 |
+perlDreamer | I think so | 06:42 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r819c8ed / docs/create.sql : Preparing for 7.8.21 release. - http://bit.ly/c6AYfY | 06:46 |
+perlDreamer | scrottie, yet another undocumented git policy thing | 06:48 |
+perlDreamer | during release, please don't make commits into the branch that is being released | 06:48 |
+perlDreamer | it should only be about 1 hour or so | 06:48 |
@scrottie | that's just common sense. | 06:49 |
* scrottie pushes the Yahoo! Toolbar at the last second. | 06:49 |
@scrottie | it's FREE! | 06:49 |
+perlDreamer | git revert HEAD | 06:49 |
@scrottie | haha, if messageStatus isn't in the SORT, it has to be in HAVING. | 06:54 |
@scrottie | 754b9c7c (Colin Kuskie 2009-04-16 23:17:55 +0000 404) $sortBy = q{messageStatus='pending' DESC, dateStamp DESC}; | 06:54 |
@scrottie | YOU did that =P | 06:54 |
@scrottie | that SQL is just a bit wonky. I don't think I'd better mess wit it just now. I think I'd need to read through all of this and write some better tests and experiment against real world data and actually look at the UI result and all of that. | 06:56 |
+perlDreamer | dude, git show 754b9c7c | 06:56 |
@scrottie | it's PROOF! you're part of the CONSPIRACY! | 06:59 |
@scrottie | seriously though, is Frank is still committing stuff like that? | 07:01 |
Haarg | i'm not seeing the problem with that sql | 07:01 |
@scrottie | Haarg, if it really wants the pending messages first, I guess it's okay, but it seems more likely that they'd want only the unread messages. | 07:01 |
Haarg | it's meant for the general inbox view if you don't apply any sorting to it | 07:02 |
Haarg | which shows them by date, but with pending stuff first | 07:02 |
+perlDreamer | yup | 07:03 |
Haarg | could stand to be documented better i suppose but it's definitely meant to work the way it does | 07:04 |
@scrottie | alright. | 07:05 |
+perlDreamer | why, oh why didn't I listed to Haarg about making all release tools wgd plugins? | 07:10 |
@scrottie | because Haarg comes on late in the day when we're all tired. | 07:13 |
-!- fokat [~lem@200.84.244.194] has joined #webgui | 07:24 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r8c4830f / (4 files in 4 dirs): Ready for 7.8.22 development cycle. - http://bit.ly/anHIWB | 07:25 |
+perlDreamer | okay, release is down | 07:26 |
+perlDreamer | done | 07:26 |
+perlDreamer | complete | 07:26 |
@scrottie | yay. | 07:26 |
+perlDreamer | maybe I'll try running the test suite before commit more cleanup code this time... | 07:26 |
@scrottie | don't sweat the small stuff. | 07:29 |
@scrottie | it is possible to be _too_ careful. | 07:29 |
+perlDreamer | yes, but the tests are there to help me not make mistakes like that | 07:31 |
+perlDreamer | and as Code Cop, I regularly chastise people for not running the tests | 07:31 |
+perlDreamer | It's hard to make the Code Cop badge shine when it's covered with grimy hypocrisy | 07:32 |
@scrottie | beats the heck out of a weekly smoke. | 07:32 |
+perlDreamer | once I finish the END block cleanup, we can see what Test::Aggregate does for test times | 07:37 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 07:37 |
Haarg | perlDreamer, we probably need a little more than that | 07:38 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Client Quit] | 07:38 |
+perlDreamer | I wouldn't doubt it | 07:38 |
+perlDreamer | but it's the first big, known hurdle | 07:38 |
Haarg | like a my $g = Scope::Guard->new(sub { WebGUI::Test->cleanup }); at the top of each test | 07:38 |
+perlDreamer | find . -name '*.t' | xargs perl -ni -e 'print; print "What Haarg said" if /use WebGUI::Test/;' | 07:40 |
Haarg | i wish you could do that with just the use statement but i've searched around and it pretty much isn't possible | 07:41 |
Haarg | other than with a source filter | 07:41 |
+perlDreamer | it's just boilerplate that has to be added to each test? | 07:41 |
Haarg | or possibly an xs module that hasn't been created yet. | 07:41 |
Haarg | pretty much | 07:41 |
Haarg | we take care of it with the END block in WebGUI::Test but that wouldn't work with something like Test::Aggregate | 07:42 |
+perlDreamer | yeah | 07:42 |
+perlDreamer | oh... | 07:42 |
+perlDreamer | maybe we can do it | 07:43 |
+perlDreamer | but in WebGUI8 | 07:43 |
+perlDreamer | if (and this is a big if) every test used done_testing | 07:43 |
Haarg | the other thing is any places we use Test::MockObject unsafely | 07:43 |
+perlDreamer | we could make WebGUI::Test to be a Test::Builder, and then grab done_testing | 07:43 |
Haarg | it already is a Test::Builder | 07:43 |
+perlDreamer | it won't affect the Test::Class tests, since the cleanup at the end of every sub | 07:44 |
+perlDreamer | and with every script test calling done_testing, we'd have a procedural (non-END block) way of ending every test | 07:45 |
+perlDreamer | no, it's even easier | 07:45 |
+perlDreamer | Test::Aggregate wraps every script as a module | 07:45 |
+perlDreamer | so we could stick stuff into that module | 07:45 |
Haarg | ahh yeah it lets you define setup and teardown code | 07:46 |
+perlDreamer | but, before we even get there, we need to get those END blocks out of there | 07:47 |
Haarg | yes | 07:47 |
+perlDreamer | and I just broke some Inbox cleanup, somewhere, so I need to track it down and find it | 07:47 |
Haarg | doing something with done_testing wouldn't be good because the whole point of done_testing is that it doesn't get run if there is a failure of some kind | 07:47 |
-!- fokat [~lem@200.84.244.194] has quit [Ping timeout: 240 seconds] | 07:48 |
-!- lem_ [~lem@200.84.244.194] has joined #webgui | 07:48 |
@scrottie | hmm? more likely, I did. | 07:54 |
+perlDreamer | possibly, scrottie. but when you ran the suite it would have shown up | 07:55 |
+perlDreamer | Test::Aggregate also requires "no_plan" in all tests | 07:57 |
+perlDreamer | but that may have been before the advent of done_testing | 07:57 |
+perlDreamer | too much, too late, too old | 07:58 |
+perlDreamer | more fun tomorrow | 07:58 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 07:58 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 09:27 |
-!- kaare is now known as Guest99340 | 09:27 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 10:31 |
-!- mode/#webgui [+v bartjol] by ChanServ | 10:31 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 260 seconds] | 12:20 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 12:33 |
+bartjol | eeeh, scrottie, you ought to live in the netherlands, with your sleep/awake rhytm | 12:45 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 13:46 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Read error: Connection reset by peer] | 13:56 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has joined #webgui | 14:18 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has left #webgui [] | 14:18 |
-!- lem_ [~lem@200.84.244.194] has quit [Ping timeout: 240 seconds] | 14:48 |
CIA-57 | webgui: Graham Knop psgi * r883b145 / t/lib/WebGUI/Test.pm : some WebGUI::Test cleanups (+10 more commits...) - http://bit.ly/dcZyTZ | 15:18 |
CIA-57 | webgui: Graham Knop test-temp-config * rd8137c8 / (20 files in 11 dirs): use temp config file for tests - http://bit.ly/bbGY5n | 15:18 |
CIA-57 | webgui: Graham Knop test-mailserver * r0614383 / (4 files in 4 dirs): new separate module for smtp testing - http://bit.ly/bDl5DU | 15:19 |
CIA-57 | webgui: Graham Knop test-mockasset * ra3c38d3 / (t/Macro/PickLanguage.t t/lib/WebGUI/Test/MockAsset.pm): mock asset test package - http://bit.ly/aEIf0x | 15:20 |
CIA-57 | webgui: Graham Knop test-mockasset * r7f91291 / (t/Macro/PickLanguage.t t/lib/WebGUI/Test/MockAsset.pm): mock asset test package (+599 more commits...) - http://bit.ly/amWrts | 15:43 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 15:53 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 276 seconds] | 16:06 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 16:11 |
-!- Guest99340 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 17:12 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 17:24 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 17:42 |
-!- mode/#webgui [+v patspam] by ChanServ | 17:43 |
-!- preaction [~doug@207.200.236.230] has joined #webgui | 17:48 |
-!- mode/#webgui [+o preaction] by ChanServ | 17:48 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 17:49 |
-!- mode/#webgui [+o tavisto] by ChanServ | 17:49 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:00 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:00 |
+perlDreamer | khenn, regarding the thing.css file | 18:02 |
@khenn | yeah | 18:02 |
+perlDreamer | why can't things be overridden, using CSS? | 18:02 |
+perlDreamer | in the template? | 18:02 |
@khenn | it can be | 18:03 |
@khenn | however | 18:03 |
@khenn | the code still writes the css file to the page | 18:03 |
@khenn | no matter what you do | 18:03 |
@khenn | which prevents you from using filepump to lump all your stuff together | 18:03 |
@khenn | or compress it | 18:03 |
@khenn | etc | 18:03 |
-!- perlbot [simcop2387@isuckatdomains.net] has quit [Ping timeout: 260 seconds] | 18:18 |
Haarg | perlDreamer, http://bit.ly/bbGY5n http://bit.ly/bDl5DU http://bit.ly/amWrts three potential testing things | 18:19 |
Haarg | not in any of the real branches yet, thought i would get some feedback first | 18:21 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:23 |
-!- perlbot [simcop2387@isuckatdomains.net] has joined #webgui | 18:27 |
+perlDreamer | Haarg, is Package::Stash already a sub-requirement of anything in WebGUI? | 18:27 |
+perlDreamer | I guess it's just for testing, so probably doesn't matter | 18:27 |
Haarg | Class::MOP | 18:27 |
Haarg | it's really simple stuff and wouldn't need the module, but we are already using it so i figured i would go with something more readable. | 18:28 |
+perlDreamer | it all looks good to me | 18:31 |
+perlDreamer | it simplifies the config cleanup | 18:31 |
+perlDreamer | it moves the mail and mock asset code out into its own packages | 18:31 |
+perlDreamer | there's going to be some ripple out cleanup required of the tests | 18:31 |
Haarg | yeah | 18:32 |
Haarg | the mocking stuff needs to be applied to other tests | 18:32 |
Haarg | i just did the one to make sure it was working | 18:32 |
+perlDreamer | sure | 18:32 |
+SynQ | ohm | 18:35 |
+SynQ | Haarg, perlDreamer hi | 18:35 |
+SynQ | are you still using the WRE? | 18:35 |
-!- mode/#webgui [+o scrottie] by ChanServ | 18:35 |
+perlDreamer | What do you mean, SynQ? | 18:35 |
+SynQ | just as I say it | 18:35 |
+SynQ | are you using it | 18:35 |
Haarg | i'm not using it locally | 18:35 |
+SynQ | and if so, which version? | 18:35 |
+SynQ | since 0.9.3 is way old now | 18:36 |
+perlDreamer | I run some tests on 0.9.3, but I still do dev using a source install | 18:36 |
+SynQ | and 0.9.4 is not officially out | 18:36 |
Haarg | i'm using a source install but without apache | 18:37 |
+SynQ | ah | 18:37 |
@preaction | 0.9.4 can't be released, it doesn't compile on OS X | 18:37 |
+SynQ | preaction: you are right | 18:37 |
@preaction | though I haven't tested that in about 6 months now, so maybe somebody fixed it. it was only Class::MOP I was having trouble with | 18:38 |
+SynQ | ah | 18:38 |
+SynQ | if we drop Class::MOP we could release 0.9.4? | 18:38 |
@preaction | can't drop Class::MOP, Config::JSON depends on Moose now | 18:39 |
+SynQ | ah | 18:39 |
+SynQ | so we are basically in hell :P | 18:39 |
@preaction | yep. that's why i've been discussing dropping the WRE altogether in favor of platform-specific packages (.deb, .rpm, macports, etc...) | 18:40 |
+SynQ | ok | 18:40 |
+SynQ | I am for it | 18:40 |
+SynQ | but then you need a 'testing farm' that consists of all those platforms to test WRE? | 18:40 |
+SynQ | or has that allready been accounted for? | 18:40 |
@preaction | we have a system, the old WRE build system, but nobody has or will have time to set it up properly | 18:41 |
+SynQ | ah | 18:42 |
+SynQ | so there is this: http://packages.debian.org/squeeze/webgui | 18:42 |
+SynQ | and this: http://packages.ubuntu.com/hu/lucid/webgui | 18:42 |
@preaction | not good enough. they're always too far behind | 18:42 |
+SynQ | ok | 18:42 |
+SynQ | but they are a start | 18:43 |
+SynQ | it's not like starting from ground zero | 18:43 |
@preaction | most likely we'd need to set up our own apt repos for the *.deb folk, and a yum repo for the *.rpm folk | 18:43 |
+SynQ | agreed | 18:43 |
+SynQ | to complement the existing debian and rpm bases allready available | 18:44 |
@preaction | right. they'd pull from us | 18:44 |
+SynQ | what can be done to do away with mod_perl in the mean time? | 18:44 |
@preaction | nothing. 8 is doing that already | 18:45 |
+SynQ | ah | 18:46 |
+SynQ | is 8 due before or after september 2010? | 18:46 |
Haarg | after | 18:46 |
@preaction | after | 18:46 |
+SynQ | ah | 18:46 |
+SynQ | I'd say we focus on replacing the WRE for WebGUI 8 | 18:47 |
+SynQ | not for 7.x | 18:47 |
@preaction | the WRE will have one final release to go with the 7.9 stable release | 18:47 |
+SynQ | if I can find a volonteer to fix that Class::MOP thing on mac | 18:47 |
+SynQ | I will put in the effort to get the current head up to par with mysql versions and such | 18:48 |
+SynQ | so there can be a WRE 0.9.4 before the WUC | 18:48 |
Haarg | the Class::MOP thing is a 64-bit problem of some kind. i should try compiling the wre on this machine. | 18:48 |
+SynQ | which I won't be able to attend this year since I have to be around Tessa at that time to help carry stuff and dry feet and the like | 18:49 |
+SynQ | I say we skip 64 bit compiling of the WRE all together | 18:49 |
Haarg | that's the plan | 18:49 |
+SynQ | if you need 64 bit now, do a source install | 18:49 |
Haarg | but it can still cause problems on mac on a 64-bit machine | 18:49 |
+SynQ | hmm | 18:49 |
Haarg | if i understood correctly, the issue preaction was having was due to doing a 32-bit build on 64-bit os x | 18:50 |
@preaction | yes | 18:50 |
+SynQ | ah | 18:50 |
+SynQ | I believe my macbook pro is also 64 bits os x | 18:50 |
+SynQ | so that could make sense | 18:51 |
@preaction | i completely redid the build script, so i might as well commit that | 18:51 |
+SynQ | since I also didn't get it to compile | 18:51 |
+SynQ | you should | 18:51 |
+SynQ | please | 18:51 |
Haarg | this machine is 32 bit so i should try building it here | 18:51 |
+SynQ | do so right now :) | 18:51 |
@preaction | now it actually listens to CFLAGS, CCFLAGS, LDFLAGS, etc... | 18:51 |
+perlDreamer | what, no SynQ at the WUC? | 18:51 |
+SynQ | Tessa is pregnant again | 18:52 |
+SynQ | due in november | 18:52 |
+SynQ | so at WUC time I have to be at home | 18:52 |
+perlDreamer | You have a wise choice in priorities | 18:52 |
+SynQ | since we allready have Emma and she needs to be carried around and such | 18:52 |
+SynQ | besides, this is a WUC for an intermittent WebGUI version anyway ;) | 18:53 |
+SynQ | next year the WUC will be WebGUI 8 and that I will be able to attend for sure | 18:53 |
+SynQ | and Bart will be coming over | 18:53 |
+perlDreamer | I'll make sure he drinks enough to cover you | 18:53 |
+SynQ | good idea | 18:53 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 18:53 |
+SynQ | ok | 18:54 |
+SynQ | Haarg: can you try and compile the git head version of the WRE on your 32bit mac after preaction submits his changes? | 18:55 |
+SynQ | please :) | 18:55 |
+SynQ | then I'll have a go at updating all the prereqs over the weekend | 18:56 |
CIA-57 | wrebuild: Doug Bell master * r4328973 / (16 files in 5 dirs): completely redone build.sh and updated sources - http://bit.ly/97d43X | 18:56 |
+SynQ | preaction: how up to date are the prereqs now? | 18:56 |
+SynQ | in other words: how long ago did you work on it? | 18:56 |
@preaction | January probably | 18:56 |
+SynQ | ok | 18:57 |
+perlDreamer | missing CHI | 18:57 |
+SynQ | so that probably needs some work | 18:57 |
+perlDreamer | and some others | 18:57 |
+SynQ | if I'm right I have some time this weekend | 18:57 |
+SynQ | perlDreamer: are you available this weekend? | 18:58 |
+perlDreamer | I'll be around this weekend. | 18:58 |
+SynQ | nice :) | 18:58 |
+SynQ | perhaps we can put some joint effort to it | 18:58 |
+SynQ | and release a 0.9.4 before the 4th of july | 18:59 |
+SynQ | or on :) | 18:59 |
+perlDreamer | If I have to log into a server, and the default editor is pico | 19:11 |
+perlDreamer | you're going to be publicly ridiculed | 19:12 |
+perlDreamer | you have all been notified of the consequences | 19:12 |
-!- perlbot [simcop2387@isuckatdomains.net] has quit [Ping timeout: 264 seconds] | 19:13 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 19:21 |
+perlDreamer | patspam++ for wgd mail | 19:22 |
+patspam | yeah I like it too! | 19:22 |
+patspam | my fav at the moment is: echo boing | wgd mail ...@patspam.com | 19:24 |
+patspam | thanks to boxcar that goes boing on my iphone via a push notification | 19:24 |
+perlDreamer | how is a push notification different from SMS? | 19:24 |
+patspam | it works when you have wifi and no mobile coverage | 19:25 |
+perlDreamer | that happens? | 19:25 |
+patspam | yeah | 19:25 |
+patspam | every day at home for me at the moment | 19:25 |
+perlDreamer | no way! | 19:25 |
+patspam | bloody t-mobile reception is non-existent in my building | 19:25 |
+patspam | so now I get my nagios notifications via wifi at home, and via 3g on the road | 19:26 |
+patspam | (and push notifications are free) | 19:26 |
+perlDreamer | that's good, too | 19:26 |
-!- perlbot [simcop2387@isuckatdomains.net] has joined #webgui | 19:26 |
+patspam | yeah, I mean, it's not like sms is expensive, it's just annoying to have to keep a sms gateway account topped up | 19:27 |
+patspam | and actually | 19:27 |
+patspam | the provider we're using for one of our clusters doesn't make it through the t-mobile network | 19:27 |
+patspam | could never figure out why | 19:27 |
+patspam | I blame the dutch | 19:27 |
+perlDreamer | speaking of dutch, SynQ's not coming to the WUC this year | 19:28 |
+patspam | yeah I know, I've already shed some tears | 19:28 |
+patspam | won't be the same without him | 19:29 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 19:29 |
+patspam | I'm heading out for lunch - expecting a visit from JT and Jamie later today! | 19:30 |
@preaction | wow, that was fast. they just left here Monday | 19:31 |
+patspam | heh, I'll see what sort of condition they're in after 3 days on the road together.. | 19:31 |
@preaction | eh, they'll be fine | 19:32 |
+patspam | I've seen enough american road trip movies to be wary =p | 19:32 |
+patspam | JT will be wearing flares and Jamie will be playing the banjo | 19:33 |
+patspam | or something like that | 19:33 |
+perlDreamer | scrottie: there's still some problem with inbox messsages | 19:52 |
+perlDreamer | try this to replicate it | 19:52 |
+perlDreamer | run t/Shop/Transaction.t | 19:52 |
+perlDreamer | this will leave a message in the inbox, to a group that no longer exists | 19:52 |
+perlDreamer | then, run t/Workflow/Activity/NotifyAboutLowStock.t | 19:52 |
+perlDreamer | one test will fail, because it reports admin as having 2 messages, instead of the one expected | 19:52 |
CIA-57 | webgui: Colin Kuskie master * r83e9451 / (10 files in 7 dirs): More END block cleanups. - http://bit.ly/c3LApr | 19:54 |
CIA-57 | webgui: Colin Kuskie master * r908b972 / t/lib/WebGUI/Test.pm : Add Inbox monitoring to WebGUI::Test - http://bit.ly/bfmbZX | 19:54 |
@scrottie | if the only problem is that the email is still readable after the group goes away (as it should be), then the test is wrong, correct? | 19:54 |
+perlDreamer | no | 19:54 |
@scrottie | also, the tests don't normally run in that order (??) so this doesn't manifest as a test fail unless you run them back to back? | 19:55 |
+perlDreamer | it shouldn't report the group email as belonging to admin | 19:55 |
+perlDreamer | the tests normally run in alphabetical | 19:55 |
@scrottie | being to whatnow? | 19:55 |
+perlDreamer | and t/Shop comes before t/Workflow | 19:55 |
@scrottie | belonging to... | 19:57 |
@scrottie | alright, I have no idea what you're talking about, so I'll read code. | 19:57 |
+perlDreamer | scrottie: it looks like the newly modified SQL is saying that the inbox message belongs to Admin | 19:57 |
+perlDreamer | when it should not | 19:57 |
@scrottie | did this manifest as a test failure that I missed? | 19:59 |
+perlDreamer | no | 20:00 |
+perlDreamer | I changed the test cleanup, which left this inbox message behind | 20:00 |
+perlDreamer | however, the inbox message should not belong to anyone | 20:00 |
+perlDreamer | since it isn't assigned to a userId | 20:00 |
+perlDreamer | and the groupId no longer exists | 20:00 |
@scrottie | right. just trying to get some context. thanks. | 20:01 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 20:03 |
@scrottie | is(@{ $adminMessages }, 1, '... sent one message to shop admin, via shopSaleNotificationGroupId'); | 21:02 |
@scrottie | what I'm seeing here is that it is intentionally sending a mail message to the admin | 21:02 |
@scrottie | and in the database, the userId of the admin (3, apparently) is plugged in there, just as expected. | 21:02 |
@scrottie | and the only reason that the query is picking up on that message is because it is doing AND inbox_messageState.userId = '3' | 21:03 |
@scrottie | other than that email to the admin not being cleaned up between test runs, this seems to be functioning correctly, remarkably enough. | 21:03 |
@scrottie | in other news, OSX's X server doesn't do X Test. wha? | 21:03 |
@scrottie | am I misunderstanding what I'm seeing here? | 21:05 |
+perlDreamer | not sure, scrottie, I'll have another look at it after I finish this support ticket | 21:06 |
@scrottie | cool. | 21:06 |
+perlDreamer | is there any way to duplicate this SQL query, without doing the join? | 21:12 |
+perlDreamer | select Event.assetId, endDate, revisionDate from Event join assetData using (assetId, revisionDate) where endDate < '2010-01-01' and revisionDate = (select max(revisionDate) from assetData where assetData.assetId=Event.assetId); | 21:12 |
@scrottie | why avoid the join? generally, but it probably wouldn't be pretty. also, I'm used to Postgres. | 21:13 |
+perlDreamer | speed | 21:14 |
@scrottie | stuff is indexed? nothing is going to be faster than a straight join. throw a limit on it... that might make it faster too. does in PG | 21:14 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 21:25 |
-!- mode/#webgui [+o tavisto] by ChanServ | 21:25 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 264 seconds] | 21:26 |
CIA-57 | webgui: Colin Kuskie master * r6d2d950 / (3 files in 3 dirs): Fix the delete expired events workflow (again). Fixes bug #11619 - http://bit.ly/cONwYq | 21:28 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r9f30a6d / (3 files in 3 dirs): Fix the delete expired events workflow (again). Fixes bug #11619 - http://bit.ly/9ko4kN | 21:29 |
-!- dionak [~dionak@97.66.185.250] has quit [Quit: dionak] | 21:30 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 21:32 |
@scrottie | perlDreamer, I'm getting ready to close that one ticket but I want to make sure you're cool with the changes and possible fallout first. I can wait as appropriate, of course. | 22:07 |
+perlDreamer | go ahead and close it, we can reopen it if needed | 22:07 |
@scrottie | alright. | 22:07 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:22 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 22:25 |
@khenn | have I reached my bug limit for today yet perlDreamer? | 22:34 |
@khenn | =) | 22:34 |
+perlDreamer | yes | 22:34 |
+perlDreamer | submit it tomorrow | 22:34 |
@khenn | too late | 22:38 |
@khenn | last one for today | 22:38 |
@khenn | (maybe) | 22:38 |
@khenn | still working on Thingy so we'll see | 22:39 |
@scrottie | hmm. I'm not finding a link to mark tickets resolved. anyway, lunch and coffee round two. | 22:42 |
+perlDreamer | scrottie, there's a dropdown in the top right | 22:43 |
+perlDreamer | you may not be setup to resolve them yet, however | 22:44 |
+perlDreamer | khenn, I don't want to fix that bug | 22:53 |
+perlDreamer | that's a bug in how the method is used | 22:53 |
+perlDreamer | getUrl's POD docs says that it appends the gateway to it | 22:54 |
+perlDreamer | and calling the gateway would obviously add the gateway to it | 22:55 |
+perlDreamer | there's no code in the core that does that | 22:57 |
@khenn | there is no reason not to add the check | 23:01 |
+perlDreamer | it's not a bug | 23:01 |
+perlDreamer | someone didn't read the docs | 23:01 |
+perlDreamer | they used WebGUI the wrong way | 23:01 |
@preaction | there is a great reason to not add the check: /gateway/gateway <- perfectly valid URL | 23:02 |
@preaction | we can't save developers from themselves | 23:02 |
@khenn | alright | 23:12 |
@khenn | I'll change the bug to: | 23:12 |
@khenn | every API method in WebGUI that accepts a url should indicate whether or not it requires gateway to be appended | 23:12 |
@khenn | since it's not standard | 23:12 |
@khenn | the pod on those methods says nothing about gateways | 23:12 |
@khenn | so someone reading the API will not know that gateway will be appended to the url | 23:13 |
@khenn | you'd have to actually look at the code | 23:13 |
@khenn | to determine that | 23:13 |
@khenn | so if you are saying that coding in WebGUI requires that you read every line of code of every method you call | 23:13 |
@khenn | then perhaps it's not a bug afterall | 23:13 |
+perlDreamer | which methods are you talking about, khenn? | 23:14 |
@khenn | all the methods in WebGUI::Session::Icon | 23:14 |
@khenn | which accept pageUrl as an optional parameter | 23:15 |
+perlDreamer | fixing the POD in Session::Icon is a fixable bug | 23:16 |
@khenn | preaction: you can absolutely determine if the gateway is there | 23:16 |
@khenn | if the beginning of the url starts with the gateway | 23:16 |
@khenn | then it's there | 23:16 |
@preaction | no you cant. if $asset->get('url') starts with the gateway, it's still not there | 23:16 |
@preaction | hence: /gateway/gateway <- will break your check | 23:16 |
@khenn | I see | 23:16 |
@khenn | well then the fix should be to update the pod on every method that accepts a url in webgui | 23:17 |
@khenn | and indicate whether or not the url passed in should contain the gateway | 23:17 |
@preaction | i never said anyone had to know all of webgui to code for it, or read all of the code for the methods they're using. incorrect documentation is a bug | 23:17 |
@khenn | sure | 23:17 |
@khenn | agreed | 23:18 |
@khenn | would you like me to open a new ticket? | 23:18 |
@preaction | doesn't matter | 23:19 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r78e8ea3 / lib/WebGUI/Session/Icon.pm : Document that url's passed to Session/Icon methods will have the gateway URL prepended to that URL. - http://bit.ly/cJL1JK | 23:21 |
CIA-57 | webgui: Colin Kuskie master * re222b6c / lib/WebGUI/Session/Icon.pm : Document that url's passed to Session/Icon methods will have the gateway URL prepended to that URL. - http://bit.ly/9R3SfN | 23:21 |
+perlDreamer | scrottie, please try to resolve that bug again | 23:28 |
+perlDreamer | it should be set up now | 23:29 |
CIA-57 | webgui: Colin Kuskie master * r7ef9c6e / t/Config.t : END block cleanups. - http://bit.ly/andcnu | 23:33 |
CIA-57 | webgui: Colin Kuskie master * r29ca0f2 / t/Inbox/Groups.t : Remove uncontrolled diagnostics, and done_testing. - http://bit.ly/cyq6q2 | 23:33 |
CIA-57 | webgui: kimd master * rcb82394 / lib/WebGUI/Asset/Wobject/Gallery.pm : Added search by location to the Gallery (RFE 11504) - http://bit.ly/aeuuXe | 23:33 |
CIA-57 | webgui: kimd master * rfa04d01 / (7 files in 6 dirs): | 23:33 |
CIA-57 | webgui: o Allow return from photo edit view to gallery edit view (RFE 11571) | 23:33 |
CIA-57 | webgui: o Reject form submissions without image selected for upload in edit view of Photo asset - http://bit.ly/bi5Ych | 23:33 |
@preaction | sigh. rebase before merge. rebase before merge. rebase before merge. rebase before merge... | 23:34 |
+perlDreamer | I hear autorebase can be setup | 23:34 |
@preaction | it is. a pull does a rebase. i just didn't pull (i fetched kimd's repo and merged) | 23:36 |
-!- SquOnk [~emhn@190.198.61.14] has joined #webgui | 23:50 |
--- Day changed Thu Jun 10 2010 |
@scrottie | o/~ don't you want me BABY... o/~ | 00:16 |
@scrottie | they play the worst music in Goodwill. | 00:16 |
@scrottie | seriously, the stuff on the racks for sale is better than what they play. | 00:16 |
@scrottie | w00t, thanks perlDreamer. resolved. | 00:17 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Ping timeout: 264 seconds] | 01:09 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 01:14 |
Haarg | perlDreamer, if i commit that temp config file for testing thing, should i back-port it to 7.x? | 01:22 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 01:38 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 01:43 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 01:49 |
-!- preaction [~doug@207.200.236.230] has quit [Quit: preaction] | 01:56 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 02:23 |
-!- mode/#webgui [+o preaction] by ChanServ | 02:23 |
+perlDreamer | Haarg, I'd love to have that in master and 7.8 | 02:49 |
+perlDreamer | although, I haven't pulled all the END block cleanups back into 7.8, either | 02:49 |
Haarg | ok, i'll try to work on that. although i guess it will have to be done differently in 7.8 due to differences in config file paths | 02:51 |
+perlDreamer | let's skip 7.8 then | 02:52 |
+perlDreamer | time is growing short | 02:52 |
Haarg | well, 7.8/9 is the same story | 02:52 |
+perlDreamer | oh, in that case, skip it all | 02:52 |
Haarg | the main reason i was thinking to do it is it would probably make merging go smoother | 02:53 |
Haarg | i was trying to work on stuff to get rid of pseudorequest but got distracted by that other stuff i changed | 02:56 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 03:07 |
-!- SquOnk [~emhn@190.198.61.14] has quit [Quit: Yippie kay-ai-yay, fudder muckers!] | 03:09 |
-!- fokat [~lem@190.198.61.14] has quit [Ping timeout: 240 seconds] | 03:18 |
+perlDreamer | scrottie: all tests issues fixed! | 03:25 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * r1fa0d30 / lib/WebGUI/Session/Icon.pm : Fix a whitespace POD issue. - http://bit.ly/am6kuC | 03:25 |
CIA-57 | webgui: Colin Kuskie webgui-7.8 * rd2f48eb / (3 files in 3 dirs): Fix cleanup of Inbox messages for users. Provide a method for cleaning up Admin's messages. - http://bit.ly/d23de9 | 03:25 |
+perlDreamer | patspam, I'm ready to check footers, but am lacking something that can talk port 25 | 03:25 |
CIA-57 | webgui: Colin Kuskie master * r8edcab3 / lib/WebGUI/Session/Icon.pm : Fix a whitespace POD issue. - http://bit.ly/adQb3Z | 03:26 |
CIA-57 | webgui: Colin Kuskie master * r5372158 / (3 files in 3 dirs): Fix cleanup of Inbox messages for users. Provide a method for cleaning up Admin's messages. - http://bit.ly/b48EBp | 03:26 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Read error: Connection reset by peer] | 03:30 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Quit: dionak] | 03:44 |
@scrottie | hmm? _all_ test issues fixed? | 04:09 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has joined #webgui | 04:20 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 04:25 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Client Quit] | 04:28 |
+perlDreamer | scrottie, _all_ as in "all tests on master branch" | 04:30 |
@scrottie | cool. | 04:30 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 04:37 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has left #webgui [] | 04:42 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r0578a55 / t/Asset/Wobject/StoryArchive.t : Freshen the archive from db to fix all tests. - http://bit.ly/aO2XqV | 04:47 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r705f0d4 / (lib/WebGUI/Asset.pm t/Asset.t): Setup keywords as a string, not an array ref. Add tests for that. - http://bit.ly/dfvzx7 | 04:58 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 05:08 |
+perlDreamer | hm, Moose adds lots of weirdo code, according to the debugger | 05:27 |
+perlDreamer | it would appear that there's a problem with requestAutocommit ? | 05:32 |
+perlDreamer | the debugger is awesome! | 05:37 |
-!- ekennedy1 [~ekennedy@70-14-120-118.pools.spcsdns.net] has joined #webgui | 05:38 |
-!- ekennedy1 [~ekennedy@70-14-120-118.pools.spcsdns.net] has left #webgui [] | 05:39 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has joined #webgui | 05:40 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r05ce650 / t/Asset/Story.t : Update Story test for new accessors. - http://bit.ly/9F6r0q | 05:42 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 05:51 |
-!- ekennedy1 [~ekennedy@70-14-120-118.pools.spcsdns.net] has joined #webgui | 05:56 |
-!- ekennedy1 [~ekennedy@70-14-120-118.pools.spcsdns.net] has left #webgui [] | 05:56 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Ping timeout: 260 seconds] | 05:57 |
-!- scrottie [~scrottie@ip72-201-253-58.ph.ph.cox.net] has joined #webgui | 05:57 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 05:58 |
-!- ekennedy [~ekennedy@70-14-120-118.pools.spcsdns.net] has quit [Ping timeout: 258 seconds] | 06:00 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Read error: Connection reset by peer] | 07:16 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 08:36 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:46 |
-!- kaare is now known as Guest71493 | 08:47 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 10:10 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Read error: Connection reset by peer] | 11:22 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 11:26 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 13:41 |
-!- mode/#webgui [+v bartjol] by ChanServ | 13:41 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 15:01 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:28 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 16:33 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 16:38 |
-!- fokat [~lem@200.84.244.194] has joined #webgui | 16:39 |
-!- Guest71493 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 16:55 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 16:56 |
-!- mode/#webgui [+v patspam] by ChanServ | 16:56 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 16:58 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 17:34 |
-!- mode/#webgui [+o tavisto] by ChanServ | 17:34 |
-!- fokat [~lem@200.84.244.194] has quit [Ping timeout: 260 seconds] | 17:41 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 17:42 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * ra9bf59f / t/Asset/Wobject/StoryTopic.t : Pull fresh copies of the Topic from the db. - http://bit.ly/a8y2yq | 17:43 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:07 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:07 |
Haarg | perlDreamer, just pushed a bunch of backported test stuff to master | 18:12 |
+perlDreamer | Haarg, have you ever tried this: | 18:12 |
CIA-57 | webgui: Graham Knop master * r0ddd109 / lib/WebGUI/Group.pm : reset groups for all assets in database instead of those listed in config file (+7 more commits...) - http://bit.ly/c1AXbp | 18:12 |
+perlDreamer | diag $session->id->toHex('PBnav00000000000000008'); | 18:12 |
+perlDreamer | diag $session->id->toHex('PBnav00000000000000001'); | 18:12 |
+perlDreamer | and looked at the output? | 18:12 |
Haarg | heh | 18:12 |
Haarg | no | 18:12 |
+perlDreamer | you should | 18:12 |
+perlDreamer | it's very enlightening | 18:12 |
Haarg | the tests generally seem to work ok, but a number of them are failing in ways that i wouldn't expect to be related | 18:13 |
+perlDreamer | it would appear that only the first 20 characters are significant in calculating the hexId | 18:14 |
-!- scrottie [~scrottie@ip72-201-253-58.ph.ph.cox.net] has quit [Ping timeout: 260 seconds] | 18:14 |
+perlDreamer | dang, I think it's a bug in MIME::Base64 | 18:20 |
+perlDreamer | the spec says that up to 2 = are allowed | 18:20 |
+perlDreamer | but if we pad with 2 ='s, and run through 22-character assetIds that differ in the last two characters, the binary decoded strings are the same | 18:20 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 18:28 |
-!- mode/#webgui [+o scrottie] by ChanServ | 18:31 |
-!- dionak [~dionak@97.66.185.250] has quit [Ping timeout: 240 seconds] | 18:34 |
Haarg | perlDreamer, i'm not sure it's a bug | 18:42 |
+perlDreamer | why not, Haarg? | 18:43 |
+perlDreamer | it's already caused clashing CSS id's in rendered pages | 18:43 |
Haarg | we are giving it data that isn't quite a valid base64 | 18:44 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:44 |
Haarg | PBnav00000000000000008 is not really a valid guid | 18:44 |
+perlDreamer | it's not? | 18:44 |
Haarg | it could never be created by our guid generator | 18:44 |
Haarg | too many bits | 18:44 |
+perlDreamer | s/never/not likely to be/ | 18:44 |
Haarg | no | 18:45 |
Haarg | never | 18:45 |
Haarg | md5 is 128 bits | 18:45 |
Haarg | 22 character base64 is 132 bits | 18:45 |
Haarg | PBnav00000000000000008 has too much precision to be a valid md5 | 18:46 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 18:49 |
+perlDreamer | how 'bout this | 18:49 |
+perlDreamer | there is a bug | 18:50 |
+perlDreamer | it's either in WebGUI, in how we use base64 and hex encoding | 18:50 |
+perlDreamer | or there's a bug in MIME::Base64, in how it's decoding random junk we throw at it | 18:50 |
+perlDreamer | or there's a bug in allowing developers to manually pick GUIDs | 18:51 |
Haarg | the last one i would say yes | 18:51 |
Haarg | but there are other fixes | 18:52 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 18:52 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 18:56 |
* scrottie sighs | 18:57 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 18:58 |
@scrottie | god I hate Linux. | 18:58 |
-!- dionak [~dionak@97.66.185.250] has quit [Quit: dionak] | 18:58 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Remote host closed the connection] | 18:58 |
Haarg | ok, so yeah i guess i'm wrong about there being other fixes | 18:58 |
Haarg | PBnav00000000000000008 cannot be represented as a 32 character hex code | 18:59 |
+perlDreamer | nope | 18:59 |
+perlDreamer | you're right, the bug is allowing devs to pick assetIds | 19:00 |
+perlDreamer | since they can't pick storageIds, it should be okay | 19:00 |
Haarg | yeah | 19:00 |
+perlDreamer | but I'm still stuck with a way to make unique CSS Ids out of invalid data | 19:00 |
Haarg | well, we can adjust the code to output longer ids | 19:00 |
+perlDreamer | Since everything after an = is ignored, how about adding a 0 to the end of the assetId, in order to give it enough bits? | 19:02 |
Haarg | i'm working on something like that | 19:03 |
Haarg | http://gist.github.com/433214 | 19:06 |
+perlDreamer | the problem with that is that we'd have to go and rename every storage location, right? | 19:07 |
@tavisto | based on an email I just received, I think Experian is using wG for it's intranet. (In South Africa) | 19:07 |
Haarg | no | 19:07 |
Haarg | it gives the same ids as before | 19:07 |
Haarg | for normal guids | 19:07 |
Haarg | actually it is buggy and doesn't but that's the idea | 19:08 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has joined #webgui | 19:10 |
-!- mode/#webgui [+o scrottie] by ChanServ | 19:10 |
+perlDreamer | why does it strip trailing 0's? | 19:12 |
+perlDreamer | 0 is a valid hex char | 19:13 |
Haarg | it was meant to strip then re-add them | 19:13 |
Haarg | but it's busted in a number of ways | 19:13 |
* perlDreamer is off to the gym | 19:15 |
+perlDreamer | I'm sure that bit alignments and padding will follow | 19:15 |
Haarg | http://gist.github.com/433229 | 19:18 |
Haarg | the ending zero was getting stripped off by the old code | 19:19 |
Haarg | that code should generate the same ids for anything generated by the guid generator | 19:20 |
Haarg | and 33 character hex strings for things like PBnav00000000000000008 | 19:20 |
-!- scrottie [~scrottie@dsl01-ppp-5119.fastq.com] has quit [Quit: Leaving] | 19:25 |
-!- patspam1 [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 19:29 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Disconnected by services] | 19:29 |
-!- patspam1 is now known as patspam | 19:30 |
-!- mode/#webgui [+v patspam] by ChanServ | 19:30 |
-!- fokat [~lem@190.198.61.14] has joined #webgui | 19:33 |
Haarg | that last patch was also a bit goofy. the thing i committed is better. | 19:33 |
CIA-57 | webgui: Graham Knop master * r596420c / lib/WebGUI/Session/Id.pm : generate better hex ids for manually created badly formed guids - http://bit.ly/aWYtcF | 19:34 |
* Haarg is tempted to commit http://gist.github.com/433267 | 19:37 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Ping timeout: 265 seconds] | 19:46 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 20:07 |
+perlDreamer | Haarg, normally i advise against succumbing to temptation, but in this case, I'd encourage you to give in | 20:24 |
+perlDreamer | also, Haarg, temporary config files don't seem to work with my setup: http://gist.github.com/433326 | 20:31 |
Haarg | oh fun | 20:31 |
+perlDreamer | that's a lot of ../ | 20:31 |
Haarg | how are you running them? | 20:33 |
+perlDreamer | env WEBGUI_TEST_DEBUG=1 perl Session/Id.t | 20:33 |
+perlDreamer | same result from running it from /data/WebGUI | 20:41 |
CIA-57 | webgui: Graham Knop master * ra2cb075 / t/lib/WebGUI/Test.pm : fix temp config file for tests - http://bit.ly/bvOo9W | 20:43 |
Haarg | i don't really know how it was working at all previously, but that should fix it | 20:43 |
+perlDreamer | Cannot read config file: /tmp/mywebgui-11_M.conf at /usr/share/perl5/Config/JSON.pm line 47 | 20:45 |
Haarg | can you check what the filename it is trying to copy from is? | 20:46 |
Haarg | in WebGUI::Test->file ? | 20:47 |
+perlDreamer | http://gist.github.com/433349 | 20:48 |
Haarg | oh | 20:49 |
Haarg | yeah, that was dumb | 20:49 |
+perlDreamer | dude, you're stepping on my toes | 20:49 |
+perlDreamer | You're supposed to do brilliant things | 20:49 |
+perlDreamer | I'm supposed to go around making dumb mistakes | 20:49 |
+perlDreamer | like deleting Cron jobs that have communication errors | 20:49 |
Haarg | try this http://gist.github.com/433351 | 20:50 |
+perlDreamer | that works | 20:52 |
-!- scrottie [~scrottie@ip72-201-253-58.ph.ph.cox.net] has joined #webgui | 20:52 |
-!- mode/#webgui [+o scrottie] by ChanServ | 20:52 |
@scrottie | alright. okay. alright. | 20:52 |
+perlDreamer | do you want to commit that, Haarg, or would you like me to? | 20:59 |
Haarg | you can | 21:00 |
CIA-57 | webgui: Colin Kuskie master * rb74d211 / t/lib/WebGUI/Test.pm : Temporary config file fix. - http://bit.ly/doBoUl | 21:02 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 21:14 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 21:18 |
-!- dionak [~dionak@97.66.185.250] has quit [Quit: dionak] | 21:57 |
-!- dionak [~dionak@97.66.185.250] has joined #webgui | 22:03 |
+perlDreamer | preaction, Haarg, patspam: I don't see any reason why a PSGI merge isn't doable now | 22:14 |
+perlDreamer | I'm cleaning thing in each asset. | 22:14 |
+patspam | hey perlDreamer | 22:14 |
+perlDreamer | All the major systems are working, especially Session | 22:14 |
+patspam | it doesn't pass all the tests though | 22:15 |
+perlDreamer | no | 22:15 |
+perlDreamer | but that's due to issues in an Asset | 22:15 |
+perlDreamer | rather than Asset.t | 22:15 |
+perlDreamer | FormBuilder isn't passing, but preaction doesn't expect it to | 22:15 |
+patspam | oh - even though the psgi branch fails some tests that pass in the WebGUI8 branch? | 22:15 |
+perlDreamer | as long as there is parity between the failures, I still think y'all could merge | 22:16 |
+perlDreamer | do you want me to paste some recent results for comparison? | 22:16 |
+patspam | what do you mean by parity? | 22:17 |
+patspam | like, at the moment, psgi fails on stuff that wg8 passes on.. that's not parity right? | 22:17 |
+perlDreamer | cmp_deeply (failures_from_psgi, failures_from_WebGUI8, 'no mismatch in failures'); | 22:17 |
+perlDreamer | no, that's not parity | 22:17 |
+patspam | yeah, we're not there yet | 22:17 |
+perlDreamer | what's failing? | 22:18 |
+patspam | well, last week a whole lot of stuff | 22:18 |
@scrottie | haha | 22:18 |
+patspam | but then i did a quick hack around pseudorequest, and about a third started passing | 22:18 |
+patspam | actually i didn't bother running the whole suite, just the A's and B's.. =p | 22:19 |
+perlDreamer | oh.... | 22:19 |
+patspam | enough to know that we're not there yet | 22:19 |
+perlDreamer | well, let me put it this way then :) | 22:19 |
+perlDreamer | WebGUI8 is ready for you | 22:19 |
+patspam | hehe | 22:19 |
+patspam | but are YOU ready for webgui8? | 22:19 |
+patspam | that should be the tagline | 22:19 |
+perlDreamer | I'd better be, I'm talking about it at the WUC! | 22:19 |
+patspam | wheee! | 22:19 |
-!- dionak [~dionak@97.66.185.250] has quit [Quit: dionak] | 22:20 |
+perlDreamer | and frodwith is talking about Moose in the morning, so everyone will be primed and ready for the WebGUI specific stuff | 22:20 |
+patspam | I *really* want to get it merged, because I know that will accelerate things, just gotta get over this hump | 22:20 |
+patspam | not sure if you backlogged the other day when I was talking to Haarg about pseudorequest | 22:20 |
+perlDreamer | I usually backlog, but I may have been out | 22:21 |
+perlDreamer | I'll check the logs | 22:21 |
+patspam | on the one hand, we're throwing it away because we can create a *real* psgi request object | 22:21 |
+patspam | but on the other hand, it's a gold mine for the work that's left to be done | 22:21 |
+patspam | because you essentially did the hard work of mapping all the Apache2:: methods | 22:21 |
+patspam | we just need to steal from that as we're ripping out WebGUI::Session::Http | 22:22 |
+patspam | mapping wG core direct to WebGUI::Session::Request/Response | 22:22 |
+patspam | (which is a thin wrapper around Plack::Request/Response) | 22:22 |
+patspam | so perlDreamer++ to you! | 22:22 |
+perlDreamer | wrapper, or sub-class? | 22:22 |
+patspam | slapper | 22:22 |
+patspam | they're designed to be subclassed | 22:23 |
+patspam | it has the miyagawa gold stamp of awesomeness on it | 22:23 |
+perlDreamer | cool, we've been bitten by too many wrappers around everything | 22:23 |
+perlDreamer | on the one hand, they insulate you from low-level API changes | 22:23 |
+perlDreamer | but on the other hand, you're reimplementing all these methods | 22:24 |
+perlDreamer | the most infamous of which is DBI | 22:24 |
+patspam | yeah, I reckon in this case the less we "improve" the API the better | 22:24 |
+perlDreamer | totally | 22:24 |
+perlDreamer | hey, if I fly into Chicago and drive to Madison, would you want to ride share there? | 22:24 |
+patspam | hence getting rid of WebGUI::Session::Http | 22:24 |
+perlDreamer | or do you prefer to fly into Madcity? | 22:24 |
+patspam | hey that'd be cool! | 22:24 |
+patspam | Andy will be with me too | 22:25 |
+perlDreamer | Andy's coming to New York? | 22:25 |
+patspam | yep! | 22:25 |
+patspam | for the weekend | 22:25 |
+perlDreamer | when do y'all plan to fly out? | 22:25 |
+patspam | Monday was the plan | 22:25 |
+patspam | but we haven't booked yet | 22:25 |
* perlDreamer will look into flight arrival times into Chicago for Monday | 22:26 |
+patspam | sweet | 22:26 |
+perlDreamer | I think it will be much cheaper to fly into Chicago and drive, rather than into Madison | 22:26 |
+patspam | let's rendezvous in Chicago and drive over to msn | 22:26 |
+patspam | and more fun! | 22:26 |
+perlDreamer | yes | 22:26 |
+patspam | I'll be staying on in madison afterwards for the weekend though | 22:26 |
+patspam | Helen is coming out on the Friday | 22:27 |
+patspam | (last day of the wuc) | 22:27 |
+perlDreamer | We're still trying to firm up plans. I don't know if Kathy is going to make it out this year | 22:27 |
+patspam | Andy is flying back to Aus from MSN, although maybe it'd be cheaper for him to fly back from Chicago | 22:27 |
+patspam | so maybe he'd be up for a return road trip to chicago on Saturday | 22:28 |
+patspam | probably depends on flight times though | 22:28 |
+perlDreamer | yeah | 22:28 |
+perlDreamer | email me some info, and I'll see what we can work out | 22:29 |
+patspam | cool | 22:29 |
+patspam | the other thing with WebGUI::Test | 22:29 |
+patspam | I want to completely replace getPage | 22:29 |
+patspam | with Plack::Test::test_psgi | 22:30 |
+perlDreamer | i don't think that would be a problem | 22:30 |
+perlDreamer | getPage predates our usage of WWW::Mech | 22:30 |
+patspam | yeah, Plack Test achieves the same thing, but via a callback API (http://advent.plackperl.org/2009/12/day-13-use-placktest-to-test-your-application.html) | 22:30 |
+patspam | that way we can use the PLACK_TEST_IMPL env variable to run those tests under any plack server we like | 22:31 |
+patspam | and by using the callback API, we can support streaming responses etc.. | 22:32 |
+patspam | and finally, doing it with HTTP::Request/Response objects feels nice and clean too | 22:32 |
* patspam goes back to writing a $work spec doc | 22:33 |
+perlDreamer | got a little plack-happy there, dude | 22:33 |
+patspam | hehe | 22:33 |
+patspam | doesn't take much | 22:33 |
+patspam | oh actually, was going to ask | 22:35 |
+patspam | is there anything in WebGUI that let's you hide an asset via Group membership? | 22:36 |
+patspam | as in, exclusive | 22:36 |
+patspam | without creating another group? | 22:36 |
+perlDreamer | I'm not sure that I follow | 22:37 |
plainhao | whitelist? | 22:37 |
+patspam | yeah it's kinda strange | 22:37 |
+perlDreamer | you can set the ownerUserId | 22:37 |
+patspam | e.g. bob and mary are both in group x, and there are a whole lot of assets with whoCanView set to x | 22:37 |
+patspam | jane comes along, also in group x - but there's one little asset that she's not supposed to see | 22:38 |
+patspam | can I do it without creating group y that bob and mary both belong to? | 22:38 |
+patspam | (jane is in group z) | 22:38 |
+perlDreamer | there's no blacklisting | 22:38 |
+patspam | (z and x) | 22:38 |
+patspam | I was thinking about creating an assetProxy variant that did it | 22:38 |
+perlDreamer | but, by good group structure, you can get the same thing | 22:38 |
plainhao | blacklisting can get out of hand, no? | 22:39 |
+patspam | yeah, I'd just really like to avoid creating group y | 22:39 |
+perlDreamer | jane is in z, have x be a subgroup of z | 22:39 |
+perlDreamer | but that won't work for the reverse case | 22:39 |
+patspam | the thing is there's a whole lot of complex machinery already build around groups x and z | 22:39 |
+patspam | I really don't want to have to mess with it just to hide this one little asset | 22:40 |
+patspam | it's non-critical enough that I'm tempted to just create a macro that uses JS to hide it.. | 22:40 |
+perlDreamer | hang on | 22:40 |
+perlDreamer | in that one little asset | 22:40 |
+perlDreamer | make jane the owner of the asset | 22:41 |
+perlDreamer | that will give her viewing and editing privileges | 22:41 |
+patspam | jane's the one who's not supposed to see it | 22:41 |
+perlDreamer | argh | 22:41 |
+perlDreamer | what's wrong with jane? | 22:41 |
+perlDreamer | isn't this gender discrimination? | 22:41 |
+patspam | hehe | 22:42 |
plainhao | what if tarzan gets added to x? you want the same exclusion? | 22:42 |
+patspam | she's in a randomised control trial group | 22:42 |
+patspam | yep, there's lots of janes | 22:42 |
+patspam | maybe I should use an AssetProxy-like macro with custom code that shows it to bob and mary but not jane | 22:43 |
+patspam | I wonder how well Survey works through AssetProxy | 22:43 |
+perlDreamer | only for 1 click | 22:43 |
+patspam | dang | 22:44 |
+perlDreamer | after that, you lose focus on the AssetProxy, and go to the Survey | 22:44 |
+perlDreamer | are bob and jane also members of some other group, already? | 22:44 |
+patspam | yes | 22:45 |
+patspam | x | 22:45 |
+perlDreamer | in addition to x | 22:45 |
+perlDreamer | like Turn Admin On, Passive Analytics users | 22:45 |
+perlDreamer | Friends Managers? | 22:45 |
+patspam | Registered Users? | 22:45 |
+perlDreamer | but so is Jane | 22:45 |
+perlDreamer | jane* | 22:45 |
+patspam | jane-prime? | 22:46 |
+patspam | er, star? | 22:46 |
+perlDreamer | all janes | 22:46 |
+patspam | ask again | 22:46 |
+patspam | I'm confused | 22:46 |
+perlDreamer | sorry, I confused bob and mary | 22:46 |
+patspam | ah I suspected as much | 22:47 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:47 |
* perlDreamer should have some lunch | 22:47 |
+patspam | heh | 22:47 |
+patspam | I think I'll just hack it with JS | 22:47 |
+patspam | shame that Macros can't scream out STOP! and force the containing asset to not render | 22:48 |
+patspam | (on the server) | 22:48 |
+perlDreamer | die? | 22:49 |
+patspam | yikes maybe.. does that work? | 22:50 |
+perlDreamer | it won't render, that's for sure | 22:50 |
+perlDreamer | but not in a user friendly way | 22:50 |
* patspam runs off to try | 22:50 |
+patspam | oh that's ok, I just want it to disappear | 22:50 |
+patspam | damn, it's caught | 22:55 |
+patspam | Unable to process macro 'Die': Died at ... | 22:56 |
+patspam | ah well, javascript it is | 22:58 |
@scrottie | Zork solved this one. | 23:11 |
@scrottie | nothing just happens... a pass is made telling each object about each other object (verb->direct object, direct object->indirect object, etc) giving them a chance to protest; each object is invoked against each other object to update their internal states; then another round is made for them to give status updates on the result. | 23:12 |
@scrottie | I think I've become irrationally fanatical about Zork's implementation, though. | 23:13 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * rb964897 / t/Asset/Wobject/StoryTopic.t : StoryTopic test doesn't due, but has test failures in it. - http://bit.ly/aBsY3W | 23:13 |
+perlDreamer | 23 failing tests, and counting | 23:13 |
+perlDreamer | 22 failing tests | 23:14 |
@scrottie | the sky is failing! the sky is failing! | 23:27 |
+perlDreamer | soon, we'll be out of failing tests! | 23:27 |
+perlDreamer | what will we do then? | 23:27 |
@scrottie | hmm. I have some ideas. | 23:35 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 23:52 |
--- Day changed Fri Jun 11 2010 |
@scrottie | can someone tell me about all of this Class::C3 usage? I'm seeing a lot of stuff using it, the man page saying not to use it, and most cases not even doing multiple inheritance. | 00:15 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Quit: Leaving.] | 00:16 |
+perlDreamer | what man page saying not to use it? | 00:18 |
+perlDreamer | perhaps you shouldn't use it in 5.12, since C3 is a default MRO | 00:19 |
@scrottie | the perldoc for Class::C3 version 0.22 says not to use it. | 00:23 |
@scrottie | " NOTE: YOU SHOULD NOT USE THIS MODULE DIRECTLY - The feature provided is integrated into perl version >= 5.9.5, and you should use MRO::Compat instead, | 00:23 |
@scrottie | which will use the core implementation in newer perls, but fallback to using this implementation on older perls. | 00:23 |
@scrottie | " | 00:23 |
@scrottie | apparently, you shouldn't use it in 5.10 either. | 00:23 |
+perlDreamer | yeah, WebGUI hails from 5.8 days | 00:24 |
+perlDreamer | and there are still users who use 5.8 | 00:24 |
@scrottie | that's okay. I was just curious what considerations there were (if there was a good reason it was being used despite warnings or what the overall goal was) before considering ripping it out. | 00:24 |
@scrottie | running some comparative tests right now. | 00:24 |
+perlDreamer | it's out in WebGUI8 | 00:24 |
@scrottie | wait, it is? | 00:24 |
+perlDreamer | yes | 00:24 |
+perlDreamer | if you're seeing it, it's a bug | 00:24 |
+perlDreamer | shouldn't be in there | 00:25 |
@scrottie | a bug or botched git usage... git tells me I'm on branch WebGUI8 | 00:25 |
@scrottie | but ack is showing me a screenfull of hits | 00:25 |
+perlDreamer | in a file called JSONCollateral | 00:25 |
+perlDreamer | and in every file inside AssetHelpers/*.pm | 00:26 |
@scrottie | I'm trying to look at this t/Asset/JSONCollateral.t thing but I'm slowly realizing that it's going to take me a considerable amount of time to get my Moose-fu up to the point where I can muddle around in this stuff | 00:26 |
@scrottie | yup. | 00:26 |
+perlDreamer | we should consider making JSONCollateral a Moose type for WebGUI | 00:26 |
@scrottie | yeah. | 00:27 |
@scrottie | I'm fumbling my way down that road ;) | 00:27 |
+perlDreamer | or maybe a separate object, that is delegated | 00:27 |
@scrottie | figures that's what you meant when you suggested I look into the thing. | 00:27 |
+perlDreamer | but that's preaction's call at this point | 00:27 |
@scrottie | figured. | 00:27 |
@scrottie | first test was blowing up with other stuff trying to call ->meta on that class (the definition stuff) so I didn't really see any other options. | 00:28 |
@scrottie | I guess the definition stuff could do $package->can('meta') and make all of that stuff conditional. bah. | 00:28 |
+perlDreamer | no, JSONCollateral needs to be updated to work with Moose | 00:33 |
+perlDreamer | definitely | 00:33 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 00:34 |
@scrottie | I should be helping with Plack, not with Moose =P | 00:34 |
+perlDreamer | scrottie, you must learn the ways of Moose. | 00:34 |
+perlDreamer | You are older than most padawans, but we'll take you on for training anyway | 00:35 |
@scrottie | bleah. waste of training. I'm old, tired, and crotchety. | 00:35 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Client Quit] | 00:37 |
@scrottie | I like the OO that was hacked onto Forth way better than the OO shoehorned onto Perl. | 00:39 |
+perlDreamer | forth? | 00:41 |
+perlDreamer | forth? | 00:41 |
+perlDreamer | Forth is for heffalumps and woozles | 00:41 |
@scrottie | actually... I should do an Acme:: module that, if you try to B::Deparse::coderef2text something that's XS, not Perl, it should invoke objdump and spit out the x86 assembly. | 00:44 |
@scrottie | then of course something that'll let you build CVs from x86 assembly. | 00:44 |
@scrottie | just for a little of that Forth flavor. then we can dump all of the primitives and library stuff into one big file and declare Perl to have been written in itself. | 00:44 |
@scrottie | hrm, first I'd have to write Inline::x86. | 00:45 |
CIA-57 | webgui: Colin Kuskie WebGUI8 * r88e7144 / t/Workflow/Activity/ArchiveOldStories.t : Update the test for Moose status stickiness. - http://bit.ly/aL3JTm | 01:14 |
+perlDreamer | I think that takes us down to 21 tests | 01:14 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 01:20 |
-!- akeane [~akeane@esrl-fw-bb.boulder.noaa.gov] has joined #webgui | 01:20 |
+perlDreamer | akeane, channel rules are simple | 01:21 |
+perlDreamer | if you have a question, please feel free to ask | 01:21 |
xdanger | http://freshmeat.net/ - Most Vital Projects - 2. WebGUI 59.74% | 01:31 |
+perlDreamer | "Vital" -- cool! | 01:31 |
+perlDreamer | hm, vitality on freshmeat is a measure of how often you make announcements | 01:35 |
+perlDreamer | still, it's nice that people know we do work regularaly | 01:39 |
@scrottie | what the heck is "collateral data" anyway? | 01:42 |
+perlDreamer | It's like a data backpack | 01:42 |
+perlDreamer | for example, in the DataForm, collateral data is the set of fields and tabs that make up a form, and the data a user enters. | 01:43 |
+perlDreamer | I guess, in general, it's data stored outside the asset specific tables | 01:43 |
+perlDreamer | About two years ago, we decided to start storing JSON data in the database | 01:43 |
* scrottie listens | 01:44 |
+perlDreamer | it was a quick and relatively easy way to get collateral data to be revisioned | 01:44 |
+perlDreamer | to be exported and imported during packages | 01:44 |
+perlDreamer | however, it makes it nigh on impossible to manipulate it using SQL | 01:44 |
@scrottie | hrm. | 01:45 |
+perlDreamer | $scrottie->translate('hrm')->expand_clarify | 01:47 |
@scrottie | no thoughts other than "that's vaguely interesting" and I don't have any more questions at the moment. | 01:50 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 02:09 |
-!- CIA-57 [cia@208.69.182.149] has quit [Ping timeout: 272 seconds] | 02:09 |
Haarg | perlDreamer, would you like me to backport those test changes i just made to 7.8? | 02:13 |
+perlDreamer | sure | 02:14 |
-!- fokat [~lem@190.198.61.14] has quit [Quit: Ex-Chat] | 02:23 |
-!- CIA-60 [~CIA@208.69.182.149] has joined #webgui | 02:55 |
CIA-60 | webgui: Graham Knop WebGUI8 * r6f10297 / (20 files in 11 dirs): use temp config file for testing (+5 more commits...) - http://bit.ly/cnNuYA | 02:59 |
xdanger | http://mentalhouse.net/irc/logs/webgui/latest.log.html <-- little bit easier to read, and you can bookmark the latest directly | 03:04 |
+perlDreamer | thanks, xdanger | 03:04 |
xdanger | should I break the log for each day? | 03:04 |
+perlDreamer | nah | 03:05 |
xdanger | ok, your the boss ;) | 03:05 |
+perlDreamer | those logs have really helped us out several times | 03:05 |
* perlDreamer steps out to make dinner | 03:05 |
xdanger | I try to read the backlog every now and then, but I don't like to read long backlogs in my client. I hope that this html conversion will benefit me also =) | 03:14 |
-!- akeane [~akeane@esrl-fw-bb.boulder.noaa.gov] has quit [Quit: Leaving.] | 03:26 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has joined #webgui | 03:31 |
--- Log closed Fri Jun 11 03:49:13 2010 |
--- Log opened Fri Jun 11 04:27:22 2010 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 04:27 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 04:34 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Quit: Leaving.] | 04:51 |
+perlDreamer | preaction, I'm pleased to report we're in the home stretch for WebGUI8 tests | 05:11 |
@preaction | yay! | 05:11 |
+perlDreamer | today we broke 20 failing tests | 05:11 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rf3769d6 / t/Macro/UsersOnline.t : | 05:11 |
CIA-60 | webgui: Fix the UsersOnline test. | 05:11 |
CIA-60 | webgui: Interesting failure. Calling new on the assetId caused the template to fail. I think this is due to priming the cache with | 05:11 |
CIA-60 | webgui: the asset data as an Asset, instead of as a Template. - http://bit.ly/bqNuH4 | 05:11 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * ref32e85 / lib/WebGUI/Macro/UsersOnline.pm : Exception handling for the Template in UsersOnline macro. - http://bit.ly/dd0rqw | 05:11 |
@preaction | then master merge! then PSGI! | 05:11 |
@preaction | maybe i'll have time to finish the getEditForm and Admin Console changes and then RELEASE! | 05:12 |
+perlDreamer | patspam says PSGI isn't ready to merge yet | 05:12 |
+perlDreamer | more failing tests than WebGUI8 branch | 05:12 |
@preaction | but aren't they supposed to fail? isn't that why we're merging? so we can all fix them? | 05:13 |
* perlDreamer thought you said not to merge until all tests are passing | 05:13 |
@preaction | all WebGUI8 tests | 05:13 |
@preaction | that way we have a stable baseline to merge against | 05:14 |
+perlDreamer | well, we're still 18 tests away from that | 05:14 |
@preaction | and any tests that break are PSGI's fault | 05:14 |
+perlDreamer | Haarg: much testing brokenness in WebGUI8 | 05:19 |
+perlDreamer | Plack::Test? | 05:20 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has quit [Ping timeout: 260 seconds] | 05:20 |
+perlDreamer | oh, very convenient | 05:20 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rd439f32 / t/lib/WebGUI/Test.pm : No Plack, yet... - http://bit.ly/b9L815 | 05:21 |
-!- Haarg [~haarg@76-250-33-221.lightspeed.mdsnwi.sbcglobal.net] has joined #webgui | 05:22 |
+perlDreamer | Haarg, I think a Plack line may have crept into WebGUI::Test a little prematurely | 05:22 |
Haarg | yeah, possibly | 05:22 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r073623b / t/Asset/Wobject/Survey/Test.t : change to surveyJSON accessor. => getSurveyJSON. This should probably be completely reworked to use some kind of object delegation. - http://bit.ly/9rgZpH | 05:26 |
+perlDreamer | 16 tests away | 05:28 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rfc3bda3 / t/Asset/Wobject/Survey/Reports.t : Remove SKIP for use_ok, and fix surveyJSON accessor. - http://bit.ly/dgcRV4 | 05:28 |
+perlDreamer | maybe less, since I think the Survey tests cause the expireSurvey test to fail | 05:29 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r4dc9cba / t/Asset/Story.t : Fix storageId cleanup, had a syntax error in perl 5.10.1 - http://bit.ly/bUoMBk | 05:52 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 05:53 |
Haarg | i caught that one in master/webgui-7.8 but forgot to do it in WebGUI8 | 05:53 |
+perlDreamer | any others, by chance? | 05:53 |
+perlDreamer | like StoryArchive? | 05:53 |
Haarg | nothing comes to mind | 05:54 |
+perlDreamer | would you mind giving it a run, in WebGUI8? | 05:54 |
+perlDreamer | Cannot read config file: /data/webgui/etc/mywebgui-6T7K.conf at /usr/share/perl5/Config/JSON.pm line 47 | 05:54 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 05:54 |
Haarg | ack | 05:54 |
Haarg | i thought i had pushed the fix for that | 05:55 |
+perlDreamer | I'm up to date | 05:55 |
Haarg | can you stick some diag in sub file to see what paths it is using? | 05:57 |
+perlDreamer | getting the same thing from AssetAspect/RssFeed.t | 05:57 |
+perlDreamer | yeah, I can do that | 05:57 |
+perlDreamer | great, now it's passing | 06:00 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has quit [Read error: Connection reset by peer] | 06:00 |
* perlDreamer will run the test a bunch of times | 06:00 |
+perlDreamer | maybe it only fails in the suite... | 06:02 |
+perlDreamer | which doesn't bode well | 06:02 |
Haarg | the error you posted is weird because it shouldn't be sticking the temp config file in /etc/ | 06:03 |
-!- mducharme [~nothing@S0106000e0cc03cff.wp.shawcable.net] has joined #webgui | 06:03 |
Haarg | how are you running he suite? | 06:03 |
+perlDreamer | prove -rm --verbose . > ../proven8 | 06:22 |
+perlDreamer | also, all my code is pushed | 06:29 |
+perlDreamer | with the exception of the warn statements | 06:29 |
+perlDreamer | I'll run the suite again | 06:30 |
Haarg | what output are you getting from your debug stuff? | 06:44 |
+perlDreamer | still running | 06:45 |
+perlDreamer | the output from the standalone tests had the temp config file in /tmp | 06:45 |
+perlDreamer | Haarg: http://gist.github.com/434018 | 06:49 |
+perlDreamer | at the start of the test, it's fine | 06:49 |
+perlDreamer | but down the line, it wants to stick it into etc | 06:49 |
Haarg | does it always do that when you run that test? | 06:50 |
+perlDreamer | if I run it standalone, it works fine | 06:50 |
+perlDreamer | if I run it in the suite, then I get the bug | 06:51 |
Haarg | what if you do PERL5OPT=-MDevel::SimpleTrace prove ... | 06:52 |
+perlDreamer | I'll do that next | 06:53 |
+perlDreamer | but I think it may be in copying or duplicating sessions | 06:53 |
+perlDreamer | the export code open a new Session by Session->open($session->config); | 06:54 |
+perlDreamer | that passes the object through to the constructor | 06:54 |
+perlDreamer | ... madly installing perl modules | 07:06 |
+perlDreamer | stupid package based perl install | 07:06 |
Haarg | perlDreamer, i'm seeing a bunch of test failures looking like # Compared $data->{"url"} # got : '_test-ems' # expect : 'test-ems' | 07:12 |
Haarg | do you know anything about that? | 07:13 |
+perlDreamer | I haven't seen anything like that | 07:13 |
Haarg | hrm | 07:13 |
+perlDreamer | I was down to only 16 test failures before I pulled the latest testing updates | 07:13 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 07:21 |
Haarg | looks like it was something in my config | 07:23 |
+perlDreamer | what do you set in the config to change Asset URLs? | 07:27 |
+perlDreamer | gatewayUrl? | 07:27 |
Haarg | gateway | 07:28 |
Haarg | but that wasn't it | 07:28 |
Haarg | i'm running the test suite here as well | 07:30 |
+perlDreamer | I'm still trying to rebuild my system | 07:31 |
Haarg | rebuild? | 07:31 |
+perlDreamer | when I switched to Ubuntu, I installed the webgui package | 07:33 |
+perlDreamer | apparently, I deleted it | 07:34 |
+perlDreamer | and it took every dependency out with it | 07:34 |
+perlDreamer | I'm almost back up with all required modules | 07:34 |
+perlDreamer | but I'll guess I'll find out... | 07:34 |
Haarg | ah fun | 07:34 |
Haarg | i'd probably end up just compiling my own perl. don't have much choice on os x. | 07:34 |
+perlDreamer | maybe the perl community has shot themselves in the foot by not paying more attention the OS distributors | 07:39 |
Haarg | i don't know about that. there's been a bunch of work on cpan metadata to help with distributors | 07:39 |
Haarg | of course, the @INC order was only corrected recently unfortunately | 07:40 |
+perlDreamer | yeah | 07:40 |
Haarg | but with that and stuff local::lib, i think they've done as much as possible to help packagers, and made other solutions for where that isn't enough | 07:41 |
Haarg | http://gist.github.com/434054 | 07:41 |
+perlDreamer | it's supposed to work both ways? | 07:42 |
Haarg | yes | 07:42 |
+perlDreamer | I mean, open checks for that | 07:42 |
Haarg | yes | 07:42 |
Haarg | well, it's supposed to | 07:42 |
+perlDreamer | :) | 07:42 |
+perlDreamer | sounds like we need more tests | 07:42 |
Haarg | silly me not checking that | 07:42 |
Haarg | yes, it does | 07:43 |
Haarg | couldn't remember if that was something i had only gotten into psgi | 07:43 |
Haarg | and if you wanted to pass it a filename, the correct thing to use would be pathToFile | 07:43 |
+perlDreamer | it won't work with the temporary filenames | 07:44 |
+perlDreamer | WebGUI::Config takes them and makes them relate to configBase | 07:44 |
+perlDreamer | which means temporary files would have to be in etc | 07:44 |
Haarg | well, in 8 with WebGUI::Paths, i made it so you can pass in an absolute path | 07:44 |
+perlDreamer | but this is 8 that we're working on | 07:44 |
+perlDreamer | mysql won't start, I'm going to try a reboot | 07:45 |
+perlDreamer | back in 10 | 07:45 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 07:45 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 07:49 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 07:49 |
Haarg | welcome back | 07:49 |
+perlDreamer | yay, mysql isn't borked anymore | 07:49 |
+perlDreamer | I see the code in Config.pm that checks for absolute paths | 07:52 |
+perlDreamer | which can only mean that the config path isn't absolute. | 07:52 |
Haarg | yeah, that code is fine | 07:52 |
Haarg | (although i just changed it) | 07:52 |
CIA-60 | webgui: Graham Knop WebGUI8 * rb1b1a3c / lib/WebGUI/Asset/Wobject/Gallery.pm : force scalar context in some needed places - http://bit.ly/bHbm4T | 07:52 |
CIA-60 | webgui: Graham Knop WebGUI8 * r870d3e5 / lib/WebGUI/Operation/Settings.pm : add require for needed module - http://bit.ly/9XUeIn | 07:52 |
CIA-60 | webgui: Graham Knop WebGUI8 * r24c8e0d / lib/WebGUI/Group.pm : reset groups for asset classes listed in database instead of in config file - http://bit.ly/b2sUsj | 07:52 |
CIA-60 | webgui: Graham Knop WebGUI8 * rdfa1a3d / (lib/WebGUI/Config.pm lib/WebGUI/Session.pm): temporary config file fix - http://bit.ly/d9rtcH | 07:52 |
Haarg | it's just that it is trying to use just the file name to duplicate the session | 07:53 |
Haarg | which won't work | 07:53 |
Haarg | i'll fix that same issue in 7.x too | 07:53 |
Haarg | although i'm not sure how | 07:53 |
+perlDreamer | but the filename is absolute, it should pass | 07:54 |
+perlDreamer | unless it's getting stripped somewhere | 07:54 |
Haarg | just the base file name | 07:54 |
Haarg | getFilename just gives you the file's base name with no path | 07:54 |
Haarg | pathToFile gives you the full thing | 07:54 |
Haarg | the problem should be fixed now though for WebGUI8 at least | 07:55 |
Haarg | http://gist.github.com/434066 can you do a quick look at this for anything that doesn't look right? | 07:57 |
+perlDreamer | why is it behaving differently standalone versus in the suite? | 07:58 |
Haarg | i have no idea | 07:58 |
Haarg | i get the same failure if i just run StoryArchive.t on its own | 07:59 |
Haarg | without the fix | 07:59 |
+perlDreamer | it looks like the patch removes all the unmocks | 08:00 |
Haarg | for the most part they aren't needed | 08:00 |
Haarg | they are automatically unmocked when the object is destroyed | 08:01 |
+perlDreamer | so when we run this with Test::Aggregate it will DTRT | 08:01 |
Haarg | it should | 08:01 |
Haarg | i'll stick some docs in the new package for stuff | 08:01 |
+perlDreamer | I'm starting to want a Test::Most::WebGUI module | 08:03 |
+perlDreamer | the patch looks okay | 08:03 |
Haarg | and the tests it modifies do pass | 08:04 |
+perlDreamer | that's good proof :) | 08:04 |
* perlDreamer needs to head to bed | 08:04 |
+perlDreamer | to recap | 08:04 |
+perlDreamer | we should be back in the testing groove | 08:05 |
+perlDreamer | we need tests for Session->open, with objects, and with filenames | 08:05 |
Haarg | a good idea | 08:05 |
Haarg | i'll fix that issue with temp configs in 7.x | 08:05 |
+perlDreamer | pending on support board work, I'll write the tests | 08:05 |
+perlDreamer | and for sure will get in a full test suite run for a double check | 08:06 |
Haarg | and i'll add docs for the new test modules | 08:06 |
+perlDreamer | thanks for staying up and working on this stuff with me | 08:06 |
CIA-60 | webgui: Graham Knop WebGUI8 * r49be762 / (11 files in 7 dirs): mock asset test package - http://bit.ly/alcoxY | 08:06 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 08:07 |
-!- kaare [~kaare@langebro.adapt.dk] has joined #webgui | 08:25 |
-!- kaare is now known as Guest44837 | 08:26 |
CIA-60 | webgui: Graham Knop WebGUI8 * rcc7f83a / (2 files): add documentation for new test modules - http://bit.ly/bpI5Zs | 08:42 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Ping timeout: 240 seconds] | 11:56 |
-!- bartjol [~bartjol@kantoor.procolix.com] has joined #webgui | 12:22 |
-!- mode/#webgui [+v bartjol] by ChanServ | 12:22 |
-!- carogray [~Caroline@174-153-29-197.pools.spcsdns.net] has joined #webgui | 12:54 |
-!- Guest44837 [~kaare@langebro.adapt.dk] has quit [Remote host closed the connection] | 13:36 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has joined #webgui | 14:23 |
-!- carogray1 [~Caroline@173-100-14-221.pools.spcsdns.net] has joined #webgui | 14:31 |
-!- carogray [~Caroline@174-153-29-197.pools.spcsdns.net] has quit [Ping timeout: 272 seconds] | 14:34 |
-!- carogray1 [~Caroline@173-100-14-221.pools.spcsdns.net] has quit [Read error: Connection reset by peer] | 14:42 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 15:01 |
-!- daviddelikat [~user@h69-129-206-153.mdsnwi.broadband.dynamic.tds.net] has quit [Quit: Leaving.] | 15:14 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has joined #webgui | 15:20 |
-!- SDuensin [~Scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving] | 15:49 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 16:01 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 16:10 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Quit: Leaving.] | 16:21 |
-!- SDuensin [~Scott@21.sub-97-187-95.myvzw.com] has joined #webgui | 16:40 |
SDuensin | Crikies. Is it Monday again?! | 16:48 |
+bartjol | SDuensin: for you, sure if you want | 16:57 |
SDuensin | Not really. | 16:59 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 17:41 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 17:41 |
+perlDreamer | Haarg++ for MockAsset test packages | 17:41 |
+perlDreamer | off to drop kids off at school, back in 20 | 17:46 |
-!- MrHairgrease [~martin@194.171.50.69] has joined #webgui | 17:53 |
-!- mode/#webgui [+v MrHairgrease] by ChanServ | 17:53 |
+perlDreamer | hey, MrHairgrease! | 17:58 |
+MrHairgrease | howdy! | 17:58 |
+perlDreamer | how's things back east | 17:58 |
+MrHairgrease | in need of weekend =) | 17:58 |
+MrHairgrease | luckily that'll be in about half an hour | 17:58 |
+MrHairgrease | and how's life in the west? | 17:59 |
+MrHairgrease | wild? | 17:59 |
+perlDreamer | wet | 18:00 |
+MrHairgrease | i see | 18:00 |
+perlDreamer | wildness starts in 1.5 weeks | 18:00 |
+MrHairgrease | the weather is kinda shabby overhere as well | 18:00 |
+MrHairgrease | what'll happen in 1.5 weeks? | 18:00 |
+perlDreamer | the kids get out of school and invade the peaceful sanctity of perlDreamer Consulting | 18:00 |
+MrHairgrease | oi | 18:01 |
+MrHairgrease | seems like you have a bad case of... | 18:01 |
+MrHairgrease | The Children | 18:01 |
+MrHairgrease | =) | 18:01 |
+MrHairgrease | By then I'll be at Rory's wedding | 18:01 |
+MrHairgrease | all the way in France | 18:01 |
+perlDreamer | is his wife from France? | 18:01 |
+MrHairgrease | togetehr with Oqapi's, Procolix' and JT and Sarah are also supposed to come | 18:02 |
+MrHairgrease | no his wife is also from Voorburg | 18:02 |
+perlDreamer | sounds like a party! | 18:02 |
+MrHairgrease | but they figured if they get married, why not do it in some place everybody has to drive 9 hours for =) | 18:02 |
+MrHairgrease | I guess it will be | 18:02 |
+MrHairgrease | and after that I'll be camping with Marijn for a week | 18:02 |
+MrHairgrease | to unhaste | 18:03 |
+MrHairgrease | We can loan the company car, which is a Smart car. | 18:03 |
+MrHairgrease | Hopefully the tent and a bag will fit =) | 18:04 |
+perlDreamer | hopefully you and Marijn fit :) | 18:06 |
+MrHairgrease | we can always put Marijn on the roof =) | 18:09 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has joined #webgui | 18:09 |
+perlDreamer | she's streamlined, it'll go with the whole Smart car theme | 18:10 |
+MrHairgrease | I'll pass on the compliment | 18:11 |
+bartjol | martin's deer is calling procolix | 18:13 |
-!- plainhao [~plainhao@mail.xbiotica.com] has joined #webgui | 18:14 |
-!- bartjol [~bartjol@kantoor.procolix.com] has quit [Quit: Leaving.] | 18:16 |
-!- MrHairgrease [~martin@194.171.50.69] has left #webgui [] | 18:17 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Quit: Leaving.] | 18:28 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 18:35 |
-!- mode/#webgui [+o preaction] by ChanServ | 18:35 |
+perlDreamer | morning, preaction | 18:35 |
+perlDreamer | If you have a Red Hat 5-like system with its mysql package installed, will you nuke the system with yum remove mysql? | 18:42 |
-!- dionak [~dionak@cpe-024-074-157-216.carolina.res.rr.com] has quit [Read error: Connection reset by peer] | 18:45 |
+perlDreamer | mmmm, mapping ,r => wgd reset is a good move | 18:52 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 19:11 |
-!- mode/#webgui [+v patspam] by ChanServ | 19:12 |
+perlDreamer | ~~ morning, patspam | 19:14 |
+perlDreamer | Haarg, almost back to normal | 19:20 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r33640e6 / t/Asset/AssetExportHtml.t : Fix a storage clean-up. - http://bit.ly/dyc5RC | 19:20 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r4a8b88d / sbin/testEnvironment.pl : Ubuntu does not install Package::Stash with other dependencies. Added it to testEnvironment.pl - http://bit.ly/aRGfca | 19:20 |
+perlDreamer | having problems with group clean-ups, but I'll track them down | 19:20 |
Haarg | http://gist.github.com/434705 thoughts? for master. sub name is wrong but i couldn't think of a good name. | 19:22 |
+perlDreamer | there's no "sub name" in that patch | 19:23 |
+perlDreamer | just openForSite | 19:23 |
Haarg | yes | 19:23 |
Haarg | openForSite is a bad name | 19:23 |
+perlDreamer | oh, I see | 19:23 |
+perlDreamer | how about reopen? | 19:25 |
+perlDreamer | and why pull it out of sub duplicate? | 19:25 |
Haarg | was checking the code base for places making new sessions. a bunch of them need new session ids. | 19:26 |
+perlDreamer | but, if you need a new sessionId, why not just use open? | 19:26 |
Haarg | because then you have to figure out the config file path to give it | 19:27 |
Haarg | which is not entirely obvious and currently wrong in most places | 19:27 |
+perlDreamer | yeah | 19:28 |
+perlDreamer | how do you feel about "overloading" it? | 19:28 |
+perlDreamer | if called as a class method, make a new one | 19:29 |
+perlDreamer | if called as an object method, then make a new session with the same config, but new sessionId? | 19:29 |
Haarg | might be reasonable | 19:30 |
+perlDreamer | everything else I think of, like "reopen", "duplicate", "clone", "replicate" sounds like making exactly the same as I have now | 19:32 |
+perlDreamer | and what we want is almost the same as now | 19:32 |
@khenn | perlDreamer: isn't there a script somewhere for converting templates from H::T to T::T ? | 19:55 |
+perlDreamer | frodwith has such a beast | 19:55 |
+perlDreamer | I have a copy of it, but he may have something more recent | 19:55 |
+perlDreamer | I'll email it to you | 19:55 |
@frodwith | i -do- have something more recent | 19:56 |
@frodwith | http://github.com/frodwith/html-template-templatetoolkit | 19:56 |
@frodwith | it works better | 19:56 |
@frodwith | since it's an actual parser, instead of a really really naive set of regexs | 19:56 |
@khenn | cool | 19:57 |
@khenn | I'm doing a lot of this lately and it's starting to annoy | 19:57 |
@frodwith | yeah, it gets old quickly. | 19:58 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 20:00 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 20:01 |
-!- mode/#webgui [+o preaction] by ChanServ | 20:01 |
@scrottie | I'm looking at doing some of those pesky business day-only errands and then parking at a coffee shop for a while. Besides needing to do errands, I need to get out of the house. | 20:18 |
+perlDreamer | Haarg, I think that's the last test from our upgrading/updating last night | 20:22 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r509b833 / lib/WebGUI/Group.pm : quickArray returns 1 row, buildArray returns all rows - http://bit.ly/9FXr3o | 20:22 |
+perlDreamer | if this passes, I'll start writing those Session tests | 20:22 |
+perlDreamer | working with a database redefines code coverage | 20:28 |
+perlDreamer | it's almost as bad as working with regular expressions | 20:28 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has joined #webgui | 20:36 |
-!- mode/#webgui [+o tavisto] by ChanServ | 20:36 |
@scrottie | hrm, a mocked DBI::mysql that just returned abuse would be interesting. | 20:38 |
@scrottie | er, DBD | 20:40 |
-!- knowmad [~william@97.66.185.250] has joined #webgui | 20:42 |
CIA-60 | webgui: Colin Kuskie master * r2c1e2b9 / lib/WebGUI/Group.pm : quickArray returns 1 row, buildArray returns all rows - http://bit.ly/bOOGFS | 20:48 |
CIA-60 | webgui: Colin Kuskie webgui-7.8 * r5ca2583 / lib/WebGUI/Group.pm : quickArray returns 1 row, buildArray returns all rows - http://bit.ly/9LqbxZ | 20:53 |
-!- vayde [~vayde@71-34-30-101.mpls.qwest.net] has quit [Remote host closed the connection] | 21:02 |
+perlDreamer | SynQ: you still on for WRE work tomorrow? | 21:04 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 21:13 |
+perlDreamer | Haarg, the changes to resetGroupFields are bumping up against my infamous JSONCollateral | 21:22 |
+perlDreamer | JSONCollateral needs to now both be something that works with Class::C3 for FilePump/Bundle (which uses CRUD) and the Calendar, which uses Moose | 21:23 |
+perlDreamer | and needs a Role | 21:24 |
+perlDreamer | rewriting FilePump::Bundle to use Moose and Definition is an option | 21:25 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has joined #webgui | 21:39 |
-!- knowmad [~william@97.66.185.250] has left #webgui [] | 21:40 |
+perlDreamer | Haarg: http://gist.github.com/434882 | 21:48 |
+perlDreamer | should that be db->dbh, or s/do/write/; ? | 21:48 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r4b730ac / lib/WebGUI/Role/Asset/Comments.pm : Use the right fieldtype for JSON fields in the db. - http://bit.ly/bOnoaa | 21:54 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rb8fc033 / lib/WebGUI/Asset/Wobject/Calendar.pm : Update the icalFeeds field to use JSON fields correctly. - http://bit.ly/aQSezC | 21:54 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r9b071c1 / (3 files in 3 dirs): Update the JSON collateral test. Duplicate JSONCollateral into a Role so it can be used with Assets. - http://bit.ly/a2m4sz | 21:54 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rc373341 / t/lib/WebGUI/Test.pm : do is for database handles, write is for WebGUI::SQL. - http://bit.ly/chds6p | 21:54 |
@scrottie | I had a pretty good hunch you'd knock that one down before I figured it out. | 21:54 |
+perlDreamer | it was necessity | 21:55 |
@scrottie | yup. | 21:55 |
+perlDreamer | but surprisingly easier for Assets than I thought | 21:55 |
@scrottie | when you know what you're doing ;) | 21:55 |
+perlDreamer | however, now we have two JSON Collateral modules | 21:55 |
+perlDreamer | and that's not good | 21:55 |
@scrottie | duplicate in APIs sounds unavoidable. duplication in code can be minimized. dunno. | 21:55 |
@scrottie | duplication | 21:55 |
@scrottie | looks like I have some WebGUI7 features for Monday so I'm thinking I might just work on my badly neglected YAPC stuff and then flop over to that Monday. | 21:56 |
+perlDreamer | what kind of features? | 21:57 |
@scrottie | http://gist.github.com/434897 | 21:58 |
+perlDreamer | that'll be easy | 21:58 |
+perlDreamer | and good work to start learning the API | 21:59 |
+perlDreamer | the most common beginner mistakes: | 21:59 |
+perlDreamer | 1) Didn't write an upgrade subroutine to add the field to the database | 21:59 |
+perlDreamer | 2) Didn't i18n the label and hover help | 21:59 |
@scrottie | hey, frodwith, I fired up the Skype Linux beta and the thing is freaking out. It won't stop giving me notifications that it's your birthday. Previous Linux Skypes just crash and take out Linux a lot. Is this a bug or a feature? | 21:59 |
@frodwith | but it's not my birthday | 21:59 |
@frodwith | till tomorrow | 22:00 |
@scrottie | well, I've dismissed about 20 notifications now. | 22:00 |
+perlDreamer | frodwith's birthday is important | 22:00 |
@scrottie | so hurry the hell up and have your birthday. | 22:00 |
+perlDreamer | Skype doesn't want you to forget to get him a present | 22:00 |
@frodwith | I have made scrottie's day more annoying. Success! | 22:00 |
+perlDreamer | and it's giving you 12 hours notice | 22:00 |
@scrottie | haha | 22:00 |
@scrottie | I guess the Mac Skype just hits ftd.com with your credit card number for you and then tells you about it after the fact. | 22:01 |
@scrottie | perlDreamer: noted. thanks. I'll invent some new newbie mistakes. | 22:01 |
-!- carogray [~Caroline@host2.209.113.248.conversent.net] has quit [Read error: Connection reset by peer] | 22:08 |
+perlDreamer | 14 tests to go | 22:09 |
+perlDreamer | preaction, to get to 0, some POD needs to be written for FormBuilder stuff | 22:10 |
+perlDreamer | and the FormBuilder packages have to pass, too | 22:10 |
@preaction | just ignore them for now, they're not being used by anything yet, and they are being tested/documented in my local copy | 22:10 |
+perlDreamer | okay, sounds good | 22:10 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r91d94ab / t/Asset/Wobject/Survey/ExpressionEngine.t : Update this test for the changes to the Survey. - http://bit.ly/bQduq5 | 22:16 |
+perlDreamer | 12 tests | 22:17 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rbb78682 / t/Workflow/Activity/ExpireIncompleteSurveyResponses.t : Update this test for the method name change, surveyJSON -> getSurveyJSON - http://bit.ly/9SMmWW | 22:17 |
-!- plainhao [~plainhao@mail.xbiotica.com] has quit [Quit: plainhao] | 22:35 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has joined #webgui | 22:43 |
-!- SDuensin [~Scott@21.sub-97-187-95.myvzw.com] has quit [Quit: Leaving] | 22:55 |
+perlDreamer | JavaScript::Minifier::XS throws an exception in WebGUI8, but works fine in master and 7.8 | 22:57 |
-!- scrottie [~scrottie@ip72-201-253-58.ph.ph.cox.net] has quit [Ping timeout: 265 seconds] | 23:02 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * ra766179 / (etc/WebGUI.conf.original var/upgrades/upgrade_7.9.3-8.0.0.pl): Add maintenancePage to the config file. - http://bit.ly/aqpWXE | 23:07 |
+perlDreamer | wgd edit's not working in 8, either | 23:11 |
Haarg | perlDreamer, re: http://gist.github.com/434882 | 23:26 |
Haarg | should be $db->write( $sql, \@params ); | 23:26 |
Haarg | for 7.x | 23:26 |
* perlDreamer is a good guesser today | 23:29 |
+perlDreamer | what about 8.x? | 23:30 |
Haarg | do as it is should be correct | 23:30 |
+perlDreamer | it wasn't working that way in 8 | 23:31 |
+perlDreamer | maybe it was a partial merge/commit ? | 23:31 |
Haarg | akc | 23:31 |
Haarg | ack | 23:31 |
Haarg | psgi | 23:31 |
+perlDreamer | wrong branch? | 23:32 |
Haarg | ->do( would work in psgi | 23:32 |
Haarg | i really need to work on that so it can be merged and i can stop making dumb mistakes like that | 23:32 |
Haarg | ::SQL is psgi is a DBI subclass | 23:33 |
+perlDreamer | we are only 5 tests away from being mergable | 23:33 |
+perlDreamer | Asset/Wobject/Survey.t | 23:34 |
+perlDreamer | FilePump/Bundle.t | 23:34 |
+perlDreamer | Asset/EMSSubmissionForm.t | 23:34 |
+perlDreamer | Asset/Asset_diagnose.t | 23:34 |
+perlDreamer | ./Asset/File/GalleryFile/Photo/view.t | 23:35 |
+perlDreamer | I'm working on the EMSSubmissionForm test now | 23:35 |
+perlDreamer | POD.t, FormBuilder.t, FormBuilder/Tab.t we're supposed to ignore | 23:36 |
+perlDreamer | i18n/template.t needs a new package, which I can't make yet | 23:36 |
+perlDreamer | but that's just to fix an i18n label | 23:39 |
--- Day changed Sat Jun 12 2010 |
@khenn | preaction++ | 00:01 |
@khenn | just because I love WebGUI::AssetAspect::Installable | 00:02 |
+perlDreamer | EMSSubmissionForm can't be fixed until we have in-memory assets | 00:06 |
+perlDreamer | EMSSubmission, and EMSSubmissionForm both need fully active assets, so they can call $self->getFormProperties on them | 00:08 |
+perlDreamer | and the www_editSubmission{,Form} methods can be called as class constructors, so they may not have a $self to work on | 00:08 |
+perlDreamer | maybe we need another, parallel method in meta for doing things like that | 00:09 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has quit [Quit: Leaving.] | 00:09 |
+perlDreamer | because they don't need the actual values, aside from defaults | 00:09 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has joined #webgui | 00:11 |
* perlDreamer is off to pick up kids | 00:11 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Quit: Leaving.] | 00:16 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has joined #webgui | 00:17 |
-!- daviddelikat [~user@h69-128-106-50.mdsnwi.dedicated.static.tds.net] has quit [Ping timeout: 258 seconds] | 00:23 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has quit [Quit: Leaving.] | 00:30 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has joined #webgui | 00:31 |
-!- carogray [~Caroline@173-101-190-93.pools.spcsdns.net] has quit [Read error: Connection reset by peer] | 00:55 |
-!- tavisto [~tavisto@pool-71-186-22-44.gdrpmi.dsl-w.verizon.net] has quit [Quit: tavisto] | 00:57 |
-!- scrottie [~scrottie@70.96.30.147] has joined #webgui | 01:13 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rbe4ea78 / t/FilePump/Bundle.t : Fetch fresh assets, test fails due to seg fault from JavaScript::Minifier::XS - http://bit.ly/dg2fn4 | 01:44 |
+perlDreamer | ugly, ugly, ugly | 01:45 |
* perlDreamer is out for a while. Later guys | 01:45 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 01:45 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Read error: Connection reset by peer] | 02:20 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 02:20 |
-!- mode/#webgui [+v patspam] by ChanServ | 02:20 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has quit [Ping timeout: 245 seconds] | 03:04 |
scrottie | eek | 03:09 |
-!- scrottie [~scrottie@70.96.30.147] has quit [Ping timeout: 245 seconds] | 03:14 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 03:45 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 04:05 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 04:08 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 04:23 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 04:23 |
-!- SDuensin [~scott@173-28-73-10.client.mchsi.com] has joined #webgui | 04:37 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r1e55078 / t/Asset/Asset_diagnose.t : Update this test for WebGUI::Definition; - http://bit.ly/cqu55A | 04:43 |
-!- scrottie [~scrottie@wsip-70-184-77-123.tc.ph.cox.net] has joined #webgui | 04:43 |
+perlDreamer | scrottie: you un-eeked | 04:43 |
-!- SDuensin [~scott@173-28-73-10.client.mchsi.com] has quit [Read error: Connection reset by peer] | 04:46 |
-!- SDuensin [~scott@173-28-73-10.client.mchsi.com] has joined #webgui | 04:46 |
-!- scrottie [~scrottie@wsip-70-184-77-123.tc.ph.cox.net] has quit [Ping timeout: 245 seconds] | 04:49 |
-!- scrottie [~scrottie@wsip-70-184-77-123.tc.ph.cox.net] has joined #webgui | 04:51 |
-!- mode/#webgui [+o scrottie] by ChanServ | 04:51 |
@scrottie | wifi reception here is poor. | 04:51 |
@scrottie | perlDreamer, shouldn't you be out jetskiing? or rock climbing? | 04:52 |
@scrottie | hot air ballooning? | 04:52 |
+perlDreamer | I think you're thinking of kimd | 04:52 |
* perlDreamer is just an old fuddy duddy dad | 04:52 |
@scrottie | I wonder if the "old" part is true. | 04:52 |
* perlDreamer is old | 04:53 |
+perlDreamer | even in hexadecimal | 04:53 |
@scrottie | still dubious. still think you should be parasailing. | 04:54 |
@scrottie | or at least drinking microbrew. | 04:54 |
+perlDreamer | how does lemon tea with honey strike you? | 04:54 |
@scrottie | nothing against it. | 04:54 |
@scrottie | fly kites. | 04:55 |
@scrottie | do they have water parks in Portland? | 04:55 |
+perlDreamer | not really | 04:55 |
+perlDreamer | North Clackamas Water Park is the closest thing we have to do that | 04:56 |
+perlDreamer | you have to build indoor water parks, since it rains in !July | 04:56 |
@scrottie | gtg. just told that I myself am being antisocial. | 04:57 |
@scrottie | lasertag. | 04:57 |
@scrottie | everyone loves lasertag. | 04:57 |
-!- scrottie [~scrottie@wsip-70-184-77-123.tc.ph.cox.net] has quit [Ping timeout: 240 seconds] | 05:02 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 05:02 |
+perlDreamer | yes, Survey.t is working! | 05:10 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r7df0cc5 / (lib/WebGUI/Asset/Wobject/Survey.pm t/Asset/Wobject/Survey.t): Always get a fresh copy of the survey after doing revision control. - http://bit.ly/cdJbL3 | 05:12 |
+perlDreamer | Haarg, you'll never believe it! | 05:33 |
+perlDreamer | Asset_diagnose showed something useful. | 05:33 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 05:37 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 05:38 |
+perlDreamer | Merge - 1 Test and counting | 05:45 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * r416c373 / t/Asset/AssetExportHtml.t : Fix cleaning up some files. Asset->new is not to be used unless you know what you're doing. - http://bit.ly/dwl4i1 | 05:46 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has quit [Quit: Leaving.] | 05:50 |
+perlDreamer | last test run | 06:03 |
+perlDreamer | that's it | 06:18 |
+perlDreamer | we're as stable as we can get | 06:18 |
CIA-60 | webgui: Colin Kuskie WebGUI8 * rdcdd671 / (2 files in 2 dirs): Fix the pending flag, get a fresh copy of the photo asset under test. - http://bit.ly/akyj90 | 06:19 |
+perlDreamer | that's it folks | 06:24 |
+perlDreamer | last fixable test core test | 06:24 |
+perlDreamer | time to merge in the PSGI branch | 06:24 |
+perlDreamer | got all the modules installed | 06:49 |
+perlDreamer | time to pack it in for tonight | 06:49 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has quit [Quit: Leaving.] | 06:49 |
CIA-60 | webgui: Graham Knop WebGUI8 * r169218a / t/lib/WebGUI/Test.pm : fix mistake in WebGUI::Test - http://bit.ly/aDPUGq | 07:06 |
CIA-60 | webgui: Graham Knop WebGUI8 * re063818 / (5 files in 5 dirs): some URL fixes and removing some uses of PseudoRequest - http://bit.ly/aqml4f | 07:06 |
CIA-60 | webgui: Graham Knop WebGUI8 * r89d4f46 / (94 files in 30 dirs): Merge branch 'psgi' into WebGUI8 - http://bit.ly/9xXnmU | 07:06 |
CIA-60 | webgui: Graham Knop psgi * r169218a / t/lib/WebGUI/Test.pm : fix mistake in WebGUI::Test - http://bit.ly/aDPUGq | 07:06 |
CIA-60 | webgui: Graham Knop psgi * re063818 / (5 files in 5 dirs): some URL fixes and removing some uses of PseudoRequest - http://bit.ly/aqml4f | 07:06 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 07:18 |
-!- mode/#webgui [+o preaction] by ChanServ | 07:18 |
CIA-60 | webgui: Graham Knop WebGUI8 * r650918e / (5 files in 2 dirs): remove left over upgrades - http://bit.ly/cNa13Q | 07:39 |
CIA-60 | webgui: Graham Knop yui-cdn * rf2de5fa / (38 files in 12 dirs): start of YUI from CDN - http://bit.ly/auor39 | 07:41 |
CIA-60 | webgui: Graham Knop upgrades * rea5471a / lib/WebGUI/Upgrade/File/wgpkg.pm : fix wgpkg upgrade class (+599 more commits...) - http://bit.ly/9EsYs8 | 07:42 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has quit [Quit: zzzzzzzzzz] | 08:03 |
CIA-60 | webgui: Graham Knop no-utility * r95431a9 / (101 files in 29 dirs): remove WebGUI::Utility (+599 more commits...) - http://bit.ly/d1wceA | 08:11 |
@preaction | Haarg: is that yui2 or yui3? if all goes according to plan, frodwith will be migrating us to yui 2in3 | 09:42 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Quit: preaction] | 09:49 |
Haarg | that's 2 | 09:54 |
Haarg | the method i created in it is called yui2 | 09:55 |
Haarg | it's something i did a while back, i was just rebasing my branches | 09:55 |
Haarg | oh yes i should keep talking to myself | 09:55 |
CIA-60 | webgui: Graham Knop intercept-logger-callback * r2617f41 / (t/Workflow/Instance.t t/lib/WebGUI/Test.pm): use callback for log interception instead of on/off - http://bit.ly/d3XV4o | 13:37 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has joined #webgui | 15:50 |
-!- mode/#webgui [+o preaction] by ChanServ | 15:50 |
-!- preaction [~doug@71-90-29-59.dhcp.ftbg.wi.charter.com] has quit [Client Quit] | 15:51 |
-!- stDavid [~stDavid@static-72-64-138-146.tampfl.fios.verizon.net] has joined #webgui | 18:32 |
-!- perlDreamer [~colink@pool-173-50-255-102.ptldor.fios.verizon.net] has joined #webgui | 18:33 |
-!- mode/#webgui [+v perlDreamer] by ChanServ | 18:33 |
+perlDreamer | SynQ: Saturday morning checkin | 18:33 |
+perlDreamer | breakfast time, bbiab | 18:37 |
-!- patspam [~patspam@pool-96-232-149-145.nycmny.east.verizon.net] has joined #webgui | 18:56 |
-!- mode/#webgui [+v patspam] by ChanServ | 18:56 |
* perlDreamer is back! | 19:14 |
+perlDreamer | let's merge | 19:14 |
+perlDreamer | let's work on the WRE | 19:14 |
+perlDreamer | ANYTHING TO KEEP ME FROM DOING YARD WORK | 19:14 |
SDuensin | perlDreamer! | 20:28 |
SDuensin | I got one for you... Woke up today to a zero-byte wre.conf. | 20:28 |
-!- SDuensin [~scott@173-28-73-10.client.mchsi.com] has quit [Quit: Leaving.] | 20:35 |
-!- SDuensin1 [~scott@173-28-73-10.client.mchsi.com] has joined #webgui | 20:35 |
+perlDreamer | zero-byte wre.conf.... | 21:29 |
+perlDreamer | which version of the WRE are you using, SDuensin, SDuensin1? | 21:29 |
-!- carogray [~Caroline@c-75-68-17-12.hsd1.nh.comcast.net] has joined #webgui | 22:47 |
SDuensin1 | Sorry. Went to eat. | 23:59 |
SDuensin1 | I thought I had 0.9.3 but the config file says 0.9.2. | 23:59 |
---|